Modified: releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog (214812 => 214813)
--- releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog 2017-04-03 17:20:10 UTC (rev 214812)
+++ releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog 2017-04-03 17:23:43 UTC (rev 214813)
@@ -1,3 +1,17 @@
+2017-03-31 Carlos Garcia Campos <cgar...@igalia.com>
+
+ Modern media controls should never be enabled in non cocoa ports
+ https://bugs.webkit.org/show_bug.cgi?id=170338
+
+ Reviewed by Michael Catanzaro.
+
+ It's currently enabled, because it uses the default value for all other runtime features, but modern media
+ controls are not a cross-platform feature. I think this is why media/video-click-dblckick-standalone.html
+ started to fail in GTK+ port after r214426. I can't reprouduce the failure locally, so I can't confirm it,
+ though.
+
+ * Shared/WebPreferencesDefinitions.h:
+
2017-04-03 Antti Koivisto <an...@apple.com>
Mutex may be freed too late in NetworkCache::Storage::traverse
Modified: releases/WebKitGTK/webkit-2.16/Source/WebKit2/Shared/WebPreferencesDefinitions.h (214812 => 214813)
--- releases/WebKitGTK/webkit-2.16/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-04-03 17:20:10 UTC (rev 214812)
+++ releases/WebKitGTK/webkit-2.16/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-04-03 17:23:43 UTC (rev 214813)
@@ -296,6 +296,12 @@
#define DEFAULT_EXPERIMENTAL_FEATURES_ENABLED false
#endif
+#if PLATFORM(COCOA)
+#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED true
+#else
+#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED false
+#endif
+
// For experimental features:
// - The type should be boolean.
// - You must provide the last two parameters for all experimental features. They
@@ -309,7 +315,7 @@
macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "CSS Spring Animations", "CSS Spring Animation prototype") \
macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Gamepads", "Web Gamepad API support") \
macro(LinkPreloadEnabled, linkPreloadEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Link Preload", "Link preload support") \
- macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Modern Media Controls", "Use modern media controls look") \
+ macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED, "Modern Media Controls", "Use modern media controls look") \
macro(InputEventsEnabled, inputEventsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Input Events", "Enable InputEvents support") \
macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, false, "WebRTC", "Enable WebRTC API") \
macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "SubtleCrypto", "Enable SubtleCrypto support") \
