Title: [214826] trunk/Source/_javascript_Core
- Revision
- 214826
- Author
- keith_mil...@apple.com
- Date
- 2017-04-03 11:44:05 -0700 (Mon, 03 Apr 2017)
Log Message
WebAssembly: remove lastAllocatedMode from Memory
https://bugs.webkit.org/show_bug.cgi?id=170405
Reviewed by Mark Lam.
It's not used anymore so there isn't any point in keeping it around.
* wasm/WasmMemory.cpp:
(JSC::Wasm::Memory::createImpl):
(JSC::Wasm::Memory::lastAllocatedMode): Deleted.
* wasm/WasmMemory.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (214825 => 214826)
--- trunk/Source/_javascript_Core/ChangeLog 2017-04-03 18:40:54 UTC (rev 214825)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-04-03 18:44:05 UTC (rev 214826)
@@ -1,3 +1,17 @@
+2017-04-03 Keith Miller <keith_mil...@apple.com>
+
+ WebAssembly: remove lastAllocatedMode from Memory
+ https://bugs.webkit.org/show_bug.cgi?id=170405
+
+ Reviewed by Mark Lam.
+
+ It's not used anymore so there isn't any point in keeping it around.
+
+ * wasm/WasmMemory.cpp:
+ (JSC::Wasm::Memory::createImpl):
+ (JSC::Wasm::Memory::lastAllocatedMode): Deleted.
+ * wasm/WasmMemory.h:
+
2017-04-03 Zan Dobersek <zdober...@igalia.com>
[jsc] Add patchableJumpSize() for MIPS
Modified: trunk/Source/_javascript_Core/wasm/WasmMemory.cpp (214825 => 214826)
--- trunk/Source/_javascript_Core/wasm/WasmMemory.cpp 2017-04-03 18:40:54 UTC (rev 214825)
+++ trunk/Source/_javascript_Core/wasm/WasmMemory.cpp 2017-04-03 18:44:05 UTC (rev 214826)
@@ -73,15 +73,6 @@
return "";
}
-// We use this as a heuristic to guess what mode a memory import will be. Most of the time we expect users to
-// allocate the memory they are going to pass to all their modules right before compilation.
-static MemoryMode lastAllocatedMemoryMode { MemoryMode::Signaling };
-
-MemoryMode Memory::lastAllocatedMode()
-{
- return lastAllocatedMemoryMode;
-}
-
static const unsigned maxFastMemories = 4;
static unsigned allocatedFastMemories { 0 };
StaticLock memoryLock;
@@ -216,7 +207,6 @@
if (mode == MemoryMode::Signaling)
return nullptr;
- lastAllocatedMemoryMode = MemoryMode::BoundsChecking;
return adoptRef(new Memory(initial, maximum));
};
@@ -260,7 +250,6 @@
return nullptr;
}
- lastAllocatedMemoryMode = mode;
dataLogLnIf(verbose, "Memory::create mmap succeeded");
return adoptRef(new Memory(memory, initial, maximum, mappedCapacity, mode));
}
Modified: trunk/Source/_javascript_Core/wasm/WasmMemory.h (214825 => 214826)
--- trunk/Source/_javascript_Core/wasm/WasmMemory.h 2017-04-03 18:40:54 UTC (rev 214825)
+++ trunk/Source/_javascript_Core/wasm/WasmMemory.h 2017-04-03 18:44:05 UTC (rev 214826)
@@ -73,7 +73,6 @@
PageCount initial() const { return m_initial; }
PageCount maximum() const { return m_maximum; }
- static MemoryMode lastAllocatedMode();
MemoryMode mode() const { return m_mode; }
// grow() should only be called from the JSWebAssemblyMemory object since that object needs to update internal
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
