Title: [214831] trunk/Source/WebCore
- Revision
- 214831
- Author
- commit-qu...@webkit.org
- Date
- 2017-04-03 12:35:26 -0700 (Mon, 03 Apr 2017)
Log Message
Do not set WebAVPlayerLayerView background to black in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=170132
rdar://problem/30839278
Patch by Jeremy Jones <jere...@apple.com> on 2017-04-03
Reviewed by Tim Horton.
No new tests because no behavior change.
The black background on WebAVPlayerLayerView interferes with the fullscreen animation
and has been removed.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
(WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (214830 => 214831)
--- trunk/Source/WebCore/ChangeLog 2017-04-03 19:08:07 UTC (rev 214830)
+++ trunk/Source/WebCore/ChangeLog 2017-04-03 19:35:26 UTC (rev 214831)
@@ -1,3 +1,20 @@
+2017-04-03 Jeremy Jones <jere...@apple.com>
+
+ Do not set WebAVPlayerLayerView background to black in fullscreen.
+ https://bugs.webkit.org/show_bug.cgi?id=170132
+ rdar://problem/30839278
+
+ Reviewed by Tim Horton.
+
+ No new tests because no behavior change.
+
+ The black background on WebAVPlayerLayerView interferes with the fullscreen animation
+ and has been removed.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (WebVideoFullscreenInterfaceAVKit::enterFullscreen):
+ (WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard):
+
2017-04-03 Antti Koivisto <an...@apple.com>
REGRESSION (r207669): FileMaker Pro Help pages do not render correctly
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (214830 => 214831)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-04-03 19:08:07 UTC (rev 214830)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-04-03 19:35:26 UTC (rev 214831)
@@ -668,7 +668,6 @@
m_exitRequested = false;
m_enterRequested = true;
- [m_playerLayerView setBackgroundColor:[getUIColorClass() blackColor]];
if (mode() == HTMLMediaElementEnums::VideoFullscreenModePictureInPicture)
enterPictureInPicture();
else if (mode() == HTMLMediaElementEnums::VideoFullscreenModeStandard)
@@ -699,7 +698,6 @@
return;
}
- [m_playerLayerView setBackgroundColor:[getUIColorClass() blackColor]];
[m_playerViewController enterFullScreenAnimated:YES completionHandler:[this, protectedThis] (BOOL succeeded, NSError*) {
UNUSED_PARAM(succeeded);
LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard - lambda(%p) - succeeded(%s)", this, boolString(succeeded));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
