Title: [214840] trunk/Source/WebInspectorUI
- Revision
- 214840
- Author
- commit-qu...@webkit.org
- Date
- 2017-04-03 15:05:04 -0700 (Mon, 03 Apr 2017)
Log Message
Web Inspector: Tooltip for close tab button should match Safari
https://bugs.webkit.org/show_bug.cgi?id=170417
<rdar://problem/31378423>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-04-03
Reviewed by Matt Baker.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/GeneralTabBarItem.js:
(WebInspector.GeneralTabBarItem):
Updated tooltip to match Safari's most descriptive tooltip.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214839 => 214840)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-03 21:26:10 UTC (rev 214839)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-03 22:05:04 UTC (rev 214840)
@@ -1,3 +1,16 @@
+2017-04-03 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Tooltip for close tab button should match Safari
+ https://bugs.webkit.org/show_bug.cgi?id=170417
+ <rdar://problem/31378423>
+
+ Reviewed by Matt Baker.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Views/GeneralTabBarItem.js:
+ (WebInspector.GeneralTabBarItem):
+ Updated tooltip to match Safari's most descriptive tooltip.
+
2017-04-03 Devin Rousso <web...@devinrousso.com>
REGRESSION (r214354): Web Inspector: WebSocket connection icon obscures close content view icon
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (214839 => 214840)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-04-03 21:26:10 UTC (rev 214839)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-04-03 22:05:04 UTC (rev 214840)
@@ -167,6 +167,7 @@
localizedStrings["Clear watch expressions"] = "Clear watch expressions";
localizedStrings["Clear when page navigates"] = "Clear when page navigates";
localizedStrings["Click Listener"] = "Click Listener";
+localizedStrings["Click to close this tab; Option-click to close all tabs except this one"] = "Click to close this tab; Option-click to close all tabs except this one";
localizedStrings["Click to link property values"] = "Click to link property values";
localizedStrings["Click to select a color. Shift-click to switch color formats."] = "Click to select a color. Shift-click to switch color formats.";
localizedStrings["Clickable"] = "Clickable";
@@ -176,7 +177,6 @@
localizedStrings["Close Other Tabs"] = "Close Other Tabs";
localizedStrings["Close Tab"] = "Close Tab";
localizedStrings["Close resource view"] = "Close resource view";
-localizedStrings["Close tab"] = "Close tab";
localizedStrings["Closed"] = "Closed";
localizedStrings["Closure Variables"] = "Closure Variables";
localizedStrings["Closure Variables (%s)"] = "Closure Variables (%s)";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTabBarItem.js (214839 => 214840)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTabBarItem.js 2017-04-03 21:26:10 UTC (rev 214839)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTabBarItem.js 2017-04-03 22:05:04 UTC (rev 214840)
@@ -32,7 +32,7 @@
let closeButtonElement = document.createElement("div");
closeButtonElement.classList.add(WebInspector.TabBarItem.CloseButtonStyleClassName);
- closeButtonElement.title = WebInspector.UIString("Close tab");
+ closeButtonElement.title = WebInspector.UIString("Click to close this tab; Option-click to close all tabs except this one");
this.element.insertBefore(closeButtonElement, this.element.firstChild);
this.element.addEventListener("contextmenu", this._handleContextMenuEvent.bind(this));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
