Title: [215884] trunk/LayoutTests
Revision
215884
Author
mmaxfi...@apple.com
Date
2017-04-27 12:08:22 -0700 (Thu, 27 Apr 2017)

Log Message

REGRESSION(r214572): Update fast/text/variations/advances.html to understand normalized variation widths
https://bugs.webkit.org/show_bug.cgi?id=171356
<rdar://problem/28670085>

Reviewed by Dean Jackson.

Unspecified 'wdth' axis values are being normalized because the font is a GX font. However, this
font assumes no normalization, which means one of the comparisons in the test is bogus.

* fast/text/variations/advances-expected.txt:
* fast/text/variations/advances.html:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (215883 => 215884)


--- trunk/LayoutTests/ChangeLog	2017-04-27 18:40:05 UTC (rev 215883)
+++ trunk/LayoutTests/ChangeLog	2017-04-27 19:08:22 UTC (rev 215884)
@@ -1,3 +1,19 @@
+2017-04-27  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        REGRESSION(r214572): Update fast/text/variations/advances.html to understand normalized variation widths
+        https://bugs.webkit.org/show_bug.cgi?id=171356
+        <rdar://problem/28670085>
+
+        Reviewed by Dean Jackson.
+
+        Unspecified 'wdth' axis values are being normalized because the font is a GX font. However, this
+        font assumes no normalization, which means one of the comparisons in the test is bogus.
+
+        * fast/text/variations/advances-expected.txt:
+        * fast/text/variations/advances.html:
+        * platform/ios/TestExpectations:
+        * platform/mac/TestExpectations:
+
 2017-04-27  Antti Koivisto  <an...@apple.com>
 
         Skip css3/viewport-percentage-lengths/vh-auto-size.html on WK1.

Modified: trunk/LayoutTests/fast/text/variations/advances-expected.txt (215883 => 215884)


--- trunk/LayoutTests/fast/text/variations/advances-expected.txt	2017-04-27 18:40:05 UTC (rev 215883)
+++ trunk/LayoutTests/fast/text/variations/advances-expected.txt	2017-04-27 19:08:22 UTC (rev 215884)
@@ -1,7 +1,6 @@
-PASS regular.offsetWidth is not wide.offsetWidth
-PASS regular.offsetWidth is not narrow.offsetWidth
+PASS specifiedregular.offsetWidth is not wide.offsetWidth
+PASS specifiedregular.offsetWidth is not narrow.offsetWidth
 PASS narrow.offsetWidth is not wide.offsetWidth
-PASS regular.offsetWidth is specifiedregular.offsetWidth
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/text/variations/advances.html (215883 => 215884)


--- trunk/LayoutTests/fast/text/variations/advances.html	2017-04-27 18:40:05 UTC (rev 215883)
+++ trunk/LayoutTests/fast/text/variations/advances.html	2017-04-27 19:08:22 UTC (rev 215884)
@@ -29,10 +29,9 @@
 	var specifiedregular = document.getElementById("specifiedregular");
 	var narrow = document.getElementById("narrow");
 
-	shouldNotBe("regular.offsetWidth", "wide.offsetWidth");
-	shouldNotBe("regular.offsetWidth", "narrow.offsetWidth");
+	shouldNotBe("specifiedregular.offsetWidth", "wide.offsetWidth");
+	shouldNotBe("specifiedregular.offsetWidth", "narrow.offsetWidth");
 	shouldNotBe("narrow.offsetWidth", "wide.offsetWidth");
-	shouldBe("regular.offsetWidth", "specifiedregular.offsetWidth");
 	finishJSTest();
 });
 
@@ -39,4 +38,4 @@
 </script>
 <script src=""
 </body>
-</html>
\ No newline at end of file
+</html>

Modified: trunk/LayoutTests/platform/ios/TestExpectations (215883 => 215884)


--- trunk/LayoutTests/platform/ios/TestExpectations	2017-04-27 18:40:05 UTC (rev 215883)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2017-04-27 19:08:22 UTC (rev 215884)
@@ -2741,7 +2741,6 @@
 webkit.org/b/162739 fast/images/gif-loop-count.html [ Pass ImageOnlyFailure ]
 
 # This variation font test requires Skia which isn't available on iOS.
-webkit.org/b/163093 fast/text/variations/advances.html [ Failure ]
 webkit.org/b/163093 fast/text/variations/outofbounds.html [ ImageOnlyFailure ]
 webkit.org/b/163093 fast/text/variations/default-value.html [ ImageOnlyFailure ]
 webkit.org/b/169518 fast/text/font-variations-feature-detection.html [ ImageOnlyFailure ]

Modified: trunk/LayoutTests/platform/mac/TestExpectations (215883 => 215884)


--- trunk/LayoutTests/platform/mac/TestExpectations	2017-04-27 18:40:05 UTC (rev 215883)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-04-27 19:08:22 UTC (rev 215884)
@@ -1521,8 +1521,6 @@
 
 webkit.org/b/166025 http/tests/fetch/fetching-same-resource-with-diffferent-options.html [ Pass Failure ]
 
-webkit.org/b/166672 [ Sierra+ ] fast/text/variations/advances.html [ Failure ]
-
 webkit.org/b/162507 http/tests/media/hls/hls-video-resize.html [ Pass Failure ]
 
 webkit.org/b/167642 imported/w3c/web-platform-tests/shadow-dom/slotchange.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to