Title: [217746] trunk/Source/WebInspectorUI
- Revision
- 217746
- Author
- drou...@apple.com
- Date
- 2017-06-02 18:18:51 -0700 (Fri, 02 Jun 2017)
Log Message
Web Inspector: The CodeMirror instance in the ConsolePrompt does't need to be refreshed each time it is shown
https://bugs.webkit.org/show_bug.cgi?id=172608
Reviewed by Timothy Hatcher.
* UserInterface/Views/ConsolePrompt.js:
(WebInspector.ConsolePrompt.prototype.shown): Deleted.
* UserInterface/Views/DatabaseContentView.js:
(WebInspector.DatabaseContentView.prototype.shown): Deleted.
* UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (217745 => 217746)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-06-03 01:09:50 UTC (rev 217745)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-06-03 01:18:51 UTC (rev 217746)
@@ -1,5 +1,19 @@
2017-06-02 Devin Rousso <drou...@apple.com>
+ Web Inspector: The CodeMirror instance in the ConsolePrompt does't need to be refreshed each time it is shown
+ https://bugs.webkit.org/show_bug.cgi?id=172608
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ConsolePrompt.js:
+ (WebInspector.ConsolePrompt.prototype.shown): Deleted.
+ * UserInterface/Views/DatabaseContentView.js:
+ (WebInspector.DatabaseContentView.prototype.shown): Deleted.
+ * UserInterface/Views/QuickConsole.js:
+ (WebInspector.QuickConsole):
+
+2017-06-02 Devin Rousso <drou...@apple.com>
+
Web Inspector: Attributes table in Node Details Sidebar should have editable keys and values
https://bugs.webkit.org/show_bug.cgi?id=167076
<rdar://problem/30033629>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js (217745 => 217746)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js 2017-06-03 01:09:50 UTC (rev 217745)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js 2017-06-03 01:18:51 UTC (rev 217746)
@@ -115,11 +115,6 @@
this._codeMirror.focus();
}
- shown()
- {
- this._codeMirror.refresh();
- }
-
updateCompletions(completions, implicitSuffix)
{
this._completionController.updateCompletions(completions, implicitSuffix);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js (217745 => 217746)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js 2017-06-03 01:09:50 UTC (rev 217745)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js 2017-06-03 01:18:51 UTC (rev 217746)
@@ -41,14 +41,6 @@
// Public
- shown()
- {
- super.shown();
-
- // FIXME: remove once <https://webkit.org/b/150741> is fixed.
- this._prompt.shown();
- }
-
saveToCookie(cookie)
{
cookie.type = WebInspector.ContentViewCookieType.Database;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js (217745 => 217746)
--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2017-06-03 01:09:50 UTC (rev 217745)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2017-06-03 01:18:51 UTC (rev 217746)
@@ -53,8 +53,6 @@
// would be for CodeMirror's event handler to pass if it doesn't do anything.
this.prompt.escapeKeyHandlerWhenEmpty = function() { WebInspector.toggleSplitConsole(); };
- this.prompt.shown();
-
this._navigationBar = new WebInspector.QuickConsoleNavigationBar;
this.addSubview(this._navigationBar);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
