Title: [218086] trunk/LayoutTests
Revision
218086
Author
mmaxfi...@apple.com
Date
2017-06-11 22:03:53 -0700 (Sun, 11 Jun 2017)

Log Message

[iOS 11] fast/text/international/system-language/arabic-glyph-cache-fill-combine.html hardcodes the system UI Arabic font
https://bugs.webkit.org/show_bug.cgi?id=173244
<rdar://problem/32659595>

Reviewed by Ryosuke Niwa.

iOS 11 changed this font, so we shouldn't hardcode it. Instead,
we can simply change this to an -expected-mismatch.html test to
specifically test against the ".notdef" glyph.

* fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected-mismatch.html: Renamed from LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html.

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (218085 => 218086)


--- trunk/LayoutTests/ChangeLog	2017-06-12 05:02:38 UTC (rev 218085)
+++ trunk/LayoutTests/ChangeLog	2017-06-12 05:03:53 UTC (rev 218086)
@@ -1,5 +1,19 @@
 2017-06-11  Myles C. Maxfield  <mmaxfi...@apple.com>
 
+        [iOS 11] fast/text/international/system-language/arabic-glyph-cache-fill-combine.html hardcodes the system UI Arabic font
+        https://bugs.webkit.org/show_bug.cgi?id=173244
+        <rdar://problem/32659595>
+
+        Reviewed by Ryosuke Niwa.
+
+        iOS 11 changed this font, so we shouldn't hardcode it. Instead,
+        we can simply change this to an -expected-mismatch.html test to
+        specifically test against the ".notdef" glyph.
+
+        * fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected-mismatch.html: Renamed from LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html.
+
+2017-06-11  Myles C. Maxfield  <mmaxfi...@apple.com>
+
         fast/text/variations/getComputedStyle.html does not need to be asynchronous
         https://bugs.webkit.org/show_bug.cgi?id=173246
         <rdar://problem/31393842>

Copied: trunk/LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected-mismatch.html (from rev 218085, trunk/LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html) (0 => 218086)


--- trunk/LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected-mismatch.html	                        (rev 0)
+++ trunk/LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected-mismatch.html	2017-06-12 05:03:53 UTC (rev 218086)
@@ -0,0 +1,10 @@
+<!DOCTYPE html><!-- webkit-test-runner [ language=ar ] -->
+<html>
+<body>
+This test hits a codepath where codepoints were being combined before they were being input into our glyph cache.
+This character occurs just before combining marks in Unicode, and therefore was being erroneously combined. The test
+passes if the glyph is drawn in a font other than LastResort (if the test fails, the character looks like a box or like
+three horizontal lines).
+<div style="font: 50px UICTFontTextStyleBody;">&#x2B616;<div style="display: inline-block; width: 1px; height: 200px;"></div></div>
+</body>
+</html>

Deleted: trunk/LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html (218085 => 218086)


--- trunk/LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html	2017-06-12 05:02:38 UTC (rev 218085)
+++ trunk/LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html	2017-06-12 05:03:53 UTC (rev 218086)
@@ -1,10 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ language=ar ] -->
-<html>
-<body>
-This test hits a codepath where codepoints were being combined before they were being input into our glyph cache.
-This character occurs just before combining marks in Unicode, and therefore was being erroneously combined. The test
-passes if the glyph is drawn in a font other than LastResort (if the test fails, the character looks like a box or like
-three horizontal lines).
-<div style="font: 50px 'Geeza Pro';">&#x64a;<div style="display: inline-block; width: 1px; height: 200px;"></div></div>
-</body>
-</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to