Title: [218489] trunk/Tools
Revision
218489
Author
carlo...@webkit.org
Date
2017-06-19 05:54:21 -0700 (Mon, 19 Jun 2017)

Log Message

Unreviewed. Fix wrong style checker condition added in r218487.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (218488 => 218489)


--- trunk/Tools/ChangeLog	2017-06-19 12:51:51 UTC (rev 218488)
+++ trunk/Tools/ChangeLog	2017-06-19 12:54:21 UTC (rev 218489)
@@ -1,3 +1,10 @@
+2017-06-19  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        Unreviewed. Fix wrong style checker condition added in r218487.
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_identifier_name_in_declaration):
+
 2017-06-19  Adrian Perez de Castro  <ape...@igalia.com>
 
         Missing <functional> includes make builds fail with GCC 7.x

Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (218488 => 218489)


--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2017-06-19 12:51:51 UTC (rev 218488)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2017-06-19 12:54:21 UTC (rev 218489)
@@ -3419,7 +3419,7 @@
         if not file_state.is_objective_c_or_objective_cpp() and modified_identifier.find('_') >= 0:
             # Various exceptions to the rule: _javascript_ op codes functions, const_iterator.
             if (not (filename.find('_javascript_Core') >= 0 and (modified_identifier.find('op_') >= 0 or modified_identifier.find('intrinsic_') >= 0))
-                and not (('gtk' in filename or 'glib in filename') and modified_identifier.startswith('webkit_') >= 0)
+                and not (('gtk' in filename or 'glib' in filename) and modified_identifier.startswith('webkit_') >= 0)
                 and not modified_identifier.startswith('tst_')
                 and not modified_identifier.startswith('webkit_dom_object_')
                 and not modified_identifier.startswith('webkit_soup')
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to