Title: [218494] trunk/Tools
Revision
218494
Author
pvol...@apple.com
Date
2017-06-19 09:34:44 -0700 (Mon, 19 Jun 2017)

Log Message

[Win] fast/dom/assign-to-window-status.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=173512

Reviewed by Alex Christensen.

We should not dump status callbacks when test is done.

* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::setStatusText):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (218493 => 218494)


--- trunk/Tools/ChangeLog	2017-06-19 15:50:40 UTC (rev 218493)
+++ trunk/Tools/ChangeLog	2017-06-19 16:34:44 UTC (rev 218494)
@@ -1,3 +1,15 @@
+2017-06-19  Per Arne Vollan  <pvol...@apple.com>
+
+        [Win] fast/dom/assign-to-window-status.html is flaky.
+        https://bugs.webkit.org/show_bug.cgi?id=173512
+
+        Reviewed by Alex Christensen.
+
+        We should not dump status callbacks when test is done.
+
+        * DumpRenderTree/win/UIDelegate.cpp:
+        (UIDelegate::setStatusText):
+
 2017-06-19  Carlos Alberto Lopez Perez  <clo...@igalia.com>
 
         [WPE][JHBuild] Update WPEBackend-mesa

Modified: trunk/Tools/DumpRenderTree/win/UIDelegate.cpp (218493 => 218494)


--- trunk/Tools/DumpRenderTree/win/UIDelegate.cpp	2017-06-19 15:50:40 UTC (rev 218493)
+++ trunk/Tools/DumpRenderTree/win/UIDelegate.cpp	2017-06-19 16:34:44 UTC (rev 218494)
@@ -658,8 +658,8 @@
 }
 
 HRESULT UIDelegate::setStatusText(_In_opt_ IWebView*, _In_ BSTR text)
-{ 
-    if (gTestRunner->dumpStatusCallbacks())
+{
+    if (!done && gTestRunner->dumpStatusCallbacks())
         fprintf(testResult, "UI DELEGATE STATUS CALLBACK: setStatusText:%S\n", text ? text : L"");
     return S_OK;
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to