Title: [218522] trunk/Source/WebKit2
Revision
218522
Author
cdu...@apple.com
Date
2017-06-19 18:23:34 -0700 (Mon, 19 Jun 2017)

Log Message

Unreviewed, partial rollout of r218501 to address crashes on iOS.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::tryAppLink):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (218521 => 218522)


--- trunk/Source/WebKit2/ChangeLog	2017-06-20 01:17:02 UTC (rev 218521)
+++ trunk/Source/WebKit2/ChangeLog	2017-06-20 01:23:34 UTC (rev 218522)
@@ -1,3 +1,10 @@
+2017-06-19  Chris Dumez  <cdu...@apple.com>
+
+        Unreviewed, partial rollout of r218501 to address crashes on iOS.
+
+        * UIProcess/Cocoa/NavigationState.mm:
+        (WebKit::tryAppLink):
+
 2017-06-19  Darin Adler  <da...@apple.com>
 
         [Cocoa] implement URLSession:task:needNewBodyStream: delegate method

Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm (218521 => 218522)


--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm	2017-06-20 01:17:02 UTC (rev 218521)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm	2017-06-20 01:23:34 UTC (rev 218522)
@@ -291,11 +291,13 @@
         return;
     }
 
-    [LSAppLink openWithURL:navigationAction->request().url() completionHandler:BlockPtr<void (BOOL success, NSError *)>::fromCallable([completionHandler = WTFMove(completionHandler)](BOOL success, NSError *) mutable {
-        dispatch_async(dispatch_get_main_queue(), BlockPtr<void ()>::fromCallable([completionHandler = WTFMove(completionHandler), success] {
-            completionHandler(success);
-        }).get());
-    }).get()];
+    auto* localCompletionHandler = new WTF::Function<void (bool)>(WTFMove(completionHandler));
+    [LSAppLink openWithURL:navigationAction->request().url() completionHandler:[localCompletionHandler](BOOL success, NSError *) {
+        dispatch_async(dispatch_get_main_queue(), [localCompletionHandler, success] {
+            (*localCompletionHandler)(success);
+            delete localCompletionHandler;
+        });
+    }];
 #else
     completionHandler(false);
 #endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to