Title: [218546] releases/WebKitGTK/webkit-2.16/LayoutTests
- Revision
- 218546
- Author
- carlo...@webkit.org
- Date
- 2017-06-20 00:04:00 -0700 (Tue, 20 Jun 2017)
Log Message
Merge r217554 - [GTK] Test cases for typehead in form menu lists should start from known state
https://bugs.webkit.org/show_bug.cgi?id=171792
Reviewed by Carlos Garcia Campos.
Since r215188 opening a popup menu in a form pre-selects the active
element to mimic GtkComboxBox behavior, but the layout test implicitly
assumed that type ahead search always started the beginning of the
list, which is no longer true now that GTK+ is informed of which one
is the active element.
* platform/gtk/fast/forms/menulist-typeahead-find.html: Reset menu
list to the initial state (no element selected, unfocused) at the
beginning of testTypeAheadFunction().
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (218545 => 218546)
--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog 2017-06-20 07:03:53 UTC (rev 218545)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog 2017-06-20 07:04:00 UTC (rev 218546)
@@ -1,3 +1,20 @@
+2017-05-30 Adrian Perez de Castro <ape...@igalia.com>
+
+ [GTK] Test cases for typehead in form menu lists should start from known state
+ https://bugs.webkit.org/show_bug.cgi?id=171792
+
+ Reviewed by Carlos Garcia Campos.
+
+ Since r215188 opening a popup menu in a form pre-selects the active
+ element to mimic GtkComboxBox behavior, but the layout test implicitly
+ assumed that type ahead search always started the beginning of the
+ list, which is no longer true now that GTK+ is informed of which one
+ is the active element.
+
+ * platform/gtk/fast/forms/menulist-typeahead-find.html: Reset menu
+ list to the initial state (no element selected, unfocused) at the
+ beginning of testTypeAheadFunction().
+
2017-05-25 Chris Dumez <cdu...@apple.com>
imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/form_owner_and_table_2.html is crashing
Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/fast/forms/menulist-typeahead-find.html (218545 => 218546)
--- releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/fast/forms/menulist-typeahead-find.html 2017-06-20 07:03:53 UTC (rev 218545)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/fast/forms/menulist-typeahead-find.html 2017-06-20 07:04:00 UTC (rev 218546)
@@ -20,6 +20,10 @@
if (!window.eventSender)
return;
+ // Reset menu list to initial state.
+ menulist.selectedIndex = 0;
+ menulist.blur();
+
eventSender.mouseMoveTo(menulist.offsetLeft + (menulist.offsetWidth / 2), menulist.offsetTop + (menulist.offsetHeight / 2));
eventSender.mouseDown();
eventSender.mouseUp();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
