Title: [218576] releases/WebKitGTK/webkit-2.16/Source/WebCore
- Revision
- 218576
- Author
- carlo...@webkit.org
- Date
- 2017-06-20 02:11:07 -0700 (Tue, 20 Jun 2017)
Log Message
Merge r218190 - Protect lifetime of media element during HTMLMediaElement::notifyAboutPlaying()
https://bugs.webkit.org/show_bug.cgi?id=173320
<rdar://problem/32590276>
Reviewed by Brent Fulgham.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::notifyAboutPlaying):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (218575 => 218576)
--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-06-20 09:10:14 UTC (rev 218575)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-06-20 09:11:07 UTC (rev 218576)
@@ -1,3 +1,14 @@
+2017-06-13 Jer Noble <jer.no...@apple.com>
+
+ Protect lifetime of media element during HTMLMediaElement::notifyAboutPlaying()
+ https://bugs.webkit.org/show_bug.cgi?id=173320
+ <rdar://problem/32590276>
+
+ Reviewed by Brent Fulgham.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::notifyAboutPlaying):
+
2017-06-09 Brady Eidson <beid...@apple.com>
Crash when IndexedDB's getAll is used inside a Web Worker.
Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/html/HTMLMediaElement.cpp (218575 => 218576)
--- releases/WebKitGTK/webkit-2.16/Source/WebCore/html/HTMLMediaElement.cpp 2017-06-20 09:10:14 UTC (rev 218575)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/html/HTMLMediaElement.cpp 2017-06-20 09:11:07 UTC (rev 218576)
@@ -1011,6 +1011,7 @@
void HTMLMediaElement::notifyAboutPlaying()
{
+ Ref<HTMLMediaElement> protectedThis(*this); // The 'playing' event can make arbitrary DOM mutations.
m_playbackStartedTime = currentMediaTime().toDouble();
dispatchEvent(Event::create(eventNames().playingEvent, false, true));
resolvePendingPlayPromises();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
