Title: [224667] trunk/Source/WebDriver
- Revision
- 224667
- Author
- carlo...@webkit.org
- Date
- 2017-11-09 23:25:59 -0800 (Thu, 09 Nov 2017)
Log Message
WebDriver: capabilities with null value shouldn't be added to the validated capabilities object
https://bugs.webkit.org/show_bug.cgi?id=179369
Reviewed by Brian Burg.
"4. If deserialized is not null, set a property on result with name name and value deserialized."
7.2 Processing Capabilities
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities
Fixes: imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py::test_valid[platformName-None]
* WebDriverService.cpp:
(WebDriver::WebDriverService::validatedCapabilities const):
Modified Paths
Diff
Modified: trunk/Source/WebDriver/ChangeLog (224666 => 224667)
--- trunk/Source/WebDriver/ChangeLog 2017-11-10 07:21:44 UTC (rev 224666)
+++ trunk/Source/WebDriver/ChangeLog 2017-11-10 07:25:59 UTC (rev 224667)
@@ -1,3 +1,20 @@
+2017-11-09 Carlos Garcia Campos <cgar...@igalia.com>
+
+ WebDriver: capabilities with null value shouldn't be added to the validated capabilities object
+ https://bugs.webkit.org/show_bug.cgi?id=179369
+
+ Reviewed by Brian Burg.
+
+ "4. If deserialized is not null, set a property on result with name name and value deserialized."
+
+ 7.2 Processing Capabilities
+ https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities
+
+ Fixes: imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py::test_valid[platformName-None]
+
+ * WebDriverService.cpp:
+ (WebDriver::WebDriverService::validatedCapabilities const):
+
2017-10-27 Carlos Garcia Campos <cgar...@igalia.com>
WebDriver: unknown capabilities should produce an InvalidArgument error when validating capabilities
Modified: trunk/Source/WebDriver/WebDriverService.cpp (224666 => 224667)
--- trunk/Source/WebDriver/WebDriverService.cpp 2017-11-10 07:21:44 UTC (rev 224666)
+++ trunk/Source/WebDriver/WebDriverService.cpp 2017-11-10 07:25:59 UTC (rev 224667)
@@ -372,8 +372,8 @@
auto end = capabilities.end();
for (auto it = capabilities.begin(); it != end; ++it) {
if (it->value->isNull())
- result->setValue(it->key, RefPtr<InspectorValue>(it->value));
- else if (it->key == "acceptInsecureCerts") {
+ continue;
+ if (it->key == "acceptInsecureCerts") {
bool acceptInsecureCerts;
if (!it->value->asBoolean(acceptInsecureCerts))
return nullptr;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
