Title: [224708] trunk/Tools
- Revision
- 224708
- Author
- wenson_hs...@apple.com
- Date
- 2017-11-10 15:13:19 -0800 (Fri, 10 Nov 2017)
Log Message
Finish rolling out r224544
Rubber-stamped by Tim Horton.
Now that https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again allow one of the API
tests added in r224512 (WKAttachmentTests.AttachmentUpdatesWhenChangingFontStyles) to test toggling underline
style with a selected attachment element.
* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (224707 => 224708)
--- trunk/Tools/ChangeLog 2017-11-10 23:02:14 UTC (rev 224707)
+++ trunk/Tools/ChangeLog 2017-11-10 23:13:19 UTC (rev 224708)
@@ -1,3 +1,16 @@
+2017-11-10 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Finish rolling out r224544
+
+ Rubber-stamped by Tim Horton.
+
+ Now that https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again allow one of the API
+ tests added in r224512 (WKAttachmentTests.AttachmentUpdatesWhenChangingFontStyles) to test toggling underline
+ style with a selected attachment element.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+ (TestWebKitAPI::TEST):
+
2017-11-10 Alex Christensen <achristen...@webkit.org>
_WKThumbnailView initialization with WKWebView needs to call correct initWithFrame
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm (224707 => 224708)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm 2017-11-10 23:02:14 UTC (rev 224707)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm 2017-11-10 23:13:19 UTC (rev 224708)
@@ -251,7 +251,7 @@
[webView _synchronouslyExecuteEditCommand:@"SelectAll" argument:nil];
[webView expectUpdatesAfterCommand:@"ToggleBold" withArgument:nil expectedRemovals:@[] expectedInsertions:@[]];
[webView expectUpdatesAfterCommand:@"ToggleItalic" withArgument:nil expectedRemovals:@[] expectedInsertions:@[]];
- // FIXME: Additionally test underlining after <https://bugs.webkit.org/show_bug.cgi?id=179431> is addressed.
+ [webView expectUpdatesAfterCommand:@"ToggleUnderline" withArgument:nil expectedRemovals:@[] expectedInsertions:@[]];
// Inserting text should delete the current selection, removing the attachment in the process.
[webView expectUpdatesAfterCommand:@"InsertText" withArgument:@"foo" expectedRemovals:@[attachment.get()] expectedInsertions:@[]];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
