Title: [228389] trunk/Source/WebCore
Revision
228389
Author
ryanhad...@apple.com
Date
2018-02-12 12:30:51 -0800 (Mon, 12 Feb 2018)

Log Message

[iOS] media tests failing ASSERT_NOT_REACHED() in WebCore::VideoFullscreenInterfaceAVKit::cleanupFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=182527

Reviewed by Alexey Proskuryakov.

Temporarily remove an assertion from VideoFullscreenInterfaceAVKit to stop tests from crashing on iOS
while the root cause is being investigated.

* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::exitFullscreenHandler):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (228388 => 228389)


--- trunk/Source/WebCore/ChangeLog	2018-02-12 20:28:02 UTC (rev 228388)
+++ trunk/Source/WebCore/ChangeLog	2018-02-12 20:30:51 UTC (rev 228389)
@@ -1,3 +1,16 @@
+2018-02-12  Ryan Haddad  <ryanhad...@apple.com>
+
+        [iOS] media tests failing ASSERT_NOT_REACHED() in WebCore::VideoFullscreenInterfaceAVKit::cleanupFullscreen()
+        https://bugs.webkit.org/show_bug.cgi?id=182527
+
+        Reviewed by Alexey Proskuryakov.
+
+        Temporarily remove an assertion from VideoFullscreenInterfaceAVKit to stop tests from crashing on iOS
+        while the root cause is being investigated.
+
+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+        (VideoFullscreenInterfaceAVKit::exitFullscreenHandler):
+
 2018-02-12  Zalan Bujtas  <za...@apple.com>
 
         [RenderTreeBuilder] Remove redundant RenderTreeBuilder instance

Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (228388 => 228389)


--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm	2018-02-12 20:28:02 UTC (rev 228388)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm	2018-02-12 20:30:51 UTC (rev 228389)
@@ -1556,7 +1556,6 @@
 {
     if (!success) {
         WTFLogAlways("-[AVPlayerViewController exitFullScreenAnimated:completionHandler:] failed with error %s", [[error localizedDescription] UTF8String]);
-        ASSERT_NOT_REACHED();
     }
 
     UNUSED_PARAM(success);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to