Title: [228731] trunk/Tools
- Revision
- 228731
- Author
- commit-qu...@webkit.org
- Date
- 2018-02-19 23:08:00 -0800 (Mon, 19 Feb 2018)
Log Message
[WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=182953
Patch by Fujii Hironori <hironori.fu...@sony.com> on 2018-02-19
Reviewed by Carlos Garcia Campos.
* Scripts/webkitpy/port/gtk.py:
(GtkPort._get_crash_log): Removed the code to convert WebProcess name.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
(WTR::TestController::networkProcessName): Ditto.
(WTR::TestController::databaseProcessName): Ditto.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (228730 => 228731)
--- trunk/Tools/ChangeLog 2018-02-20 06:57:19 UTC (rev 228730)
+++ trunk/Tools/ChangeLog 2018-02-20 07:08:00 UTC (rev 228731)
@@ -1,3 +1,17 @@
+2018-02-19 Fujii Hironori <hironori.fu...@sony.com>
+
+ [WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
+ https://bugs.webkit.org/show_bug.cgi?id=182953
+
+ Reviewed by Carlos Garcia Campos.
+
+ * Scripts/webkitpy/port/gtk.py:
+ (GtkPort._get_crash_log): Removed the code to convert WebProcess name.
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
+ (WTR::TestController::networkProcessName): Ditto.
+ (WTR::TestController::databaseProcessName): Ditto.
+
2018-02-19 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r228696.
Modified: trunk/Tools/Scripts/webkitpy/port/gtk.py (228730 => 228731)
--- trunk/Tools/Scripts/webkitpy/port/gtk.py 2018-02-20 06:57:19 UTC (rev 228730)
+++ trunk/Tools/Scripts/webkitpy/port/gtk.py 2018-02-20 07:08:00 UTC (rev 228731)
@@ -223,7 +223,6 @@
return super(GtkPort, self).check_sys_deps(needs_http) and self._driver_class().check_driver(self)
def _get_crash_log(self, name, pid, stdout, stderr, newer_than, target_host=None):
- name = "WebKitWebProcess" if name == "WebProcess" else name
return GDBCrashLogGenerator(name, pid, newer_than, self._filesystem, self._path_to_driver).generate_crash_log(stdout, stderr)
def test_expectations_file_position(self):
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (228730 => 228731)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2018-02-20 06:57:19 UTC (rev 228730)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2018-02-20 07:08:00 UTC (rev 228731)
@@ -891,6 +891,8 @@
return "com.apple.WebKit.WebContent";
#elif PLATFORM(COCOA)
return "com.apple.WebKit.WebContent.Development";
+#elif PLATFORM(GTK)
+ return "WebKitWebProcess";
#else
return "WebProcess";
#endif
@@ -903,6 +905,8 @@
return "com.apple.WebKit.Networking";
#elif PLATFORM(COCOA)
return "com.apple.WebKit.Networking.Development";
+#elif PLATFORM(GTK)
+ return "WebKitNetworkProcess";
#else
return "NetworkProcess";
#endif
@@ -919,6 +923,8 @@
#endif
#elif PLATFORM(COCOA)
return "com.apple.WebKit.Storage.Development";
+#elif PLATFORM(GTK)
+ return "WebKitStorageProcess";
#else
return "DatabaseProcess";
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
