Title: [229314] trunk
Revision
229314
Author
commit-qu...@webkit.org
Date
2018-03-06 03:31:50 -0800 (Tue, 06 Mar 2018)

Log Message

[ARM] Disable tests that run out of memory
https://bugs.webkit.org/show_bug.cgi?id=182699

Patch by Dominik Infuehr <dinfu...@igalia.com> on 2018-03-06
Reviewed by Žan Doberšek.

JSTests:

Skip tests that run of of memory. Do not run
modules/module-jit-reachability.js without LLInt to prevent
running out of executable memory.

* modules.yaml:
* modules/module-jit-reachability.js:
* stress/has-own-property-name-cache-string-keys.js:
* stress/has-own-property-name-cache-symbol-keys.js:

Tools:

Add run mode to allow running modules.yaml-tests without
disabling LLInt for specific tests.

* Scripts/run-jsc-stress-tests:

LayoutTests:

Do not run test with LLInt disabled on Linux.

* js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (229313 => 229314)


--- trunk/JSTests/ChangeLog	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/JSTests/ChangeLog	2018-03-06 11:31:50 UTC (rev 229314)
@@ -1,3 +1,19 @@
+2018-03-06  Dominik Infuehr  <dinfu...@igalia.com>
+
+        [ARM] Disable tests that run out of memory
+        https://bugs.webkit.org/show_bug.cgi?id=182699
+
+        Reviewed by Žan Doberšek.
+
+        Skip tests that run of of memory. Do not run
+        modules/module-jit-reachability.js without LLInt to prevent
+        running out of executable memory.
+
+        * modules.yaml:
+        * modules/module-jit-reachability.js:
+        * stress/has-own-property-name-cache-string-keys.js:
+        * stress/has-own-property-name-cache-symbol-keys.js:
+
 2018-03-01  Yusuke Suzuki  <utatane....@gmail.com>
 
         ASSERTION FAILED: matchContextualKeyword(m_vm->propertyNames->async)

Modified: trunk/JSTests/modules/module-jit-reachability.js (229313 => 229314)


--- trunk/JSTests/modules/module-jit-reachability.js	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/JSTests/modules/module-jit-reachability.js	2018-03-06 11:31:50 UTC (rev 229314)
@@ -1,3 +1,5 @@
+//@ noNoLLIntRunModules if $architecture == "arm"
+
 var points = [
   { x: 0, y: 0 },
   { x: 1, y: 1 },

Modified: trunk/JSTests/modules.yaml (229313 => 229314)


--- trunk/JSTests/modules.yaml	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/JSTests/modules.yaml	2018-03-06 11:31:50 UTC (rev 229314)
@@ -22,4 +22,4 @@
 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 - path: modules
-  cmd: runModules
+  cmd: defaultRunModules unless parseRunCommands

Modified: trunk/JSTests/stress/has-own-property-name-cache-string-keys.js (229313 => 229314)


--- trunk/JSTests/stress/has-own-property-name-cache-string-keys.js	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/JSTests/stress/has-own-property-name-cache-string-keys.js	2018-03-06 11:31:50 UTC (rev 229314)
@@ -1,3 +1,5 @@
+//@ skip if $memoryLimited
+
 function assert(b) {
     if (!b)
         throw new Error("Bad assertion.");

Modified: trunk/JSTests/stress/has-own-property-name-cache-symbol-keys.js (229313 => 229314)


--- trunk/JSTests/stress/has-own-property-name-cache-symbol-keys.js	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/JSTests/stress/has-own-property-name-cache-symbol-keys.js	2018-03-06 11:31:50 UTC (rev 229314)
@@ -1,3 +1,5 @@
+//@ skip if $memoryLimited
+
 function assert(b) {
     if (!b)
         throw new Error("Bad assertion.");

Modified: trunk/LayoutTests/ChangeLog (229313 => 229314)


--- trunk/LayoutTests/ChangeLog	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/LayoutTests/ChangeLog	2018-03-06 11:31:50 UTC (rev 229314)
@@ -1,3 +1,14 @@
+2018-03-06  Dominik Infuehr  <dinfu...@igalia.com>
+
+        [ARM] Disable tests that run out of memory
+        https://bugs.webkit.org/show_bug.cgi?id=182699
+
+        Reviewed by Žan Doberšek.
+
+        Do not run test with LLInt disabled on Linux.
+
+        * js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:
+
 2018-03-06  Nan Wang  <n_w...@apple.com>
 
         AX: AOM: More accessibility events support

Modified: trunk/LayoutTests/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js (229313 => 229314)


--- trunk/LayoutTests/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/LayoutTests/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js	2018-03-06 11:31:50 UTC (rev 229314)
@@ -1,4 +1,4 @@
-//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
+//@ noNoLLIntRunLayoutTest if $architecture == "arm"
 
 description(
 "Tests that performing an OSR entry into a loop with a hoisted structure check, where the loop may clobber the world, works."

Modified: trunk/Tools/ChangeLog (229313 => 229314)


--- trunk/Tools/ChangeLog	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/Tools/ChangeLog	2018-03-06 11:31:50 UTC (rev 229314)
@@ -1,3 +1,15 @@
+2018-03-06  Dominik Infuehr  <dinfu...@igalia.com>
+
+        [ARM] Disable tests that run out of memory
+        https://bugs.webkit.org/show_bug.cgi?id=182699
+
+        Reviewed by Žan Doberšek.
+
+        Add run mode to allow running modules.yaml-tests without
+        disabling LLInt for specific tests.
+
+        * Scripts/run-jsc-stress-tests:
+
 2018-03-05  Yusuke Suzuki  <utatane....@gmail.com>
 
         Fix std::make_unique / new[] using system malloc

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (229313 => 229314)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2018-03-06 11:23:08 UTC (rev 229313)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2018-03-06 11:31:50 UTC (rev 229314)
@@ -972,7 +972,7 @@
     addRunCommand("default", args, noisyOutputHandler, errorHandler)
 end
 
-def runModules
+def defaultRunModules(noLLInt: true)
     run("default-modules", "-m")
 
     if !$jitTests
@@ -979,7 +979,7 @@
         return
     end
 
-    run("no-llint-modules", "-m", "--useLLInt=false")
+    run("no-llint-modules", "-m", "--useLLInt=false") if noLLInt
     run("no-cjit-validate-phases-modules", "-m", "--validateBytecode=true", "--validateGraphAtEachPhase=true", *NO_CJIT_OPTIONS)
     run("dfg-eager-modules", "-m", *EAGER_OPTIONS)
     run("dfg-eager-no-cjit-validate-modules", "-m", "--validateGraph=true", *(NO_CJIT_OPTIONS + EAGER_OPTIONS))
@@ -994,6 +994,10 @@
     run("ftl-no-cjit-small-pool-modules", "-m", "--jitMemoryReservationSize=50000", *(FTL_OPTIONS + NO_CJIT_OPTIONS))
 end
 
+def noNoLLIntRunModules
+    defaultRunModules(noLLInt: false)
+end
+
 def runWebAssembly
     return if !$jitTests
     return if !$isFTLPlatform
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to