Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (230096 => 230097)
--- trunk/Source/_javascript_Core/ChangeLog 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,3 +1,17 @@
+2018-03-29 JF Bastien <jfbast...@apple.com>
+
+ Use Forward.h instead of forward-declaring WTF::String
+ https://bugs.webkit.org/show_bug.cgi?id=184172
+ <rdar://problem/39026146>
+
+ Reviewed by Yusuke Suzuki.
+
+ As part of #184164 I'm changing WTF::String, and the forward
+ declarations are just wrong because I'm making it templated. We
+ should use Forward.h anyways, so do that instead.
+
+ * runtime/DateConversion.h:
+
2018-03-29 Mark Lam <mark....@apple.com>
Use MacroAssemblerCodePtr in Wasm code for code pointers instead of void*.
Modified: trunk/Source/_javascript_Core/runtime/DateConversion.h (230096 => 230097)
--- trunk/Source/_javascript_Core/runtime/DateConversion.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/_javascript_Core/runtime/DateConversion.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -24,12 +24,9 @@
#pragma once
+#include <wtf/Forward.h>
#include <wtf/GregorianDateTime.h>
-namespace WTF {
-class String;
-} // namespace WTF
-
namespace JSC {
enum DateTimeFormat {
Modified: trunk/Source/WTF/ChangeLog (230096 => 230097)
--- trunk/Source/WTF/ChangeLog 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WTF/ChangeLog 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,3 +1,19 @@
+2018-03-29 JF Bastien <jfbast...@apple.com>
+
+ Use Forward.h instead of forward-declaring WTF::String
+ https://bugs.webkit.org/show_bug.cgi?id=184172
+ <rdar://problem/39026146>
+
+ Reviewed by Yusuke Suzuki.
+
+ As part of #184164 I'm changing WTF::String, and the forward
+ declarations are just wrong because I'm making it templated. We
+ should use Forward.h anyways, so do that instead.
+
+ * wtf/Forward.h:
+ * wtf/HashTraits.h:
+ * wtf/PrintStream.h:
+
2018-03-29 Yusuke Suzuki <utatane....@gmail.com>
Remove WTF_EXPORTDATA and JS_EXPORTDATA
Modified: trunk/Source/WTF/wtf/Forward.h (230096 => 230097)
--- trunk/Source/WTF/wtf/Forward.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WTF/wtf/Forward.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -46,6 +46,7 @@
class StringView;
class TextPosition;
class TextStream;
+class UniquedStringImpl;
class WallTime;
struct FastMalloc;
Modified: trunk/Source/WTF/wtf/HashTraits.h (230096 => 230097)
--- trunk/Source/WTF/wtf/HashTraits.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WTF/wtf/HashTraits.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2005-2018 Apple Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -23,6 +23,7 @@
#include <limits>
#include <utility>
+#include <wtf/Forward.h>
#include <wtf/HashFunctions.h>
#include <wtf/KeyValuePair.h>
#include <wtf/Optional.h>
@@ -30,10 +31,6 @@
namespace WTF {
-class String;
-
-template<typename T> struct HashTraits;
-
template<bool isInteger, typename T> struct GenericHashTraitsBase;
template<typename T> struct GenericHashTraitsBase<false, T> {
Modified: trunk/Source/WTF/wtf/PrintStream.h (230096 => 230097)
--- trunk/Source/WTF/wtf/PrintStream.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WTF/wtf/PrintStream.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012, 2014-2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -29,6 +29,7 @@
#include <memory>
#include <stdarg.h>
#include <tuple>
+#include <wtf/Forward.h>
#include <wtf/FastMalloc.h>
#include <wtf/Noncopyable.h>
#include <wtf/Optional.h>
@@ -38,13 +39,6 @@
namespace WTF {
-class AtomicStringImpl;
-class CString;
-class String;
-class StringImpl;
-class StringView;
-class UniquedStringImpl;
-
inline const char* boolForPrinting(bool value)
{
return value ? "true" : "false";
Modified: trunk/Source/WebCore/ChangeLog (230096 => 230097)
--- trunk/Source/WebCore/ChangeLog 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebCore/ChangeLog 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,3 +1,23 @@
+2018-03-29 JF Bastien <jfbast...@apple.com>
+
+ Use Forward.h instead of forward-declaring WTF::String
+ https://bugs.webkit.org/show_bug.cgi?id=184172
+ <rdar://problem/39026146>
+
+ Reviewed by Yusuke Suzuki.
+
+ As part of #184164 I'm changing WTF::String, and the forward
+ declarations are just wrong because I'm making it templated. We
+ should use Forward.h anyways, so do that instead.
+
+ * css/makeprop.pl:
+ * platform/cocoa/PlaybackSessionInterface.h:
+ * platform/ios/Device.h:
+ * platform/ios/PlaybackSessionInterfaceAVKit.h:
+ * platform/ios/VideoFullscreenInterfaceAVKit.h:
+ * platform/win/PathWalker.h:
+ * testing/js/WebCoreTestSupport.h:
+
2018-03-29 Ross Kirsling <ross.kirsl...@sony.com>
MSVC __forceinline slows down JSC release build fivefold after r229391
Modified: trunk/Source/WebCore/css/makeprop.pl (230096 => 230097)
--- trunk/Source/WebCore/css/makeprop.pl 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebCore/css/makeprop.pl 2018-03-30 05:05:15 UTC (rev 230097)
@@ -3,7 +3,7 @@
# This file is part of the WebKit project
#
# Copyright (C) 1999 Waldo Bastian (bast...@kde.org)
-# Copyright (C) 2007-2017 Apple Inc. All rights reserved.
+# Copyright (C) 2007-2018 Apple Inc. All rights reserved.
# Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
# Copyright (C) 2010 Andras Becsi (abe...@inf.u-szeged.hu), University of Szeged
# Copyright (C) 2013 Google Inc. All rights reserved.
@@ -415,14 +415,10 @@
#pragma once
#include <string.h>
+#include <wtf/Forward.h>
#include <wtf/HashFunctions.h>
#include <wtf/HashTraits.h>
-namespace WTF {
-class AtomicString;
-class String;
-}
-
namespace WebCore {
enum CSSPropertyID : uint16_t {
Modified: trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h (230096 => 230097)
--- trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebCore/platform/cocoa/PlaybackSessionInterface.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -27,12 +27,9 @@
#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#include <wtf/Forward.h>
#include <wtf/Vector.h>
-namespace WTF {
-class String;
-}
-
namespace WebCore {
class TimeRanges;
Modified: trunk/Source/WebCore/platform/ios/Device.h (230096 => 230097)
--- trunk/Source/WebCore/platform/ios/Device.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebCore/platform/ios/Device.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -28,12 +28,9 @@
#if PLATFORM(IOS)
+#include <wtf/Forward.h>
#include <pal/spi/ios/MobileGestaltSPI.h>
-namespace WTF {
-class String;
-}
-
namespace WebCore {
WEBCORE_EXPORT MGDeviceClass deviceClass();
Modified: trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h (230096 => 230097)
--- trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -35,6 +35,7 @@
#include "Timer.h"
#include <functional>
#include <objc/objc.h>
+#include <wtf/Forward.h>
#include <wtf/RefCounted.h>
#include <wtf/RefPtr.h>
#include <wtf/RetainPtr.h>
@@ -45,10 +46,6 @@
OBJC_CLASS UIWindow;
OBJC_CLASS UIView;
-namespace WTF {
-class String;
-}
-
namespace WebCore {
class IntRect;
class PlaybackSessionModel;
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h (230096 => 230097)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -34,6 +34,7 @@
#include "PlaybackSessionInterfaceAVKit.h"
#include "VideoFullscreenModel.h"
#include <objc/objc.h>
+#include <wtf/Forward.h>
#include <wtf/Function.h>
#include <wtf/RefCounted.h>
#include <wtf/RefPtr.h>
@@ -51,10 +52,6 @@
OBJC_CLASS WebAVPlayerViewControllerDelegate;
OBJC_CLASS NSError;
-namespace WTF {
-class String;
-}
-
namespace WebCore {
class IntRect;
class FloatSize;
Modified: trunk/Source/WebCore/platform/win/PathWalker.h (230096 => 230097)
--- trunk/Source/WebCore/platform/win/PathWalker.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebCore/platform/win/PathWalker.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2011-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -24,12 +24,9 @@
*/
#include <Windows.h>
+#include <wtf/Forward.h>
#include <wtf/Noncopyable.h>
-namespace WTF {
- class String;
-}
-
namespace WebCore {
class PathWalker {
Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.h (230096 => 230097)
--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,6 +1,6 @@
/*
* Copyright (C) 2011, 2015 Google Inc. All rights reserved.
- * Copyright (C) 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -26,6 +26,8 @@
#pragma once
+#include <wtf/Forward.h>
+
typedef const struct OpaqueJSContext* JSContextRef;
typedef struct OpaqueJSString* JSStringRef;
typedef struct OpaqueJSValue* JSObjectRef;
@@ -36,10 +38,6 @@
#define TEST_SUPPORT_EXPORT
#endif
-namespace WTF {
-class String;
-}
-
namespace WebCore {
class Frame;
}
Modified: trunk/Source/WebKit/ChangeLog (230096 => 230097)
--- trunk/Source/WebKit/ChangeLog 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebKit/ChangeLog 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,3 +1,20 @@
+2018-03-29 JF Bastien <jfbast...@apple.com>
+
+ Use Forward.h instead of forward-declaring WTF::String
+ https://bugs.webkit.org/show_bug.cgi?id=184172
+ <rdar://problem/39026146>
+
+ Reviewed by Yusuke Suzuki.
+
+ As part of #184164 I'm changing WTF::String, and the forward
+ declarations are just wrong because I'm making it templated. We
+ should use Forward.h anyways, so do that instead.
+
+ * Scripts/webkit/LegacyMessages-expected.h:
+ * Scripts/webkit/Messages-expected.h:
+ * Scripts/webkit/MessagesSuperclass-expected.h:
+ * UIProcess/WebOpenPanelResultListenerProxy.h:
+
2018-03-29 Brian Burg <bb...@apple.com>
Web Automation: clipToViewport is ignored for element screenshots
Modified: trunk/Source/WebKit/Scripts/webkit/LegacyMessages-expected.h (230096 => 230097)
--- trunk/Source/WebKit/Scripts/webkit/LegacyMessages-expected.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebKit/Scripts/webkit/LegacyMessages-expected.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -33,6 +33,7 @@
#include <WebCore/KeyboardEvent.h>
#include <WebCore/PluginData.h>
#include <utility>
+#include <wtf/Forward.h>
#include <wtf/HashMap.h>
#include <wtf/ThreadSafeRefCounted.h>
#include <wtf/Vector.h>
@@ -44,10 +45,6 @@
class DummyType;
}
-namespace WTF {
- class String;
-}
-
namespace WebKit {
class WebTouchEvent;
class WebPreferencesStore;
Modified: trunk/Source/WebKit/Scripts/webkit/Messages-expected.h (230096 => 230097)
--- trunk/Source/WebKit/Scripts/webkit/Messages-expected.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebKit/Scripts/webkit/Messages-expected.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -33,6 +33,7 @@
#include <WebCore/KeyboardEvent.h>
#include <WebCore/PluginData.h>
#include <utility>
+#include <wtf/Forward.h>
#include <wtf/HashMap.h>
#include <wtf/ThreadSafeRefCounted.h>
#include <wtf/Vector.h>
@@ -44,10 +45,6 @@
class DummyType;
}
-namespace WTF {
- class String;
-}
-
namespace WebKit {
class WebTouchEvent;
class WebPreferencesStore;
Modified: trunk/Source/WebKit/Scripts/webkit/MessagesSuperclass-expected.h (230096 => 230097)
--- trunk/Source/WebKit/Scripts/webkit/MessagesSuperclass-expected.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebKit/Scripts/webkit/MessagesSuperclass-expected.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -25,11 +25,8 @@
#pragma once
#include "ArgumentCoders.h"
+#include <wtf/Forward.h>
-namespace WTF {
- class String;
-}
-
namespace Messages {
namespace WebPage {
Modified: trunk/Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.h (230096 => 230097)
--- trunk/Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -32,7 +32,6 @@
namespace API {
class Array;
class Data;
-class String;
}
namespace WebKit {
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (230096 => 230097)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,3 +1,17 @@
+2018-03-29 JF Bastien <jfbast...@apple.com>
+
+ Use Forward.h instead of forward-declaring WTF::String
+ https://bugs.webkit.org/show_bug.cgi?id=184172
+ <rdar://problem/39026146>
+
+ Reviewed by Yusuke Suzuki.
+
+ As part of #184164 I'm changing WTF::String, and the forward
+ declarations are just wrong because I'm making it templated. We
+ should use Forward.h anyways, so do that instead.
+
+ * WebView/WebScriptDebugger.h:
+
2018-03-28 Brent Fulgham <bfulg...@apple.com>
Protect against invalid mach ports returned by mach_port_request_notification
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebScriptDebugger.h (230096 => 230097)
--- trunk/Source/WebKitLegacy/mac/WebView/WebScriptDebugger.h 2018-03-30 05:04:44 UTC (rev 230096)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebScriptDebugger.h 2018-03-30 05:05:15 UTC (rev 230097)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2008-2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -32,12 +32,9 @@
#include <_javascript_Core/Debugger.h>
#include <_javascript_Core/Strong.h>
+#include <wtf/Forward.h>
#include <wtf/RetainPtr.h>
-namespace WTF {
-class String;
-}
-
namespace JSC {
class DebuggerCallFrame;
class ExecState;
