Title: [231399] trunk/Source/_javascript_Core
- Revision
- 231399
- Author
- fpi...@apple.com
- Date
- 2018-05-05 18:06:09 -0700 (Sat, 05 May 2018)
Log Message
DFG CFA phase should only do clobber asserts in debug
https://bugs.webkit.org/show_bug.cgi?id=185354
Reviewed by Saam Barati.
Clobber asserts are responsible for 1% of compile time. That's too much. This disables them
unless asserts are enabled.
* dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (231398 => 231399)
--- trunk/Source/_javascript_Core/ChangeLog 2018-05-05 23:45:15 UTC (rev 231398)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-05-06 01:06:09 UTC (rev 231399)
@@ -1,3 +1,16 @@
+2018-05-05 Filip Pizlo <fpi...@apple.com>
+
+ DFG CFA phase should only do clobber asserts in debug
+ https://bugs.webkit.org/show_bug.cgi?id=185354
+
+ Reviewed by Saam Barati.
+
+ Clobber asserts are responsible for 1% of compile time. That's too much. This disables them
+ unless asserts are enabled.
+
+ * dfg/DFGCFAPhase.cpp:
+ (JSC::DFG::CFAPhase::performBlockCFA):
+
2018-05-04 Keith Miller <keith_mil...@apple.com>
isCacheableArrayLength should return true for undecided arrays
Modified: trunk/Source/_javascript_Core/dfg/DFGCFAPhase.cpp (231398 => 231399)
--- trunk/Source/_javascript_Core/dfg/DFGCFAPhase.cpp 2018-05-05 23:45:15 UTC (rev 231398)
+++ trunk/Source/_javascript_Core/dfg/DFGCFAPhase.cpp 2018-05-06 01:06:09 UTC (rev 231399)
@@ -181,7 +181,8 @@
break;
}
- if (m_state.didClobberOrFolded() != writesOverlap(m_graph, node, JSCell_structureID))
+ if (!ASSERT_DISABLED
+ && m_state.didClobberOrFolded() != writesOverlap(m_graph, node, JSCell_structureID))
DFG_CRASH(m_graph, node, toCString("AI-clobberize disagreement; AI says ", m_state.clobberState(), " while clobberize says ", writeSet(m_graph, node)).data());
}
if (m_verbose) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
