Title: [231863] trunk/Source/WebKit
Revision
231863
Author
aes...@apple.com
Date
2018-05-16 12:39:30 -0700 (Wed, 16 May 2018)

Log Message

[Wi-Fi Assertions] Adopt WiFiAssertionHolderAdditions
https://bugs.webkit.org/show_bug.cgi?id=185685
<rdar://problem/40136681>

Reviewed by Sam Weinig.

* NetworkProcess/cocoa/WiFiAssertionHolder.cpp:
(WebKit::WiFiAssertionHolder::WiFiAssertionHolder):
(WebKit::WiFiAssertionHolder::~WiFiAssertionHolder):
(WebKit::ensureWiFiManagerClient): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (231862 => 231863)


--- trunk/Source/WebKit/ChangeLog	2018-05-16 19:34:19 UTC (rev 231862)
+++ trunk/Source/WebKit/ChangeLog	2018-05-16 19:39:30 UTC (rev 231863)
@@ -1,3 +1,16 @@
+2018-05-16  Andy Estes  <aes...@apple.com>
+
+        [Wi-Fi Assertions] Adopt WiFiAssertionHolderAdditions
+        https://bugs.webkit.org/show_bug.cgi?id=185685
+        <rdar://problem/40136681>
+
+        Reviewed by Sam Weinig.
+
+        * NetworkProcess/cocoa/WiFiAssertionHolder.cpp:
+        (WebKit::WiFiAssertionHolder::WiFiAssertionHolder):
+        (WebKit::WiFiAssertionHolder::~WiFiAssertionHolder):
+        (WebKit::ensureWiFiManagerClient): Deleted.
+
 2018-05-16  Fujii Hironori  <hironori.fu...@sony.com>
 
         [Win] Implement WebPage::handleEditingKeyboardEvent

Modified: trunk/Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp (231862 => 231863)


--- trunk/Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp	2018-05-16 19:34:19 UTC (rev 231862)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp	2018-05-16 19:39:30 UTC (rev 231863)
@@ -28,36 +28,28 @@
 
 #if HAVE(MOBILE_WIFI)
 
-#include "Logging.h"
-#include "MobileWiFiSPI.h"
+#if USE(APPLE_INTERNAL_SDK)
+#include <WebKitAdditions/WiFiAssertionHolderAdditions.cpp>
+#else
+static void holdWiFiAssertion()
+{
+}
 
-namespace WebKit {
-
-static WiFiManagerClientRef ensureWiFiManagerClient()
+static void releaseWiFiAssertion()
 {
-    static WiFiManagerClientRef wiFiManagerClient = WiFiManagerClientCreate(kCFAllocatorDefault, kWiFiClientTypeNormal);
-    return wiFiManagerClient;
 }
+#endif
 
-static uint64_t wiFiAssertionCount;
+namespace WebKit {
 
 WiFiAssertionHolder::WiFiAssertionHolder()
 {
-    if (wiFiAssertionCount++)
-        return;
-
-    RELEASE_LOG(WiFiAssertions, "Acquiring Wi-Fi assertion.");
-    WiFiManagerClientSetType(ensureWiFiManagerClient(), kWiFiClientTypeBackground);
+    holdWiFiAssertion();
 }
 
 WiFiAssertionHolder::~WiFiAssertionHolder()
 {
-    ASSERT(wiFiAssertionCount);
-    if (--wiFiAssertionCount)
-        return;
-
-    RELEASE_LOG(WiFiAssertions, "Releasing Wi-Fi assertion.");
-    WiFiManagerClientSetType(ensureWiFiManagerClient(), kWiFiClientTypeNormal);
+    releaseWiFiAssertion();
 }
 
 } // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to