Title: [231865] trunk/LayoutTests
Revision
231865
Author
you...@apple.com
Date
2018-05-16 13:24:32 -0700 (Wed, 16 May 2018)

Log Message

Layout Test webrtc/addICECandidate-closed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=185384
<rdar://problem/40035167>

Reviewed by Eric Carlson.

* webrtc/addICECandidate-closed.html:
Handle sometimes rejected promise to remove a line
in the -expected.txt file that is sometimes added.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (231864 => 231865)


--- trunk/LayoutTests/ChangeLog	2018-05-16 19:46:22 UTC (rev 231864)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 20:24:32 UTC (rev 231865)
@@ -1,5 +1,17 @@
 2018-05-16  Youenn Fablet  <you...@apple.com>
 
+        Layout Test webrtc/addICECandidate-closed.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=185384
+        <rdar://problem/40035167>
+
+        Reviewed by Eric Carlson.
+
+        * webrtc/addICECandidate-closed.html:
+        Handle sometimes rejected promise to remove a line
+        in the -expected.txt file that is sometimes added.
+
+2018-05-16  Youenn Fablet  <you...@apple.com>
+
         REGRESSION (r229735): LayoutTest http/wpt/service-workers/third-party-registration.html is a flaky timeout
         https://bugs.webkit.org/show_bug.cgi?id=183860
         <rdar://problem/38975251>

Modified: trunk/LayoutTests/webrtc/addICECandidate-closed.html (231864 => 231865)


--- trunk/LayoutTests/webrtc/addICECandidate-closed.html	2018-05-16 19:46:22 UTC (rev 231864)
+++ trunk/LayoutTests/webrtc/addICECandidate-closed.html	2018-05-16 20:24:32 UTC (rev 231865)
@@ -15,10 +15,8 @@
         const localTracks = stream.getTracks();
         [[sender, receiver], [receiver, sender]].forEach(([pc1, pc2]) => {
             pc1._onicecandidate_ = ({ candidate }) => {
-                try {
-                    if (candidate)
-                        pc2.addIceCandidate(candidate);
-                } catch (e) { }
+                if (candidate)
+                    pc2.addIceCandidate(candidate).then(() => { }, () => { });
                 pc1.close();
             };
         });
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to