Title: [233190] trunk/Tools
- Revision
- 233190
- Author
- dba...@webkit.org
- Date
- 2018-06-25 21:58:42 -0700 (Mon, 25 Jun 2018)
Log Message
Log a message when fetching attachment data from the status server
https://bugs.webkit.org/show_bug.cgi?id=187032
Reviewed by Zalan Bujtas.
Currently we silently fetch from the status server an attachment when fetching
the attachment from Bugzilla fails due to an access denied error. Instead we
should emit a message when fetching data from the status server to indicate
that webkit-patch/EWS is still processing the command/trying to obtain the
patch.
* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer._fetch_attachment_page):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233189 => 233190)
--- trunk/Tools/ChangeLog 2018-06-26 02:05:35 UTC (rev 233189)
+++ trunk/Tools/ChangeLog 2018-06-26 04:58:42 UTC (rev 233190)
@@ -1,3 +1,19 @@
+2018-06-25 Daniel Bates <daba...@apple.com>
+
+ Log a message when fetching attachment data from the status server
+ https://bugs.webkit.org/show_bug.cgi?id=187032
+
+ Reviewed by Zalan Bujtas.
+
+ Currently we silently fetch from the status server an attachment when fetching
+ the attachment from Bugzilla fails due to an access denied error. Instead we
+ should emit a message when fetching data from the status server to indicate
+ that webkit-patch/EWS is still processing the command/trying to obtain the
+ patch.
+
+ * Scripts/webkitpy/common/net/statusserver.py:
+ (StatusServer._fetch_attachment_page):
+
2018-06-25 Aakash Jain <aakash_j...@apple.com>
[ews-build] Add support for Bindings-tests-EWS
Modified: trunk/Tools/Scripts/webkitpy/common/net/statusserver.py (233189 => 233190)
--- trunk/Tools/Scripts/webkitpy/common/net/statusserver.py 2018-06-26 02:05:35 UTC (rev 233189)
+++ trunk/Tools/Scripts/webkitpy/common/net/statusserver.py 2018-06-26 04:58:42 UTC (rev 233190)
@@ -203,6 +203,7 @@
def _fetch_attachment_page(self, action, attachment_id):
attachment_url = '{}/attachment/{}/{}'.format(self._server_url(), action, attachment_id)
+ _log.info('Fetching: {}'.format(attachment_url))
return self._fetch_url(attachment_url)
def fetch_attachment(self, attachment_id):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
