Title: [234046] branches/safari-606-branch/Source/WebKit
- Revision
- 234046
- Author
- bshaf...@apple.com
- Date
- 2018-07-20 10:01:26 -0700 (Fri, 20 Jul 2018)
Log Message
Cherry-pick r233925. rdar://problem/42354959
Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
https://bugs.webkit.org/show_bug.cgi?id=187775
<rdar://problem/42343229>
Reviewed by Jon Lee.
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606-branch/Source/WebKit/ChangeLog (234045 => 234046)
--- branches/safari-606-branch/Source/WebKit/ChangeLog 2018-07-20 16:58:54 UTC (rev 234045)
+++ branches/safari-606-branch/Source/WebKit/ChangeLog 2018-07-20 17:01:26 UTC (rev 234046)
@@ -1,5 +1,31 @@
2018-07-20 Babak Shafiei <bshaf...@apple.com>
+ Cherry-pick r233925. rdar://problem/42354959
+
+ Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
+ https://bugs.webkit.org/show_bug.cgi?id=187775
+ <rdar://problem/42343229>
+
+ Reviewed by Jon Lee.
+
+ * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+ (WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-18 Jer Noble <jer.no...@apple.com>
+
+ Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
+ https://bugs.webkit.org/show_bug.cgi?id=187775
+ <rdar://problem/42343229>
+
+ Reviewed by Jon Lee.
+
+ * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+ (WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
+
+2018-07-20 Babak Shafiei <bshaf...@apple.com>
+
Cherry-pick r234020. rdar://problem/42417121
[ITP] Crash under ResourceLoadStatisticsMemoryStore::removeDataRecords()
Modified: branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm (234045 => 234046)
--- branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm 2018-07-20 16:58:54 UTC (rev 234045)
+++ branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm 2018-07-20 17:01:26 UTC (rev 234046)
@@ -646,6 +646,7 @@
m_page->send(Messages::VideoFullscreenManager::DidCleanupFullscreen(contextId), m_page->pageID());
interface->setMode(HTMLMediaElementEnums::VideoFullscreenModeNone);
+ interface->setVideoFullscreenModel(nullptr);
removeClientForContext(contextId);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
