Title: [235508] trunk/LayoutTests
Revision
235508
Author
you...@apple.com
Date
2018-08-30 09:53:01 -0700 (Thu, 30 Aug 2018)

Log Message

fast/mediastream/RTCPeerConnection-overloaded-operations.html is flaky after r235484
https://bugs.webkit.org/show_bug.cgi?id=189155

Reviewed by Eric Carlson.

* fast/mediastream/RTCPeerConnection-overloaded-operations.html:
createOffer/createAnswer will now reject promises if callbacks are passed as parameters.
Make sure that these promises are handled.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (235507 => 235508)


--- trunk/LayoutTests/ChangeLog	2018-08-30 16:35:46 UTC (rev 235507)
+++ trunk/LayoutTests/ChangeLog	2018-08-30 16:53:01 UTC (rev 235508)
@@ -1,3 +1,14 @@
+2018-08-30  Youenn Fablet  <you...@apple.com>
+
+        fast/mediastream/RTCPeerConnection-overloaded-operations.html is flaky after r235484
+        https://bugs.webkit.org/show_bug.cgi?id=189155
+
+        Reviewed by Eric Carlson.
+
+        * fast/mediastream/RTCPeerConnection-overloaded-operations.html:
+        createOffer/createAnswer will now reject promises if callbacks are passed as parameters.
+        Make sure that these promises are handled.
+
 2018-08-30  Zalan Bujtas  <za...@apple.com>
 
         [LFC][Floating] Formatting context roots avoid floats.

Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html (235507 => 235508)


--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html	2018-08-30 16:35:46 UTC (rev 235507)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html	2018-08-30 16:53:01 UTC (rev 235508)
@@ -27,9 +27,11 @@
 
                 shouldNotThrow("result = pc." + functionName + "(emptyFunc, emptyFunc)");
                 shouldBeType("result", "Promise");
+                result.then(() => { }, () => { });
 
                 shouldNotThrow("result = pc." + functionName + "(emptyFunc, emptyFunc, {})");
                 shouldBeType("result", "Promise");
+                result.then(() => { }, () => { });
             }
 
             // Test setLocal/RemoteDescription()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to