Title: [236375] trunk/Source/WebKit
- Revision
- 236375
- Author
- bb...@apple.com
- Date
- 2018-09-21 17:14:05 -0700 (Fri, 21 Sep 2018)
Log Message
Web Inspector: dock buttons disappear if Web Inspector goes fullscreen
https://bugs.webkit.org/show_bug.cgi?id=189865
<rdar://problem/42600534>
Reviewed by Matt Baker.
When a fullscreen Safari tab has a docked Inspector, and the "detach" button
is clicked, Inspector goes into its own fullscreen window. In that window,
there are no buttons for docking to side or bottom.
It turns out that we always send setDockingUnavailable(true) if the inspector
window is fullscreen. This eventually causes the inspector to reflect that
by hiding the docking-related buttons.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCanAttach):
This early exit does not seem to serve any purpose, so remove it.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236374 => 236375)
--- trunk/Source/WebKit/ChangeLog 2018-09-21 23:42:09 UTC (rev 236374)
+++ trunk/Source/WebKit/ChangeLog 2018-09-22 00:14:05 UTC (rev 236375)
@@ -1,3 +1,23 @@
+2018-09-21 Brian Burg <bb...@apple.com>
+
+ Web Inspector: dock buttons disappear if Web Inspector goes fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=189865
+ <rdar://problem/42600534>
+
+ Reviewed by Matt Baker.
+
+ When a fullscreen Safari tab has a docked Inspector, and the "detach" button
+ is clicked, Inspector goes into its own fullscreen window. In that window,
+ there are no buttons for docking to side or bottom.
+
+ It turns out that we always send setDockingUnavailable(true) if the inspector
+ window is fullscreen. This eventually causes the inspector to reflect that
+ by hiding the docking-related buttons.
+
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::platformCanAttach):
+ This early exit does not seem to serve any purpose, so remove it.
+
2018-09-21 Chris Dumez <cdu...@apple.com>
Extending the lifetime of a NetworkProcessProxy / StorageProcessProxy may cause it to have a stale WebProcessPool pointer
Modified: trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm (236374 => 236375)
--- trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm 2018-09-21 23:42:09 UTC (rev 236374)
+++ trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm 2018-09-22 00:14:05 UTC (rev 236375)
@@ -347,9 +347,6 @@
bool WebInspectorProxy::platformCanAttach(bool webProcessCanAttach)
{
- if ([m_inspectorWindow styleMask] & NSWindowStyleMaskFullScreen)
- return false;
-
NSView *inspectedView = inspectedPage()->inspectorAttachmentView();
if ([WKInspectorViewController viewIsInspectorWebView:inspectedView])
return webProcessCanAttach;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
