Title: [236476] trunk/Tools
Revision
236476
Author
eric.carl...@apple.com
Date
2018-09-25 14:31:29 -0700 (Tue, 25 Sep 2018)

Log Message

[MediaStream] Update constraints supported by getDisplayMedia
https://bugs.webkit.org/show_bug.cgi?id=189930
<rdar://problem/44740305>

Unreviewed, fix test broken by r236465.


* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(TestWebKitAPI::TEST_F):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (236475 => 236476)


--- trunk/Tools/ChangeLog	2018-09-25 21:21:10 UTC (rev 236475)
+++ trunk/Tools/ChangeLog	2018-09-25 21:31:29 UTC (rev 236476)
@@ -1,3 +1,14 @@
+2018-09-25  Eric Carlson  <eric.carl...@apple.com>
+
+        [MediaStream] Update constraints supported by getDisplayMedia
+        https://bugs.webkit.org/show_bug.cgi?id=189930
+        <rdar://problem/44740305>
+
+        Unreviewed, fix test broken by r236465.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
+        (TestWebKitAPI::TEST_F):
+
 2018-09-25  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         [WHSL] Implement semantics

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm (236475 => 236476)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm	2018-09-25 21:21:10 UTC (rev 236475)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm	2018-09-25 21:31:29 UTC (rev 236476)
@@ -152,7 +152,7 @@
 TEST_F(GetDisplayMediaTest, BasicPrompt)
 {
     promptForCapture(@"{ audio: true, video: true }", true);
-    promptForCapture(@"{ audio: true, video: false }", true);
+    promptForCapture(@"{ audio: true, video: false }", false);
     promptForCapture(@"{ audio: false, video: true }", true);
     promptForCapture(@"{ audio: false, video: false }", false);
 }
@@ -159,9 +159,10 @@
 
 TEST_F(GetDisplayMediaTest, Constraints)
 {
-    promptForCapture(@"{ video: {width: 640} }", false);
-    promptForCapture(@"{ video: true, audio: { volume: 0.5 } }", false);
-    promptForCapture(@"{ video: {height: 480}, audio: true }", false);
+    promptForCapture(@"{ video: {width: 640} }", true);
+    promptForCapture(@"{ video: true, audio: { volume: 0.5 } }", true);
+    promptForCapture(@"{ video: {height: 480}, audio: true }", true);
+    promptForCapture(@"{ video: {width: { exact: 640} } }", false);
 }
 
 } // namespace TestWebKitAPI
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to