Title: [236699] trunk/PerformanceTests
Revision
236699
Author
cdu...@apple.com
Date
2018-10-01 16:45:59 -0700 (Mon, 01 Oct 2018)

Log Message

Regression(r236613): Parser/HTML5-8266-ParseOnly.html performance tests no longer runs
https://bugs.webkit.org/show_bug.cgi?id=190174

Reviewed by Ryosuke Niwa.

Update iframe's sandbox to use 'allow-same-origin' so that the iframe is treated as same-origin and so that
the top frame can call document.open() / document.write() on the subframe. This test was also failing in
Firefox without this change.

* Parser/HTML5-8266-ParseOnly.html:

Modified Paths

Diff

Modified: trunk/PerformanceTests/ChangeLog (236698 => 236699)


--- trunk/PerformanceTests/ChangeLog	2018-10-01 23:28:43 UTC (rev 236698)
+++ trunk/PerformanceTests/ChangeLog	2018-10-01 23:45:59 UTC (rev 236699)
@@ -1,3 +1,16 @@
+2018-10-01  Chris Dumez  <cdu...@apple.com>
+
+        Regression(r236613): Parser/HTML5-8266-ParseOnly.html performance tests no longer runs
+        https://bugs.webkit.org/show_bug.cgi?id=190174
+
+        Reviewed by Ryosuke Niwa.
+
+        Update iframe's sandbox to use 'allow-same-origin' so that the iframe is treated as same-origin and so that
+        the top frame can call document.open() / document.write() on the subframe. This test was also failing in
+        Firefox without this change.
+
+        * Parser/HTML5-8266-ParseOnly.html:
+
 2018-08-27  Aditya Keerthi  <akeer...@apple.com>
 
         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER

Modified: trunk/PerformanceTests/Parser/HTML5-8266-ParseOnly.html (236698 => 236699)


--- trunk/PerformanceTests/Parser/HTML5-8266-ParseOnly.html	2018-10-01 23:28:43 UTC (rev 236698)
+++ trunk/PerformanceTests/Parser/HTML5-8266-ParseOnly.html	2018-10-01 23:45:59 UTC (rev 236699)
@@ -7,7 +7,7 @@
 PerfTestRunner.measureTime({run: function() {
     var iframe = document.createElement("iframe");
     iframe.style.display = "none";  // Prevent creation of the rendering tree, so we only test HTML parsing.
-    iframe.sandbox = '';  // Prevent external script loads which could cause write() to return before completing the parse.
+    iframe.sandbox = 'allow-same-origin';  // Prevent external script loads which could cause write() to return before completing the parse.
     document.body.appendChild(iframe);
     iframe.contentDocument.open();
     iframe.contentDocument.write(spec);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to