Title: [236763] trunk/Source
- Revision
- 236763
- Author
- achristen...@apple.com
- Date
- 2018-10-02 13:26:15 -0700 (Tue, 02 Oct 2018)
Log Message
Remove unused linked-on-or-before-iOS5 check
https://bugs.webkit.org/show_bug.cgi?id=190164
Reviewed by Michael Saboff.
Source/WebCore:
If an app hasn't been updated since iOS5, it can't run supported iOS.
This value is also only checked in an uninstantiated template function.
* platform/URL.cpp:
(WebCore::enableURLSchemeCanonicalization): Deleted.
(WebCore::equal): Deleted.
* platform/URL.h:
Source/WebKitLegacy/ios:
* Misc/WebUIKitSupport.mm:
(WebKitInitialize):
(linkedOnOrAfterIOS5): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (236762 => 236763)
--- trunk/Source/WebCore/ChangeLog 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebCore/ChangeLog 2018-10-02 20:26:15 UTC (rev 236763)
@@ -1,5 +1,20 @@
2018-10-02 Alex Christensen <achristen...@webkit.org>
+ Remove unused linked-on-or-before-iOS5 check
+ https://bugs.webkit.org/show_bug.cgi?id=190164
+
+ Reviewed by Michael Saboff.
+
+ If an app hasn't been updated since iOS5, it can't run supported iOS.
+ This value is also only checked in an uninstantiated template function.
+
+ * platform/URL.cpp:
+ (WebCore::enableURLSchemeCanonicalization): Deleted.
+ (WebCore::equal): Deleted.
+ * platform/URL.h:
+
+2018-10-02 Alex Christensen <achristen...@webkit.org>
+
Remove ParsedURLString
https://bugs.webkit.org/show_bug.cgi?id=190154
Modified: trunk/Source/WebCore/platform/URL.cpp (236762 => 236763)
--- trunk/Source/WebCore/platform/URL.cpp 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebCore/platform/URL.cpp 2018-10-02 20:26:15 UTC (rev 236763)
@@ -664,42 +664,6 @@
*this = parser.result();
}
-#if PLATFORM(IOS)
-
-static bool shouldCanonicalizeScheme = true;
-
-void enableURLSchemeCanonicalization(bool enableSchemeCanonicalization)
-{
- shouldCanonicalizeScheme = enableSchemeCanonicalization;
-}
-
-#endif
-
-template<size_t length>
-static inline bool equal(const char* a, const char (&b)[length])
-{
-#if PLATFORM(IOS)
- if (!shouldCanonicalizeScheme) {
- for (size_t i = 0; i < length; ++i) {
- if (toASCIILower(a[i]) != b[i])
- return false;
- }
- return true;
- }
-#endif
- for (size_t i = 0; i < length; ++i) {
- if (a[i] != b[i])
- return false;
- }
- return true;
-}
-
-template<size_t lengthB>
-static inline bool equal(const char* stringA, size_t lengthA, const char (&stringB)[lengthB])
-{
- return lengthA == lengthB && equal(stringA, stringB);
-}
-
bool equalIgnoringFragmentIdentifier(const URL& a, const URL& b)
{
if (a.m_queryEnd != b.m_queryEnd)
Modified: trunk/Source/WebCore/platform/URL.h (236762 => 236763)
--- trunk/Source/WebCore/platform/URL.h 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebCore/platform/URL.h 2018-10-02 20:26:15 UTC (rev 236763)
@@ -261,13 +261,6 @@
return URL(URL(), string);
}
-bool operator==(const URL&, const URL&);
-bool operator==(const URL&, const String&);
-bool operator==(const String&, const URL&);
-bool operator!=(const URL&, const URL&);
-bool operator!=(const URL&, const String&);
-bool operator!=(const String&, const URL&);
-
WEBCORE_EXPORT bool equalIgnoringFragmentIdentifier(const URL&, const URL&);
WEBCORE_EXPORT bool equalIgnoringQueryAndFragment(const URL&, const URL&);
WEBCORE_EXPORT bool protocolHostAndPortAreEqual(const URL&, const URL&);
@@ -299,10 +292,6 @@
// FIXME: This is a wrong concept to expose, different parts of a URL need different escaping per the URL Standard.
WEBCORE_EXPORT String encodeWithURLEscapeSequences(const String&);
-#if PLATFORM(IOS)
-WEBCORE_EXPORT void enableURLSchemeCanonicalization(bool);
-#endif
-
// Inlines.
inline bool operator==(const URL& a, const URL& b)
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (236762 => 236763)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2018-10-02 20:26:15 UTC (rev 236763)
@@ -1,3 +1,14 @@
+2018-10-02 Alex Christensen <achristen...@webkit.org>
+
+ Remove unused linked-on-or-before-iOS5 check
+ https://bugs.webkit.org/show_bug.cgi?id=190164
+
+ Reviewed by Michael Saboff.
+
+ * Misc/WebUIKitSupport.mm:
+ (WebKitInitialize):
+ (linkedOnOrAfterIOS5): Deleted.
+
2018-09-17 Darin Adler <da...@apple.com>
Use OpaqueJSString rather than JSRetainPtr inside WebKit
Modified: trunk/Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm (236762 => 236763)
--- trunk/Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm 2018-10-02 20:26:15 UTC (rev 236763)
@@ -42,12 +42,6 @@
using namespace WebCore;
-static inline bool linkedOnOrAfterIOS5()
-{
- static bool s_linkedOnOrAfterIOS5 = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_5_0;
- return s_linkedOnOrAfterIOS5;
-}
-
// See <rdar://problem/7902473> Optimize WebLocalizedString for why we do this on a background thread on a timer callback
static void LoadWebLocalizedStringsTimerCallback(CFRunLoopTimerRef timer, void *info)
{
@@ -85,7 +79,6 @@
// This needs to be called before any requests are made in the process, <rdar://problem/9691871>
WebCore::initializeHTTPConnectionSettingsOnStartup();
- WebCore::enableURLSchemeCanonicalization(linkedOnOrAfterIOS5());
}
void WebKitSetIsClassic(BOOL flag)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
