- Revision
- 236913
- Author
- m...@apple.com
- Date
- 2018-10-08 06:55:14 -0700 (Mon, 08 Oct 2018)
Log Message
Source/ThirdParty:
gtest part of [Xcode] Update some build settings as recommended by Xcode 10
https://bugs.webkit.org/show_bug.cgi?id=190250
Reviewed by Anders Carlsson.
Didn’t turn on any of the warnings Xcode recommended for this third-party test support
library.
* gtest/xcode/Config/DebugProject.xcconfig: Set the deployment target in engineering builds
like we do in other projects. This addresses a build-time warning when building clients
of the library that its deployment target doesn’t match theirs.
* gtest/xcode/Config/ReleaseProject.xcconfig: Ditto.
* gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
Tools:
Tools part of [Xcode] Update some build settings as recommended by Xcode 10
https://bugs.webkit.org/show_bug.cgi?id=190250
Reviewed by Anders Carlsson.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
* DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
* DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
* DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
around deprecated methods or categories on deprecated classes.
* DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
(-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
* DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
* MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
* MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
* MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
* MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
* MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
* TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
Made the WebKit headers be treated as system headers to avoid dealing with the fact that
many C SPI headers trigger the strict prototypes warning.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
(-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
* TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
(-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
* TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
(-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
(-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
* TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
(-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
(-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
(-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
* TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
(-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
* TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
(-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
* TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
(-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
(-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
* TestWebKitAPI/mac/TestDraggingInfo.mm:
(-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
In all of the above, suppressed the deprecated implementations warning where needed.
* WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
and GCC_NO_COMMON_BLOCKS.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
the deprecated implementations warning.
* WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/ChangeLog (236912 => 236913)
--- trunk/Source/ThirdParty/ChangeLog 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Source/ThirdParty/ChangeLog 2018-10-08 13:55:14 UTC (rev 236913)
@@ -1,3 +1,20 @@
+2018-10-08 Dan Bernstein <m...@apple.com>
+
+ gtest part of [Xcode] Update some build settings as recommended by Xcode 10
+ https://bugs.webkit.org/show_bug.cgi?id=190250
+
+ Reviewed by Anders Carlsson.
+
+ Didn’t turn on any of the warnings Xcode recommended for this third-party test support
+ library.
+
+ * gtest/xcode/Config/DebugProject.xcconfig: Set the deployment target in engineering builds
+ like we do in other projects. This addresses a build-time warning when building clients
+ of the library that its deployment target doesn’t match theirs.
+ * gtest/xcode/Config/ReleaseProject.xcconfig: Ditto.
+
+ * gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
+
2018-09-05 Don Olmstead <don.olmst...@sony.com>
[CMake] Allow port specific options on gtest
Modified: trunk/Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig (236912 => 236913)
--- trunk/Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig 2018-10-08 13:55:14 UTC (rev 236913)
@@ -16,6 +16,12 @@
// Deployment postprocessing is what triggers Xcode to strip, turn it off
DEPLOYMENT_POSTPROCESSING = NO
+MACOSX_DEPLOYMENT_TARGET = $(MACOSX_DEPLOYMENT_TARGET_$(TARGET_MAC_OS_X_VERSION_MAJOR));
+MACOSX_DEPLOYMENT_TARGET_101200 = 10.12;
+MACOSX_DEPLOYMENT_TARGET_101300 = 10.13;
+MACOSX_DEPLOYMENT_TARGET_101400 = 10.14;
+MACOSX_DEPLOYMENT_TARGET_101500 = 10.15;
+
// Dead code stripping off
DEAD_CODE_STRIPPING = NO
Modified: trunk/Source/ThirdParty/gtest/xcode/Config/ReleaseProject.xcconfig (236912 => 236913)
--- trunk/Source/ThirdParty/gtest/xcode/Config/ReleaseProject.xcconfig 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Source/ThirdParty/gtest/xcode/Config/ReleaseProject.xcconfig 2018-10-08 13:55:14 UTC (rev 236913)
@@ -18,6 +18,12 @@
// Deploment postprocessing is what triggers Xcode to strip
DEPLOYMENT_POSTPROCESSING = YES
+MACOSX_DEPLOYMENT_TARGET = $(MACOSX_DEPLOYMENT_TARGET_$(TARGET_MAC_OS_X_VERSION_MAJOR));
+MACOSX_DEPLOYMENT_TARGET_101200 = 10.12;
+MACOSX_DEPLOYMENT_TARGET_101300 = 10.13;
+MACOSX_DEPLOYMENT_TARGET_101400 = 10.14;
+MACOSX_DEPLOYMENT_TARGET_101500 = 10.15;
+
// No symbols
GCC_GENERATE_DEBUGGING_SYMBOLS = NO
@@ -36,3 +42,9 @@
SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK));
SDKROOT_ = macosx;
SDKROOT_YES = macosx.internal;
+
+MACOSX_DEPLOYMENT_TARGET = $(MACOSX_DEPLOYMENT_TARGET_$(TARGET_MAC_OS_X_VERSION_MAJOR));
+MACOSX_DEPLOYMENT_TARGET_101200 = 10.12;
+MACOSX_DEPLOYMENT_TARGET_101300 = 10.13;
+MACOSX_DEPLOYMENT_TARGET_101400 = 10.14;
+MACOSX_DEPLOYMENT_TARGET_101500 = 10.15;
Modified: trunk/Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj (236912 => 236913)
--- trunk/Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj 2018-10-08 13:55:14 UTC (rev 236913)
@@ -625,7 +625,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0700;
- LastUpgradeCheck = 0600;
+ LastUpgradeCheck = 1000;
};
buildConfigurationList = 4FADC24608B4156D00ABE55E /* Build configuration list for PBXProject "gtest" */;
compatibilityVersion = "Xcode 3.2";
Modified: trunk/Tools/ChangeLog (236912 => 236913)
--- trunk/Tools/ChangeLog 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/ChangeLog 2018-10-08 13:55:14 UTC (rev 236913)
@@ -1,3 +1,96 @@
+2018-10-08 Dan Bernstein <m...@apple.com>
+
+ Tools part of [Xcode] Update some build settings as recommended by Xcode 10
+ https://bugs.webkit.org/show_bug.cgi?id=190250
+
+ Reviewed by Anders Carlsson.
+
+ * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
+
+ * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
+ CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
+ CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
+
+ * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
+
+ * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
+ around deprecated methods or categories on deprecated classes.
+ * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
+ (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
+ * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
+ (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
+
+ * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
+ CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
+ CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
+
+ * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
+
+ * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
+ * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
+ address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
+
+ * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
+ CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
+ CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
+
+ * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
+ LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
+
+ * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
+ CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
+ CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
+ Made the WebKit headers be treated as system headers to avoid dealing with the fact that
+ many C SPI headers trigger the strict prototypes warning.
+
+ * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
+ (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
+ (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
+ (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
+ (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
+ * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
+ (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
+ (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
+ * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
+ (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
+ * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
+ (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
+ (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
+ * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
+ (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
+ (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
+ (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
+ * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
+ (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
+ * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
+ (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
+ * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
+ (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
+ (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
+ * TestWebKitAPI/mac/TestDraggingInfo.mm:
+ (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
+
+ In all of the above, suppressed the deprecated implementations warning where needed.
+
+ * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
+ CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
+ CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
+ CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
+ GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
+ CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
+ and GCC_NO_COMMON_BLOCKS.
+
+ * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
+
+ * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
+ (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
+ the deprecated implementations warning.
+
+ * WebKitTestRunner/mac/UIScriptControllerMac.mm:
+ (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
+
2018-10-07 Yacine Bandou <yacine.ban...@softathome.com>
[GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (236912 => 236913)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2018-10-08 13:55:14 UTC (rev 236913)
@@ -952,7 +952,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0700;
- LastUpgradeCheck = 0700;
+ LastUpgradeCheck = 1000;
};
buildConfigurationList = 149C29C308902C6D008A9EFC /* Build configuration list for PBXProject "DumpRenderTree" */;
compatibilityVersion = "Xcode 3.2";
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (236912 => 236913)
--- trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2018-10-08 13:55:14 UTC (rev 236913)
@@ -58,6 +58,7 @@
GCC_TREAT_WARNINGS_AS_ERRORS = YES
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
@@ -64,9 +65,11 @@
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
+CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
@@ -76,6 +79,8 @@
GCC_WARN_UNUSED_VARIABLE = YES
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
+CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
// FIXME: <http://webkit.org/b/118590> DumpRenderTree should build with -Wshorten-64-to-32
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h (236912 => 236913)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h 2018-10-08 13:55:14 UTC (rev 236913)
@@ -57,10 +57,10 @@
#endif
void setWaitToDumpWatchdog(CFRunLoopTimerRef);
-bool shouldSetWaitToDumpWatchdog();
+bool shouldSetWaitToDumpWatchdog(void);
#ifdef __OBJC__
-WebView *createWebViewAndOffscreenWindow() NS_RETURNS_RETAINED;
+WebView *createWebViewAndOffscreenWindow(void) NS_RETURNS_RETAINED;
#endif
void setPersistentUserStyleSheetLocation(CFStringRef);
Modified: trunk/Tools/DumpRenderTree/mac/EditingDelegate.mm (236912 => 236913)
--- trunk/Tools/DumpRenderTree/mac/EditingDelegate.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/DumpRenderTree/mac/EditingDelegate.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -37,7 +37,9 @@
- (NSString *)dumpPath;
@end
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation DOMNode (dumpPath)
+IGNORE_WARNINGS_END
- (NSString *)dumpPath
{
DOMNode *parent = [self parentNode];
@@ -54,7 +56,9 @@
- (NSString *)dump;
@end
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation DOMRange (dump)
+IGNORE_WARNINGS_END
- (NSString *)dump
{
return [NSString stringWithFormat:@"range from %d of %@ to %d of %@", [self startOffset], [[self startContainer] dumpPath], [self endOffset], [[self endContainer] dumpPath]];
Modified: trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm (236912 => 236913)
--- trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -85,7 +85,9 @@
- (NSString *)_drt_descriptionSuitableForTestResult;
@end
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WebFrame (DRTExtras)
+IGNORE_WARNINGS_END
- (NSString *)_drt_descriptionSuitableForTestResult
{
BOOL isMainFrame = (self == [[self webView] mainFrame]);
@@ -275,7 +277,9 @@
[self webView:sender locationChangeDone:error forDataSource:[frame dataSource]];
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)webView:(WebView *)webView windowScriptObjectAvailable:(WebScriptObject *)windowScriptObject
+IGNORE_WARNINGS_END
{
if (!done && gTestRunner->dumpFrameLoadCallbacks()) {
NSString *string = [NSString stringWithFormat:@"?? - windowScriptObjectAvailable"];
Modified: trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm (236912 => 236913)
--- trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -1081,7 +1081,9 @@
return YES;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)connection:(NSURLConnection *)connection didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge
+IGNORE_WARNINGS_END
{
if ([challenge previousFailureCount] == 0) {
RetainPtr<NSURLCredential> credential = adoptNS([[NSURLCredential alloc] initWithUser:m_username password:m_password persistence:NSURLCredentialPersistenceForSession]);
Modified: trunk/Tools/MiniBrowser/Configurations/Base.xcconfig (236912 => 236913)
--- trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2018-10-08 13:55:14 UTC (rev 236913)
@@ -42,6 +42,7 @@
GCC_TREAT_WARNINGS_AS_ERRORS = YES
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
@@ -48,9 +49,11 @@
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
+CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
@@ -60,6 +63,8 @@
GCC_WARN_UNUSED_VARIABLE = YES
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
+CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
GCC_NO_COMMON_BLOCKS = YES;
Modified: trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj (236912 => 236913)
--- trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj 2018-10-08 13:55:14 UTC (rev 236913)
@@ -250,7 +250,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0700;
- LastUpgradeCheck = 0700;
+ LastUpgradeCheck = 1000;
TargetAttributes = {
8D1107260486CEB800E47090 = {
SystemCapabilities = {
Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.h (236912 => 236913)
--- trunk/Tools/MiniBrowser/mac/AppDelegate.h 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.h 2018-10-08 13:55:14 UTC (rev 236913)
@@ -48,5 +48,5 @@
@end
#if WK_API_ENABLED
-WKPreferences *defaultPreferences();
+WKPreferences *defaultPreferences(void);
#endif
Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (236912 => 236913)
--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2018-10-08 13:55:14 UTC (rev 236913)
@@ -33,7 +33,6 @@
#import <WebKit/WKFrameInfo.h>
#import <WebKit/WKNavigationActionPrivate.h>
#import <WebKit/WKNavigationDelegate.h>
-#import <WebKit/WKPage.h>
#import <WebKit/WKPreferencesPrivate.h>
#import <WebKit/WKUIDelegate.h>
#import <WebKit/WKUIDelegatePrivate.h>
Modified: trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig (236912 => 236913)
--- trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig 2018-10-08 13:55:14 UTC (rev 236913)
@@ -35,6 +35,7 @@
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_COMMA = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_CXX0X_EXTENSIONS = NO;
@@ -45,10 +46,12 @@
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
-CLANG_WARN_SUSPICIOUS_MOVES = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
+CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
@@ -67,6 +70,7 @@
GCC_VERSION = com.apple.compilers.llvm.clang.1_0
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNDECLARED_SELECTOR = YES;
+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES
GCC_WARN_UNUSED_VARIABLE = YES
Modified: trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj (236912 => 236913)
--- trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj 2018-10-08 13:55:14 UTC (rev 236913)
@@ -25,9 +25,6 @@
CD498B511D763D7F00681FA7 /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = CD1DAF9E1D709E3600017CF0 /* Main.storyboard */; };
CD498B521D763D8800681FA7 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = CD1DAFA11D709E3600017CF0 /* Assets.xcassets */; };
CD498B531D763D9300681FA7 /* Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = CD498B471D7634C700681FA7 /* Info.plist */; };
- CD4DEEE51D78C6FF00625986 /* Base.xcconfig in Resources */ = {isa = PBXBuildFile; fileRef = CD4DEEE21D78C6FF00625986 /* Base.xcconfig */; };
- CD4DEEE61D78C6FF00625986 /* DebugRelease.xcconfig in Resources */ = {isa = PBXBuildFile; fileRef = CD4DEEE31D78C6FF00625986 /* DebugRelease.xcconfig */; };
- CD4DEEE71D78C6FF00625986 /* MobileMiniBrowser.xcconfig in Resources */ = {isa = PBXBuildFile; fileRef = CD4DEEE41D78C6FF00625986 /* MobileMiniBrowser.xcconfig */; };
CDA985191D76483400EBC399 /* test.mp4 in Resources */ = {isa = PBXBuildFile; fileRef = CDA985151D76477900EBC399 /* test.mp4 */; };
CDA9851A1D76483400EBC399 /* index.html in Resources */ = {isa = PBXBuildFile; fileRef = CDA985131D76474100EBC399 /* index.html */; };
CDA9851B1D76483400EBC399 /* looping.html in Resources */ = {isa = PBXBuildFile; fileRef = CDA985171D7647CD00EBC399 /* looping.html */; };
@@ -290,7 +287,7 @@
CD1DAF8A1D709E3600017CF0 /* Project object */ = {
isa = PBXProject;
attributes = {
- LastUpgradeCheck = 0800;
+ LastUpgradeCheck = 1000;
ORGANIZATIONNAME = WebKit;
TargetAttributes = {
CD1DAF911D709E3600017CF0 = {
@@ -331,10 +328,7 @@
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
- CD4DEEE51D78C6FF00625986 /* Base.xcconfig in Resources */,
- CD4DEEE61D78C6FF00625986 /* DebugRelease.xcconfig in Resources */,
CD1DAFA51D709E3600017CF0 /* LaunchScreen.storyboard in Resources */,
- CD4DEEE71D78C6FF00625986 /* MobileMiniBrowser.xcconfig in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2018-10-08 13:55:14 UTC (rev 236913)
@@ -48,6 +48,7 @@
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
@@ -54,9 +55,11 @@
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
+CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
GCC_WARN_ABOUT_RETURN_TYPE = YES;
@@ -65,6 +68,8 @@
GCC_WARN_UNUSED_VARIABLE = YES
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
+CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
@@ -95,7 +100,7 @@
EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = *IOS.h *IOS.cpp *IOS.mm;
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *Mac.h *Mac.cpp *Mac.mm */mac/*;
-OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
+OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) --system-header-prefix=WebKit/;
OTHER_CFLAGS[sdk=macosx*] = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2018-10-08 13:55:14 UTC (rev 236913)
@@ -3542,7 +3542,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0700;
- LastUpgradeCheck = 0700;
+ LastUpgradeCheck = 1000;
TargetAttributes = {
7C83E02B1D0A5E1000FEBCF3 = {
CreatedOnToolsVersion = 8.0;
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -87,7 +87,9 @@
_receivedContentLength += length;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSString *)_download:(_WKDownload *)download decideDestinationWithSuggestedFilename:(NSString *)filename allowOverwrite:(BOOL *)allowOverwrite
+IGNORE_WARNINGS_END
{
EXPECT_TRUE(hasReceivedResponse);
EXPECT_EQ(_download, download);
@@ -388,7 +390,9 @@
_receivedContentLength += length;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSString *)_download:(_WKDownload *)download decideDestinationWithSuggestedFilename:(NSString *)filename allowOverwrite:(BOOL *)allowOverwrite
+IGNORE_WARNINGS_END
{
EXPECT_TRUE(hasReceivedResponse);
EXPECT_EQ(_download, download);
@@ -440,7 +444,9 @@
@implementation UIDownloadAsFileTestDelegate
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSMenu *)_webView:(WKWebView *)webView contextMenu:(NSMenu *)menu forElement:(_WKContextMenuElementInfo *)element
+IGNORE_WARNINGS_END
{
static const long downloadLinkedFileTag = 2;
auto index = [menu indexOfItemWithTag:downloadLinkedFileTag];
@@ -464,7 +470,9 @@
EXPECT_EQ(expectedUserInitiatedState, download.wasUserInitiated);
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSString *)_download:(_WKDownload *)download decideDestinationWithSuggestedFilename:(NSString *)filename allowOverwrite:(BOOL *)allowOverwrite
+IGNORE_WARNINGS_END
{
WebCore::FileSystem::PlatformFileHandle fileHandle;
_destinationPath = WebCore::FileSystem::openTemporaryFile("TestWebKitAPI", fileHandle);
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -778,7 +778,9 @@
@implementation CustomHeaderFieldsDelegate
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy, _WKWebsitePolicies *))decisionHandler
+IGNORE_WARNINGS_END
{
_WKWebsitePolicies *websitePolicies = [[[_WKWebsitePolicies alloc] init] autorelease];
[websitePolicies setCustomHeaderFields:@{@"X-key1": @"value1", @"X-key2": @"value2"}];
@@ -919,7 +921,9 @@
@implementation WebsitePoliciesWebsiteDataStoreDelegate
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)_webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy, _WKWebsitePolicies *))decisionHandler
+IGNORE_WARNINGS_END
{
NSURL *url = ""
if ([url.path isEqualToString:@"/invalid"]) {
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -46,7 +46,9 @@
@end
@implementation AudioSessionCategoryUIWebViewDelegate
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)request navigationType:(UIWebViewNavigationType)navigationType
+IGNORE_WARNINGS_END
{
if ([request.URL.scheme isEqualToString:@"callback"] && [request.URL.resourceSpecifier isEqualToString:@"playing"]) {
didBeginPlaying = true;
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -40,12 +40,16 @@
@implementation RenderInContextWebViewDelegate
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)webViewDidFinishLoad:(UIWebView *)webView
+IGNORE_WARNINGS_END
{
loadComplete = true;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)webView:(UIWebView *)webView didFailLoadWithError:(NSError *)error
+IGNORE_WARNINGS_END
{
loadComplete = true;
loadFailed = true;
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -41,18 +41,24 @@
@implementation SetTimeoutFunctionWebViewDelegate
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)webViewDidFinishLoad:(UIWebView *)webView
+IGNORE_WARNINGS_END
{
loadComplete = true;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)webView:(UIWebView *)webView didFailLoadWithError:(NSError *)error
+IGNORE_WARNINGS_END
{
loadComplete = true;
loadFailed = true;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)request navigationType:(UIWebViewNavigationType)navigationType
+IGNORE_WARNINGS_END
{
NSString *prefix = @"fired-";
NSString *queryString = request.URL.query;
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -155,7 +155,9 @@
{
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
+IGNORE_WARNINGS_END
{
return nil;
}
Modified: trunk/Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -56,7 +56,9 @@
return self;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)dragImage:(NSImage *)image at:(NSPoint)viewLocation offset:(NSSize)initialOffset event:(NSEvent *)event pasteboard:(NSPasteboard *)pboard source:(id)sourceObj slideBack:(BOOL)slideFlag
+IGNORE_WARNINGS_END
{
[_dragAndDropSimulator performDragInWebView:self atLocation:viewLocation withImage:image pasteboard:pboard source:sourceObj];
}
Modified: trunk/Tools/TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m 2018-10-08 13:55:14 UTC (rev 236913)
@@ -51,7 +51,9 @@
return _backingScaleFactor;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (CGFloat)userSpaceScaleFactor
+IGNORE_WARNINGS_END
{
return _backingScaleFactor;
}
Modified: trunk/Tools/TestWebKitAPI/mac/TestDraggingInfo.mm (236912 => 236913)
--- trunk/Tools/TestWebKitAPI/mac/TestDraggingInfo.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/TestWebKitAPI/mac/TestDraggingInfo.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -150,7 +150,9 @@
{
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray<NSString *> *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
+IGNORE_WARNINGS_END
{
return @[ ];
}
Modified: trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig (236912 => 236913)
--- trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2018-10-08 13:55:14 UTC (rev 236913)
@@ -31,14 +31,29 @@
CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
CLANG_CXX_LIBRARY = libc++;
CLANG_ENABLE_OBJC_WEAK = YES;
+ENABLE_STRICT_OBJC_MSGSEND = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
+CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_COMMA = YES;
+CLANG_WARN_CONSTANT_CONVERSION = YES;
+CLANG_WARN_EMPTY_BODY = YES;
+CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_INFINITE_RECURSION = YES;
+CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
+CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
+GCC_WARN_UNDECLARED_SELECTOR = YES;
+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
+CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
+CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport $(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport;
+GCC_NO_COMMON_BLOCKS = YES;
GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) U_DISABLE_RENAMING=1 U_SHOW_CPLUSPLUS_API=0 ENABLE_DASHBOARD_SUPPORT;
DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
PREBINDING = NO
@@ -49,6 +64,8 @@
GCC_TREAT_WARNINGS_AS_ERRORS = YES
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
+GCC_WARN_ABOUT_RETURN_TYPE = YES;
+GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES
GCC_WARN_UNUSED_VARIABLE = YES
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;
Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj (236912 => 236913)
--- trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2018-10-08 13:55:14 UTC (rev 236913)
@@ -941,6 +941,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0700;
+ LastUpgradeCheck = 1000;
TargetAttributes = {
A115CCB41B9D769D00E89159 = {
CreatedOnToolsVersion = 7.0;
Modified: trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm (236912 => 236913)
--- trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -61,7 +61,9 @@
@implementation TestRunnerWKWebView
#if PLATFORM(MAC)
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)dragImage:(NSImage *)anImage at:(NSPoint)viewLocation offset:(NSSize)initialOffset event:(NSEvent *)event pasteboard:(NSPasteboard *)pboard source:(id)sourceObj slideBack:(BOOL)slideFlag
+IGNORE_WARNINGS_END
{
RetainPtr<WebKitTestRunnerDraggingInfo> draggingInfo = adoptNS([[WebKitTestRunnerDraggingInfo alloc] initWithImage:anImage offset:initialOffset pasteboard:pboard source:sourceObj]);
[self draggingUpdated:draggingInfo.get()];
Modified: trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm (236912 => 236913)
--- trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm 2018-10-08 13:25:02 UTC (rev 236912)
+++ trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm 2018-10-08 13:55:14 UTC (rev 236913)
@@ -78,11 +78,8 @@
void UIScriptController::replaceTextAtRange(JSStringRef text, int location, int length)
{
#if WK_API_ENABLED
- if (location == -1)
- location = NSNotFound;
-
auto* webView = TestController::singleton().mainWebView()->platformView();
- [webView _insertText:nsString(text) replacementRange:NSMakeRange(location, length)];
+ [webView _insertText:nsString(text) replacementRange:NSMakeRange(location == -1 ? NSNotFound : location, length)];
#else
UNUSED_PARAM(text);
UNUSED_PARAM(location);
