Title: [236923] trunk/Source/WebInspectorUI
- Revision
- 236923
- Author
- drou...@apple.com
- Date
- 2018-10-08 10:24:15 -0700 (Mon, 08 Oct 2018)
Log Message
Web Inspector: clicking initiator link in Network Tab table doesn't automatically switch to Preview section
https://bugs.webkit.org/show_bug.cgi?id=190286
Reviewed by Brian Burg.
* UserInterface/Views/NetworkResourceDetailView.js:
(WI.NetworkResourceDetailView.prototype.shown):
(WI.NetworkResourceDetailView.prototype._showContentViewForNavigationItem):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236922 => 236923)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:22:18 UTC (rev 236922)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:24:15 UTC (rev 236923)
@@ -1,5 +1,16 @@
2018-10-08 Devin Rousso <drou...@apple.com>
+ Web Inspector: clicking initiator link in Network Tab table doesn't automatically switch to Preview section
+ https://bugs.webkit.org/show_bug.cgi?id=190286
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/NetworkResourceDetailView.js:
+ (WI.NetworkResourceDetailView.prototype.shown):
+ (WI.NetworkResourceDetailView.prototype._showContentViewForNavigationItem):
+
+2018-10-08 Devin Rousso <drou...@apple.com>
+
Web Inspector: be more specific as to what types of WI.Collection are allowed for the Resources tab
https://bugs.webkit.org/show_bug.cgi?id=190304
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js (236922 => 236923)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js 2018-10-08 17:22:18 UTC (rev 236922)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js 2018-10-08 17:24:15 UTC (rev 236923)
@@ -58,6 +58,9 @@
this._showPreferredContentView();
if (this._contentViewCookie) {
+ if ("lineNumber" in this._contentViewCookie && "columnNumber" in this._contentViewCookie)
+ this._contentBrowser.navigationBar.selectedNavigationItem = this._previewNavigationItem;
+
this._contentBrowser.showContentView(this._contentBrowser.currentContentView, this._contentViewCookie);
this._contentViewCookie = null;
}
@@ -183,7 +186,11 @@
_showContentViewForNavigationItem(navigationItem)
{
- switch (navigationItem.identifier) {
+ let identifier = navigationItem.identifier;
+ if (this._contentViewCookie && "lineNumber" in this._contentViewCookie && "columnNumber" in this._contentViewCookie)
+ identifier = this._previewNavigationItem.identifier;
+
+ switch (identifier) {
case "preview":
if (!this._resourceContentView)
this._resourceContentView = this._contentBrowser.showContentViewForRepresentedObject(this._resource);
@@ -210,6 +217,8 @@
this._contentBrowser.showContentView(this._timingContentView, this._contentViewCookie);
break;
}
+
+ this._contentViewCookie = null;
}
_navigationItemSelected(event)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
