Title: [236945] trunk
- Revision
- 236945
- Author
- d...@apple.com
- Date
- 2018-10-08 16:19:25 -0700 (Mon, 08 Oct 2018)
Log Message
CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
https://bugs.webkit.org/show_bug.cgi?id=190376
<rdar://problem/44986520>
Reviewed by Tim Horton.
Source/WebCore:
Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
depth from 256 to 128.
Modified existing test: compositing/layer-creation/deep-tree.html
* platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
LayoutTests:
* compositing/layer-creation/deep-tree.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (236944 => 236945)
--- trunk/LayoutTests/ChangeLog 2018-10-08 22:34:58 UTC (rev 236944)
+++ trunk/LayoutTests/ChangeLog 2018-10-08 23:19:25 UTC (rev 236945)
@@ -1,3 +1,13 @@
+2018-10-08 Dean Jackson <d...@apple.com>
+
+ CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+ https://bugs.webkit.org/show_bug.cgi?id=190376
+ <rdar://problem/44986520>
+
+ Reviewed by Tim Horton.
+
+ * compositing/layer-creation/deep-tree.html:
+
2018-10-08 Aditya Keerthi <akeer...@apple.com>
Make <input type=color> a runtime enabled (on-by-default) feature
Modified: trunk/LayoutTests/compositing/layer-creation/deep-tree.html (236944 => 236945)
--- trunk/LayoutTests/compositing/layer-creation/deep-tree.html 2018-10-08 22:34:58 UTC (rev 236944)
+++ trunk/LayoutTests/compositing/layer-creation/deep-tree.html 2018-10-08 23:19:25 UTC (rev 236945)
@@ -33,7 +33,7 @@
function doTest()
{
- makeDeepTree(500, document.getElementById('deep'));
+ makeDeepTree(129, document.getElementById('deep'));
}
window.addEventListener('load', doTest, false);
Modified: trunk/Source/WebCore/ChangeLog (236944 => 236945)
--- trunk/Source/WebCore/ChangeLog 2018-10-08 22:34:58 UTC (rev 236944)
+++ trunk/Source/WebCore/ChangeLog 2018-10-08 23:19:25 UTC (rev 236945)
@@ -1,3 +1,18 @@
+2018-10-08 Dean Jackson <d...@apple.com>
+
+ CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+ https://bugs.webkit.org/show_bug.cgi?id=190376
+ <rdar://problem/44986520>
+
+ Reviewed by Tim Horton.
+
+ Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+ depth from 256 to 128.
+
+ Modified existing test: compositing/layer-creation/deep-tree.html
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+
2018-10-08 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r236941.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (236944 => 236945)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2018-10-08 22:34:58 UTC (rev 236944)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2018-10-08 23:19:25 UTC (rev 236945)
@@ -89,7 +89,7 @@
#endif
// Derived empirically: <rdar://problem/13401861>
-static const unsigned cMaxLayerTreeDepth = 250;
+static const unsigned cMaxLayerTreeDepth = 128;
// About 10 screens of an iPhone 6 Plus. <rdar://problem/44532782>
static const unsigned cMaxTotalBackdropFilterArea = 1242 * 2208 * 10;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
