Diff
Modified: trunk/Source/WebCore/ChangeLog (238377 => 238378)
--- trunk/Source/WebCore/ChangeLog 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebCore/ChangeLog 2018-11-19 20:51:40 UTC (rev 238378)
@@ -1,3 +1,21 @@
+2018-11-19 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: "Reload Web Inspector" button no longer partially works
+ https://bugs.webkit.org/show_bug.cgi?id=191773
+ <rdar://problem/46139932>
+
+ Reviewed by Devin Rousso.
+
+ * inspector/InspectorFrontendClient.h:
+ * inspector/InspectorFrontendHost.cpp:
+ (WebCore::InspectorFrontendHost::reopen):
+ * inspector/InspectorFrontendHost.h:
+ * inspector/InspectorFrontendHost.idl:
+ Provide a host call to reopen an inspector window to reload it.
+
+ * testing/Internals.cpp:
+ Stub implementation, this is not used in tests.
+
2018-11-19 Rob Buis <rb...@igalia.com>
Setting document.title should have no effect for non SVG/HTML documents
Modified: trunk/Source/WebCore/inspector/InspectorFrontendClient.h (238377 => 238378)
--- trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2018-11-19 20:51:40 UTC (rev 238378)
@@ -61,6 +61,7 @@
virtual void bringToFront() = 0;
virtual void closeWindow() = 0;
+ virtual void reopen() = 0;
virtual UserInterfaceLayoutDirection userInterfaceLayoutDirection() const = 0;
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (238377 => 238378)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2018-11-19 20:51:40 UTC (rev 238378)
@@ -190,6 +190,12 @@
}
}
+void InspectorFrontendHost::reopen()
+{
+ if (m_client)
+ m_client->reopen();
+}
+
void InspectorFrontendHost::bringToFront()
{
if (m_client)
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (238377 => 238378)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2018-11-19 20:51:40 UTC (rev 238378)
@@ -57,6 +57,7 @@
void loaded();
void requestSetDockSide(const String&);
void closeWindow();
+ void reopen();
void bringToFront();
void inspectedURLChanged(const String&);
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (238377 => 238378)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2018-11-19 20:51:40 UTC (rev 238378)
@@ -36,6 +36,7 @@
] interface InspectorFrontendHost {
void loaded();
void closeWindow();
+ void reopen();
void bringToFront();
void inspectedURLChanged(DOMString newURL);
Modified: trunk/Source/WebCore/testing/Internals.cpp (238377 => 238378)
--- trunk/Source/WebCore/testing/Internals.cpp 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebCore/testing/Internals.cpp 2018-11-19 20:51:40 UTC (rev 238378)
@@ -307,6 +307,7 @@
void attachWindow(DockSide) final { }
void detachWindow() final { }
void closeWindow() final;
+ void reopen() final { }
void bringToFront() final { }
String localizedStringsURL() final { return String(); }
void inspectedURLChanged(const String&) final { }
Modified: trunk/Source/WebInspectorUI/ChangeLog (238377 => 238378)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-19 20:51:40 UTC (rev 238378)
@@ -1,3 +1,16 @@
+2018-11-19 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: "Reload Web Inspector" button no longer partially works
+ https://bugs.webkit.org/show_bug.cgi?id=191773
+ <rdar://problem/46139932>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Base/Main.js:
+ * UserInterface/Debug/UncaughtExceptionReporter.js:
+ (sheetElement.innerHTML):
+ * UserInterface/Views/SettingsTabContentView.js:
+
2018-11-17 Devin Rousso <drou...@apple.com>
Web Inspector: Network: add button to show system certificate dialog
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (238377 => 238378)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-11-19 20:51:40 UTC (rev 238378)
@@ -1584,8 +1584,7 @@
proposedContextMenu = WI.ContextMenu.createFromEvent(event);
proposedContextMenu.appendSeparator();
proposedContextMenu.appendItem(WI.unlocalizedString("Reload Web Inspector"), () => {
- // FIXME: Reload Web Inspector does not work with MultiplexingBackendTarget.
- window.location.reload();
+ InspectorFrontendHost.reopen();
});
let protocolSubMenu = proposedContextMenu.appendSubMenuItem(WI.unlocalizedString("Protocol Debugging"), null, false);
@@ -2253,8 +2252,7 @@
if (WI.resolvedLayoutDirection() === WI.LayoutDirection.LTR && this._dockConfiguration === WI.DockConfiguration.Left)
this._dockRight();
- // FIXME: Reload Web Inspector does not work with MultiplexingBackendTarget.
- window.location.reload();
+ InspectorFrontendHost.reopen();
};
WI._showTabAtIndex = function(i, event)
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js (238377 => 238378)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js 2018-11-19 20:51:40 UTC (rev 238378)
@@ -36,7 +36,7 @@
// Reload the Web Inspector.
new WI.KeyboardShortcut(WI.KeyboardShortcut.Modifier.Option | WI.KeyboardShortcut.Modifier.Shift | WI.KeyboardShortcut.Modifier.CommandOrControl, "R", () => {
- window.location.reload();
+ InspectorFrontendHost.reopen();
});
// Toggle Inspector Messages Filtering.
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js (238377 => 238378)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js 2018-11-19 20:51:40 UTC (rev 238378)
@@ -257,7 +257,6 @@
<dd><a class="bypass-event-blocking" id="dismiss-error-sheet">Click to close this view</a> and return
to the Web Inspector without reloading. However, some things might not work without reloading if the error corrupted the Inspector's internal state.</dd>`;
- // FIXME: Reload Web Inspector does not work with MultiplexingBackendTarget.
let sheetElement = window.__sheetElement = document.createElement("div");
sheetElement.classList.add("sheet-container");
sheetElement.innerHTML = `<div class="uncaught-exception-sheet">
@@ -273,7 +272,7 @@
<a href="" target="_blank">click to file a pre-populated
bug with this information</a>. It is possible that someone else broke it by accident.</dd>
<dt>Oops, can I try again?</dt>
- <dd><a href="" to reload the Inspector</a>
+ <dd><a href="" to reload the Inspector</a>
again after making local changes.</dd>
${dismissOptionHTML}
</dl>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (238377 => 238378)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2018-11-19 20:51:40 UTC (rev 238378)
@@ -258,10 +258,9 @@
experimentalSettingsView.addSetting(WI.UIString("User Interface:"), WI.settings.experimentalEnableNewTabBar, WI.UIString("Enable New Tab Bar"));
experimentalSettingsView.addSeparator();
- // FIXME: Reload Web Inspector does not work with MultiplexingBackendTarget.
let reloadInspectorButton = document.createElement("button");
reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
- reloadInspectorButton.addEventListener("click", () => { window.location.reload(); });
+ reloadInspectorButton.addEventListener("click", () => { InspectorFrontendHost.reopen(); });
let reloadInspectorContainerElement = experimentalSettingsView.addCenteredContainer(reloadInspectorButton, WI.UIString("for changes to take effect"));
reloadInspectorContainerElement.classList.add("hidden");
Modified: trunk/Source/WebKit/ChangeLog (238377 => 238378)
--- trunk/Source/WebKit/ChangeLog 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/ChangeLog 2018-11-19 20:51:40 UTC (rev 238378)
@@ -1,3 +1,27 @@
+2018-11-19 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: "Reload Web Inspector" button no longer partially works
+ https://bugs.webkit.org/show_bug.cgi?id=191773
+ <rdar://problem/46139932>
+
+ Reviewed by Devin Rousso.
+
+ * UIProcess/RemoteWebInspectorProxy.cpp:
+ (WebKit::RemoteWebInspectorProxy::load):
+ (WebKit::RemoteWebInspectorProxy::reopen):
+ * UIProcess/RemoteWebInspectorProxy.h:
+ * UIProcess/RemoteWebInspectorProxy.messages.in:
+ * WebProcess/WebPage/RemoteWebInspectorUI.cpp:
+ (WebKit::RemoteWebInspectorUI::reopen):
+ * WebProcess/WebPage/RemoteWebInspectorUI.h:
+ * WebProcess/WebPage/WebInspector.cpp:
+ (WebKit::WebInspector::reopen):
+ * WebProcess/WebPage/WebInspector.h:
+ * WebProcess/WebPage/WebInspector.messages.in:
+ * WebProcess/WebPage/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::reopen):
+ * WebProcess/WebPage/WebInspectorUI.h:
+
2018-11-19 Alejandro G. Castro <a...@igalia.com>
[GTK][WPE] Solve some issues in the enumerateDevices code
Modified: trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp (238377 => 238378)
--- trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp 2018-11-19 20:51:40 UTC (rev 238378)
@@ -56,6 +56,9 @@
{
createFrontendPageAndWindow();
+ m_debuggableType = debuggableType;
+ m_backendCommandsURL = backendCommandsURL;
+
m_inspectorPage->process().send(Messages::RemoteWebInspectorUI::Initialize(debuggableType, backendCommandsURL), m_inspectorPage->pageID());
m_inspectorPage->loadRequest(URL(URL(), WebInspectorProxy::inspectorPageURL()));
}
@@ -91,6 +94,14 @@
closeFrontendPageAndWindow();
}
+void RemoteWebInspectorProxy::reopen()
+{
+ ASSERT(!m_debuggableType.isEmpty());
+
+ closeFrontendPageAndWindow();
+ load(m_debuggableType, m_backendCommandsURL);
+}
+
void RemoteWebInspectorProxy::bringToFront()
{
platformBringToFront();
Modified: trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.h (238377 => 238378)
--- trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.h 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.h 2018-11-19 20:51:40 UTC (rev 238378)
@@ -95,6 +95,7 @@
// RemoteWebInspectorProxy messages.
void frontendDidClose();
+ void reopen();
void bringToFront();
void save(const String& filename, const String& content, bool base64Encoded, bool forceSaveAs);
void append(const String& filename, const String& content);
@@ -119,6 +120,9 @@
RemoteWebInspectorProxyClient* m_client { nullptr };
WebPageProxy* m_inspectorPage { nullptr };
+ String m_debuggableType;
+ String m_backendCommandsURL;
+
#if PLATFORM(MAC)
RetainPtr<WKInspectorViewController> m_inspectorView;
RetainPtr<NSWindow> m_window;
Modified: trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.messages.in (238377 => 238378)
--- trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.messages.in 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.messages.in 2018-11-19 20:51:40 UTC (rev 238378)
@@ -22,6 +22,7 @@
messages -> RemoteWebInspectorProxy {
FrontendDidClose()
+ Reopen()
BringToFront()
Save(String filename, String content, bool base64Encoded, bool forceSaveAs)
Modified: trunk/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp (238377 => 238378)
--- trunk/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp 2018-11-19 20:51:40 UTC (rev 238378)
@@ -128,6 +128,11 @@
WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorProxy::FrontendDidClose(), m_page.pageID());
}
+void RemoteWebInspectorUI::reopen()
+{
+ WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorProxy::Reopen(), m_page.pageID());
+}
+
void RemoteWebInspectorUI::openInNewTab(const String& url)
{
WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorProxy::OpenInNewTab(url), m_page.pageID());
Modified: trunk/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h (238377 => 238378)
--- trunk/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h 2018-11-19 20:51:40 UTC (rev 238378)
@@ -66,6 +66,7 @@
void bringToFront() override;
void closeWindow() override;
+ void reopen() override;
void openInNewTab(const String& url) override;
void save(const String& url, const String& content, bool base64Encoded, bool forceSaveAs) override;
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebInspector.cpp (238377 => 238378)
--- trunk/Source/WebKit/WebProcess/WebPage/WebInspector.cpp 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebInspector.cpp 2018-11-19 20:51:40 UTC (rev 238378)
@@ -142,6 +142,12 @@
closeFrontendConnection();
}
+void WebInspector::reopen()
+{
+ close();
+ show();
+}
+
void WebInspector::openInNewTab(const String& urlString)
{
UserGestureIndicator indicator { ProcessingUserGesture };
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebInspector.h (238377 => 238378)
--- trunk/Source/WebKit/WebProcess/WebPage/WebInspector.h 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebInspector.h 2018-11-19 20:51:40 UTC (rev 238378)
@@ -52,6 +52,7 @@
void show();
void close();
+ void reopen();
void openInNewTab(const String& urlString);
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebInspector.messages.in (238377 => 238378)
--- trunk/Source/WebKit/WebProcess/WebPage/WebInspector.messages.in 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebInspector.messages.in 2018-11-19 20:51:40 UTC (rev 238378)
@@ -23,6 +23,7 @@
messages -> WebInspector {
Show()
Close()
+ Reopen()
SetAttached(bool attached)
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp (238377 => 238378)
--- trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp 2018-11-19 20:51:40 UTC (rev 238378)
@@ -167,6 +167,12 @@
m_underTest = false;
}
+void WebInspectorUI::reopen()
+{
+ if (m_backendConnection)
+ m_backendConnection->send(Messages::WebInspector::Reopen(), 0);
+}
+
WebCore::UserInterfaceLayoutDirection WebInspectorUI::userInterfaceLayoutDirection() const
{
return m_page.corePage()->userInterfaceLayoutDirection();
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.h (238377 => 238378)
--- trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.h 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.h 2018-11-19 20:51:40 UTC (rev 238378)
@@ -92,6 +92,7 @@
void bringToFront() override;
void closeWindow() override;
+ void reopen() override;
WebCore::UserInterfaceLayoutDirection userInterfaceLayoutDirection() const override;
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (238377 => 238378)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2018-11-19 20:51:40 UTC (rev 238378)
@@ -1,3 +1,14 @@
+2018-11-19 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: "Reload Web Inspector" button no longer partially works
+ https://bugs.webkit.org/show_bug.cgi?id=191773
+ <rdar://problem/46139932>
+
+ Reviewed by Devin Rousso.
+
+ * WebCoreSupport/WebInspectorClientIOS.mm:
+ (WebInspectorFrontendClient::reopen):
+
2018-10-18 Alexey Proskuryakov <a...@apple.com>
Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm (238377 => 238378)
--- trunk/Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm 2018-11-19 20:51:40 UTC (rev 238378)
@@ -125,6 +125,7 @@
String WebInspectorFrontendClient::localizedStringsURL() { return String(); }
void WebInspectorFrontendClient::bringToFront() { }
void WebInspectorFrontendClient::closeWindow() { }
+void WebInspectorFrontendClient::reopen() { }
void WebInspectorFrontendClient::attachWindow(DockSide) { }
void WebInspectorFrontendClient::detachWindow() { }
void WebInspectorFrontendClient::setAttachedWindowHeight(unsigned) { }
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (238377 => 238378)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-11-19 20:51:40 UTC (rev 238378)
@@ -1,3 +1,15 @@
+2018-11-19 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: "Reload Web Inspector" button no longer partially works
+ https://bugs.webkit.org/show_bug.cgi?id=191773
+ <rdar://problem/46139932>
+
+ Reviewed by Devin Rousso.
+
+ * WebCoreSupport/WebInspectorClient.h:
+ * WebCoreSupport/WebInspectorClient.mm:
+ (WebInspectorFrontendClient::reopen):
+
2018-11-17 Devin Rousso <drou...@apple.com>
Web Inspector: Network: add button to show system certificate dialog
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h (238377 => 238378)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h 2018-11-19 20:51:40 UTC (rev 238378)
@@ -117,6 +117,7 @@
void bringToFront() override;
void closeWindow() override;
+ void reopen() override;
void attachWindow(DockSide) override;
void detachWindow() override;
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm (238377 => 238378)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm 2018-11-19 20:51:40 UTC (rev 238378)
@@ -250,6 +250,13 @@
[m_frontendWindowController.get() destroyInspectorView];
}
+void WebInspectorFrontendClient::reopen()
+{
+ WebInspector* inspector = [m_inspectedWebView inspector];
+ [inspector close:nil];
+ [inspector show:nil];
+}
+
void WebInspectorFrontendClient::attachWindow(DockSide)
{
if ([m_frontendWindowController.get() attached])
@@ -691,8 +698,7 @@
return;
_destroyingInspectorView = YES;
- if (_attachedToInspectedWebView)
- [self close];
+ [self close];
_visible = NO;
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (238377 => 238378)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-19 20:51:40 UTC (rev 238378)
@@ -1,3 +1,15 @@
+2018-11-19 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: "Reload Web Inspector" button no longer partially works
+ https://bugs.webkit.org/show_bug.cgi?id=191773
+ <rdar://problem/46139932>
+
+ Reviewed by Devin Rousso.
+
+ * WebCoreSupport/WebInspectorClient.cpp:
+ (WebInspectorFrontendClient::reopen):
+ * WebCoreSupport/WebInspectorClient.h:
+
2018-11-17 Devin Rousso <drou...@apple.com>
Web Inspector: Network: add button to show system certificate dialog
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp (238377 => 238378)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp 2018-11-19 20:51:40 UTC (rev 238378)
@@ -270,6 +270,14 @@
destroyInspectorView();
}
+void WebInspectorFrontendClient::reopen()
+{
+ destroyInspectorView();
+
+ if (Page* inspectedPage = m_inspectedWebView->page())
+ inspectedPage->inspectorController().show();
+}
+
void WebInspectorFrontendClient::attachWindow(DockSide)
{
if (m_attached)
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h (238377 => 238378)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h 2018-11-19 20:42:53 UTC (rev 238377)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h 2018-11-19 20:51:40 UTC (rev 238378)
@@ -103,6 +103,7 @@
void bringToFront() override;
void closeWindow() override;
+ void reopen() override;
void setAttachedWindowHeight(unsigned) override;
void setAttachedWindowWidth(unsigned) override;
