Title: [238455] trunk/Source/WebKit
- Revision
- 238455
- Author
- wenson_hs...@apple.com
- Date
- 2018-11-22 20:00:31 -0800 (Thu, 22 Nov 2018)
Log Message
[Cocoa] clang emits a warning when building WebKit after r238293
https://bugs.webkit.org/show_bug.cgi?id=191917
Reviewed by Dan Bernstein.
Move the implementations of -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled to the main implementation of
WKPreferences to fix the warning.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences setSafeBrowsingEnabled:]):
(-[WKPreferences isSafeBrowsingEnabled]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (238454 => 238455)
--- trunk/Source/WebKit/ChangeLog 2018-11-23 03:10:34 UTC (rev 238454)
+++ trunk/Source/WebKit/ChangeLog 2018-11-23 04:00:31 UTC (rev 238455)
@@ -1,5 +1,19 @@
2018-11-22 Wenson Hsieh <wenson_hs...@apple.com>
+ [Cocoa] clang emits a warning when building WebKit after r238293
+ https://bugs.webkit.org/show_bug.cgi?id=191917
+
+ Reviewed by Dan Bernstein.
+
+ Move the implementations of -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled to the main implementation of
+ WKPreferences to fix the warning.
+
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences setSafeBrowsingEnabled:]):
+ (-[WKPreferences isSafeBrowsingEnabled]):
+
+2018-11-22 Wenson Hsieh <wenson_hs...@apple.com>
+
Address post-review feedback after r238438
https://bugs.webkit.org/show_bug.cgi?id=191913
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (238454 => 238455)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-11-23 03:10:34 UTC (rev 238454)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-11-23 04:00:31 UTC (rev 238455)
@@ -140,6 +140,16 @@
_preferences->setStorageAccessPromptsEnabled(enabled);
}
+- (void)setSafeBrowsingEnabled:(BOOL)enabled
+{
+ _preferences->setSafeBrowsingEnabled(enabled);
+}
+
+- (BOOL)isSafeBrowsingEnabled
+{
+ return _preferences->safeBrowsingEnabled();
+}
+
#pragma mark OS X-specific methods
#if PLATFORM(MAC)
@@ -697,16 +707,6 @@
_preferences->setICECandidateFilteringEnabled(enabled);
}
-- (void)setSafeBrowsingEnabled:(BOOL)enabled
-{
- _preferences->setSafeBrowsingEnabled(enabled);
-}
-
-- (BOOL)isSafeBrowsingEnabled
-{
- return _preferences->safeBrowsingEnabled();
-}
-
- (BOOL)_webRTCLegacyAPIEnabled
{
return NO;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
