- Revision
- 238473
- Author
- wenson_hs...@apple.com
- Date
- 2018-11-24 17:45:54 -0800 (Sat, 24 Nov 2018)
Log Message
[Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
https://bugs.webkit.org/show_bug.cgi?id=191945
Reviewed by Anders Carlsson.
Source/WebCore:
Run `update-webkit-localizable-strings`.
* en.lproj/Localizable.strings:
Source/WebKit:
Replace some a couple of command undo action name descriptions with "Undo action name", to match all other
edit commands.
* UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::nameForEditAction):
Source/WebKitLegacy/mac:
* WebCoreSupport/WebEditorClient.mm:
(undoNameForEditAction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (238472 => 238473)
--- trunk/Source/WebCore/ChangeLog 2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebCore/ChangeLog 2018-11-25 01:45:54 UTC (rev 238473)
@@ -1,3 +1,14 @@
+2018-11-24 Wenson Hsieh <wenson_hs...@apple.com>
+
+ [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
+ https://bugs.webkit.org/show_bug.cgi?id=191945
+
+ Reviewed by Anders Carlsson.
+
+ Run `update-webkit-localizable-strings`.
+
+ * en.lproj/Localizable.strings:
+
2018-11-24 Sam Weinig <s...@webkit.org>
Remove now unnecessary specialized ListHashSet from InlineItem.h
Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (238472 => 238473)
--- trunk/Source/WebCore/en.lproj/Localizable.strings 2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebCore/en.lproj/Localizable.strings 2018-11-25 01:45:54 UTC (rev 238473)
@@ -187,10 +187,10 @@
/* Media Controls context menu item */
"Controls" = "Controls";
-/* Convert to ordered list action name */
+/* Undo action name */
"Convert to Ordered List (Undo action name)" = "Convert to Ordered List";
-/* Convert to unordered list action name */
+/* Undo action name */
"Convert to Unordered List (Undo action name)" = "Convert to Unordered List";
/* Copy context menu item */
@@ -595,12 +595,12 @@
/* Search in Spotlight context menu item */
"Search in Spotlight" = "Search in Spotlight";
+/* Search the Web context menu item */
+"Search the Web" = "Search the Web";
+
/* Search with search provider context menu item with provider name inserted */
"Search with %@" = "Search with %@";
-/* Search the Web context menu item */
-"Search the Web" = "Search the Web";
-
/* Validation message for required file inputs that have no value */
"Select a file" = "Select a file";
@@ -820,6 +820,9 @@
/* accessibility role description for a URL field. */
"URL field" = "URL field";
+/* Unacceptable TLS certificate error */
+"Unacceptable TLS certificate" = "Unacceptable TLS certificate";
+
/* Underline context menu item */
"Underline" = "Underline";
Modified: trunk/Source/WebKit/ChangeLog (238472 => 238473)
--- trunk/Source/WebKit/ChangeLog 2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebKit/ChangeLog 2018-11-25 01:45:54 UTC (rev 238473)
@@ -1,5 +1,18 @@
2018-11-24 Wenson Hsieh <wenson_hs...@apple.com>
+ [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
+ https://bugs.webkit.org/show_bug.cgi?id=191945
+
+ Reviewed by Anders Carlsson.
+
+ Replace some a couple of command undo action name descriptions with "Undo action name", to match all other
+ edit commands.
+
+ * UIProcess/WebEditCommandProxy.cpp:
+ (WebKit::WebEditCommandProxy::nameForEditAction):
+
+2018-11-24 Wenson Hsieh <wenson_hs...@apple.com>
+
[Cocoa] Add WKWebView SPI to trigger and remove data detection
https://bugs.webkit.org/show_bug.cgi?id=191918
<rdar://problem/36185051>
Modified: trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp (238472 => 238473)
--- trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp 2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp 2018-11-25 01:45:54 UTC (rev 238473)
@@ -174,9 +174,9 @@
// FIXME: We should give internal clients a way to override these undo names. For instance, Mail refers to ordered and unordered lists as "numbered" and "bulleted" lists, respectively,
// despite the fact that ordered and unordered lists are not necessarily displayed using bullets and numerals.
case EditAction::ConvertToOrderedList:
- return WEB_UI_STRING_KEY("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Convert to ordered list action name");
+ return WEB_UI_STRING_KEY("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Undo action name");
case EditAction::ConvertToUnorderedList:
- return WEB_UI_STRING_KEY("Convert to Unordered List", "Convert to Unordered List (Undo action name)", "Convert to unordered list action name");
+ return WEB_UI_STRING_KEY("Convert to Unordered List", "Convert to Unordered List (Undo action name)", "Undo action name");
}
return String();
}
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (238472 => 238473)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-11-25 01:45:54 UTC (rev 238473)
@@ -1,3 +1,13 @@
+2018-11-24 Wenson Hsieh <wenson_hs...@apple.com>
+
+ [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
+ https://bugs.webkit.org/show_bug.cgi?id=191945
+
+ Reviewed by Anders Carlsson.
+
+ * WebCoreSupport/WebEditorClient.mm:
+ (undoNameForEditAction):
+
2018-11-23 Wenson Hsieh <wenson_hs...@apple.com>
Enable drag and drop support for iOSMac
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm (238472 => 238473)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm 2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm 2018-11-25 01:45:54 UTC (rev 238473)
@@ -653,8 +653,8 @@
case EditAction::Italics: return UI_STRING_KEY_INTERNAL("Italics", "Italics (Undo action name)", "Undo action name");
case EditAction::Delete: return UI_STRING_KEY_INTERNAL("Delete", "Delete (Undo action name)", "Undo action name");
case EditAction::Dictation: return UI_STRING_KEY_INTERNAL("Dictation", "Dictation (Undo action name)", "Undo action name");
- case EditAction::ConvertToOrderedList: return UI_STRING_KEY_INTERNAL("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Convert to ordered list action name");
- case EditAction::ConvertToUnorderedList: return UI_STRING_KEY_INTERNAL("Convert to Unordered List", "Convert to Unordered List (Undo action name)", "Convert to unordered list action name");
+ case EditAction::ConvertToOrderedList: return UI_STRING_KEY_INTERNAL("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Undo action name");
+ case EditAction::ConvertToUnorderedList: return UI_STRING_KEY_INTERNAL("Convert to Unordered List", "Convert to Unordered List (Undo action name)", "Undo action name");
}
return nil;
}
