Title: [238650] trunk/Source
- Revision
- 238650
- Author
- mark....@apple.com
- Date
- 2018-11-28 17:22:19 -0800 (Wed, 28 Nov 2018)
Log Message
ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
https://bugs.webkit.org/show_bug.cgi?id=192110
<rdar://problem/46317746>
Reviewed by Saam Barati.
Source/_javascript_Core:
* config.h:
Source/WTF:
Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
defined in Platform.h because it is also needed in WebCore for the CSS JIT. Also
contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
(and other projects) as well as JSC. Hence, there's no reason why
ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.
* wtf/Platform.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (238649 => 238650)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-29 01:11:10 UTC (rev 238649)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-29 01:22:19 UTC (rev 238650)
@@ -1,3 +1,13 @@
+2018-11-28 Mark Lam <mark....@apple.com>
+
+ ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
+ https://bugs.webkit.org/show_bug.cgi?id=192110
+ <rdar://problem/46317746>
+
+ Reviewed by Saam Barati.
+
+ * config.h:
+
2018-11-28 Keith Rollin <krol...@apple.com>
Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files
Modified: trunk/Source/_javascript_Core/config.h (238649 => 238650)
--- trunk/Source/_javascript_Core/config.h 2018-11-29 01:11:10 UTC (rev 238649)
+++ trunk/Source/_javascript_Core/config.h 2018-11-29 01:22:19 UTC (rev 238650)
@@ -37,11 +37,3 @@
#endif
#include <wtf/DisallowCType.h>
-
-#if !defined(ENABLE_SEPARATED_WX_HEAP)
-#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
-#define ENABLE_SEPARATED_WX_HEAP 1
-#else
-#define ENABLE_SEPARATED_WX_HEAP 0
-#endif
-#endif // !defined(ENABLE_SEPARATED_WX_HEAP)
Modified: trunk/Source/WTF/ChangeLog (238649 => 238650)
--- trunk/Source/WTF/ChangeLog 2018-11-29 01:11:10 UTC (rev 238649)
+++ trunk/Source/WTF/ChangeLog 2018-11-29 01:22:19 UTC (rev 238650)
@@ -1,3 +1,19 @@
+2018-11-28 Mark Lam <mark....@apple.com>
+
+ ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
+ https://bugs.webkit.org/show_bug.cgi?id=192110
+ <rdar://problem/46317746>
+
+ Reviewed by Saam Barati.
+
+ Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
+ defined in Platform.h because it is also needed in WebCore for the CSS JIT. Also
+ contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
+ (and other projects) as well as JSC. Hence, there's no reason why
+ ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.
+
+ * wtf/Platform.h:
+
2018-11-28 Keith Rollin <krol...@apple.com>
Update generate-unified-source-bundles.rb to generate .xcfilelist files
Modified: trunk/Source/WTF/wtf/Platform.h (238649 => 238650)
--- trunk/Source/WTF/wtf/Platform.h 2018-11-29 01:11:10 UTC (rev 238649)
+++ trunk/Source/WTF/wtf/Platform.h 2018-11-29 01:22:19 UTC (rev 238650)
@@ -965,6 +965,14 @@
#define JIT_OPERATION
#endif
+#ifndef ENABLE_SEPARATED_WX_HEAP
+#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
+#define ENABLE_SEPARATED_WX_HEAP 1
+#else
+#define ENABLE_SEPARATED_WX_HEAP 0
+#endif
+#endif
+
/* Configure the interpreter */
#if COMPILER(GCC_COMPATIBLE)
#define HAVE_COMPUTED_GOTO 1
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
