Title: [238929] trunk
- Revision
- 238929
- Author
- commit-qu...@webkit.org
- Date
- 2018-12-06 05:07:46 -0800 (Thu, 06 Dec 2018)
Log Message
[GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL
https://bugs.webkit.org/show_bug.cgi?id=191998
Patch by Carlos Eduardo Ramalho <cadubent...@gmail.com> on 2018-12-06
Reviewed by Philippe Normand.
Fix compilation with -DENABLE_VIDEO=ON and -DENABLE_OPENGL=OFF due to GStreamerGL.
.:
* Source/cmake/GStreamerDependencies.cmake: "DEFINED ENABLE_OPENGL" is always false because ENABLE_OPENGL
is not a CMake variable (WEBKIT_OPTION_DEFINE macro does not define ENABLE_OPENGL variable per se, but other
variables and appends it to a list).
* Source/cmake/OptionsGTK.cmake: GStreamerDefinitions.cmake was included twice by mistake. Second should be GStreamerDependencies.cmake.
Source/WebCore:
No new tests required. Only fixing the build with certain flags.
* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): add required #if ENABLE(WEBGL).
Modified Paths
Diff
Modified: trunk/ChangeLog (238928 => 238929)
--- trunk/ChangeLog 2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/ChangeLog 2018-12-06 13:07:46 UTC (rev 238929)
@@ -1,5 +1,19 @@
2018-12-06 Carlos Eduardo Ramalho <cadubent...@gmail.com>
+ [GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL
+ https://bugs.webkit.org/show_bug.cgi?id=191998
+
+ Reviewed by Philippe Normand.
+
+ Fix compilation with -DENABLE_VIDEO=ON and -DENABLE_OPENGL=OFF due to GStreamerGL.
+
+ * Source/cmake/GStreamerDependencies.cmake: "DEFINED ENABLE_OPENGL" is always false because ENABLE_OPENGL
+ is not a CMake variable (WEBKIT_OPTION_DEFINE macro does not define ENABLE_OPENGL variable per se, but other
+ variables and appends it to a list).
+ * Source/cmake/OptionsGTK.cmake: GStreamerDefinitions.cmake was included twice by mistake. Second should be GStreamerDependencies.cmake.
+
+2018-12-06 Carlos Eduardo Ramalho <cadubent...@gmail.com>
+
REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=191997
Modified: trunk/Source/WebCore/ChangeLog (238928 => 238929)
--- trunk/Source/WebCore/ChangeLog 2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/Source/WebCore/ChangeLog 2018-12-06 13:07:46 UTC (rev 238929)
@@ -1,5 +1,19 @@
2018-12-06 Carlos Eduardo Ramalho <cadubent...@gmail.com>
+ [GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL
+ https://bugs.webkit.org/show_bug.cgi?id=191998
+
+ Reviewed by Philippe Normand.
+
+ Fix compilation with -DENABLE_VIDEO=ON and -DENABLE_OPENGL=OFF due to GStreamerGL.
+
+ No new tests required. Only fixing the build with certain flags.
+
+ * Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
+ (WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): add required #if ENABLE(WEBGL).
+
+2018-12-06 Carlos Eduardo Ramalho <cadubent...@gmail.com>
+
REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=191997
Modified: trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp (238928 => 238929)
--- trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp 2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp 2018-12-06 13:07:46 UTC (rev 238929)
@@ -143,6 +143,7 @@
{
ASSERT_UNUSED(canvas, m_canvas == &canvas);
+#if ENABLE(WEBGL)
// FIXME: We need to preserve drawing buffer as we are currently grabbing frames asynchronously.
// We should instead add an anchor point for both 2d and 3d contexts where canvas will actually paint.
// And call canvas observers from that point.
@@ -153,6 +154,7 @@
context.setPreserveDrawingBuffer(true);
}
}
+#endif
// FIXME: We should try to generate the frame at the time the screen is being updated.
if (m_canvasChangedTimer.isActive())
Modified: trunk/Source/cmake/GStreamerDependencies.cmake (238928 => 238929)
--- trunk/Source/cmake/GStreamerDependencies.cmake 2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/Source/cmake/GStreamerDependencies.cmake 2018-12-06 13:07:46 UTC (rev 238929)
@@ -1,4 +1,4 @@
-if (DEFINED ENABLE_OPENGL)
+if (PORT STREQUAL "GTK")
WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL ENABLE_OPENGL)
endif ()
WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL ENABLE_VIDEO)
Modified: trunk/Source/cmake/OptionsGTK.cmake (238928 => 238929)
--- trunk/Source/cmake/OptionsGTK.cmake 2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/Source/cmake/OptionsGTK.cmake 2018-12-06 13:07:46 UTC (rev 238929)
@@ -150,7 +150,7 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
-include(GStreamerDefinitions)
+include(GStreamerDependencies)
# Finalize the value for all options. Do not attempt to use an option before
# this point, and do not attempt to change any option after this point.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
