Title: [239232] trunk/Source/WTF
- Revision
- 239232
- Author
- ddkil...@apple.com
- Date
- 2018-12-14 13:50:47 -0800 (Fri, 14 Dec 2018)
Log Message
clang-tidy: Fix unnecessary copy of AtomicString each time one is logged
<https://webkit.org/b/192710>
<rdar://problem/46738962>
Reviewed by Eric Carlson.
* wtf/Logger.h:
(WTF::LogArgument::toString): Make argument a const reference to
avoid the copy.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (239231 => 239232)
--- trunk/Source/WTF/ChangeLog 2018-12-14 21:40:27 UTC (rev 239231)
+++ trunk/Source/WTF/ChangeLog 2018-12-14 21:50:47 UTC (rev 239232)
@@ -1,3 +1,15 @@
+2018-12-14 David Kilzer <ddkil...@apple.com>
+
+ clang-tidy: Fix unnecessary copy of AtomicString each time one is logged
+ <https://webkit.org/b/192710>
+ <rdar://problem/46738962>
+
+ Reviewed by Eric Carlson.
+
+ * wtf/Logger.h:
+ (WTF::LogArgument::toString): Make argument a const reference to
+ avoid the copy.
+
2018-12-14 Zan Dobersek <zdober...@igalia.com>
[GLib] RunLoop::dispatchAfter() GSource requires microsecond precision
Modified: trunk/Source/WTF/wtf/Logger.h (239231 => 239232)
--- trunk/Source/WTF/wtf/Logger.h 2018-12-14 21:40:27 UTC (rev 239231)
+++ trunk/Source/WTF/wtf/Logger.h 2018-12-14 21:50:47 UTC (rev 239232)
@@ -44,7 +44,7 @@
template<typename U = T> static typename std::enable_if<std::is_same<U, long>::value, String>::type toString(long argument) { return String::number(argument); }
template<typename U = T> static typename std::enable_if<std::is_same<U, float>::value, String>::type toString(float argument) { return String::number(argument); }
template<typename U = T> static typename std::enable_if<std::is_same<U, double>::value, String>::type toString(double argument) { return String::number(argument); }
- template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, AtomicString>::value, String>::type toString(AtomicString argument) { return argument.string(); }
+ template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, AtomicString>::value, String>::type toString(const AtomicString& argument) { return argument.string(); }
template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, String>::value, String>::type toString(String argument) { return argument; }
template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, StringBuilder*>::value, String>::type toString(StringBuilder* argument) { return argument->toString(); }
template<typename U = T> static typename std::enable_if<std::is_same<U, const char*>::value, String>::type toString(const char* argument) { return String(argument); }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
