Title: [239318] trunk/Source/WebKit
- Revision
- 239318
- Author
- wenson_hs...@apple.com
- Date
- 2018-12-17 21:23:10 -0800 (Mon, 17 Dec 2018)
Log Message
Unreviewed, fix the iOSMac engineering build again
After r239311, `WebProcessProxy::fullKeyboardAccessEnabled` in `WebProcessProxyIOS.mm` attempts to use
`WKFullKeyboardAccessWatcher`, which is guarded by `ENABLE(FULL_KEYBOARD_ACCESS)`. However, on iOSMac,
`ENABLE(FULL_KEYBOARD_ACCESS)` is 0. Fix the build by putting access to `WKFullKeyboardAccessWatcher` behind
`ENABLE(FULL_KEYBOARD_ACCESS)`.
* UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239317 => 239318)
--- trunk/Source/WebKit/ChangeLog 2018-12-18 04:39:35 UTC (rev 239317)
+++ trunk/Source/WebKit/ChangeLog 2018-12-18 05:23:10 UTC (rev 239318)
@@ -1,5 +1,17 @@
2018-12-17 Wenson Hsieh <wenson_hs...@apple.com>
+ Unreviewed, fix the iOSMac engineering build again
+
+ After r239311, `WebProcessProxy::fullKeyboardAccessEnabled` in `WebProcessProxyIOS.mm` attempts to use
+ `WKFullKeyboardAccessWatcher`, which is guarded by `ENABLE(FULL_KEYBOARD_ACCESS)`. However, on iOSMac,
+ `ENABLE(FULL_KEYBOARD_ACCESS)` is 0. Fix the build by putting access to `WKFullKeyboardAccessWatcher` behind
+ `ENABLE(FULL_KEYBOARD_ACCESS)`.
+
+ * UIProcess/ios/WebProcessProxyIOS.mm:
+ (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
+
+2018-12-17 Wenson Hsieh <wenson_hs...@apple.com>
+
Unreviewed, fix the iOSMac engineering build
`generateRequestID()` is only invoked from code under `ENABLE(MEDIA_STREAM)`; move it under this guard to avoid
Modified: trunk/Source/WebKit/UIProcess/ios/WebProcessProxyIOS.mm (239317 => 239318)
--- trunk/Source/WebKit/UIProcess/ios/WebProcessProxyIOS.mm 2018-12-18 04:39:35 UTC (rev 239317)
+++ trunk/Source/WebKit/UIProcess/ios/WebProcessProxyIOS.mm 2018-12-18 05:23:10 UTC (rev 239318)
@@ -35,7 +35,11 @@
bool WebProcessProxy::fullKeyboardAccessEnabled()
{
+#if ENABLE(FULL_KEYBOARD_ACCESS)
return [WKFullKeyboardAccessWatcher fullKeyboardAccessEnabled];
+#else
+ return NO;
+#endif
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
