Title: [239321] trunk/Source/WebKit
- Revision
- 239321
- Author
- wenson_hs...@apple.com
- Date
- 2018-12-17 22:30:34 -0800 (Mon, 17 Dec 2018)
Log Message
Tap highlights should not be shown on iOSMac
https://bugs.webkit.org/show_bug.cgi?id=192797
<rdar://problem/46793995>
Reviewed by Tim Horton.
WKWebViews in iOSMac should avoid painting tap highlights, since tap highlights are not present in the rest of
the macOS platform. Simply disable this functionality by bailing in `-[WKContentView _showTapHighlight]`.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showTapHighlight]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239320 => 239321)
--- trunk/Source/WebKit/ChangeLog 2018-12-18 05:49:32 UTC (rev 239320)
+++ trunk/Source/WebKit/ChangeLog 2018-12-18 06:30:34 UTC (rev 239321)
@@ -1,5 +1,19 @@
2018-12-17 Wenson Hsieh <wenson_hs...@apple.com>
+ Tap highlights should not be shown on iOSMac
+ https://bugs.webkit.org/show_bug.cgi?id=192797
+ <rdar://problem/46793995>
+
+ Reviewed by Tim Horton.
+
+ WKWebViews in iOSMac should avoid painting tap highlights, since tap highlights are not present in the rest of
+ the macOS platform. Simply disable this functionality by bailing in `-[WKContentView _showTapHighlight]`.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _showTapHighlight]):
+
+2018-12-17 Wenson Hsieh <wenson_hs...@apple.com>
+
Unreviewed, fix the iOSMac engineering build again
After r239311, `WebProcessProxy::fullKeyboardAccessEnabled` in `WebProcessProxyIOS.mm` attempts to use
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (239320 => 239321)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-12-18 05:49:32 UTC (rev 239320)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-12-18 06:30:34 UTC (rev 239321)
@@ -1256,6 +1256,10 @@
- (void)_showTapHighlight
{
auto shouldPaintTapHighlight = [&](const WebCore::FloatRect& rect) {
+#if PLATFORM(IOSMAC)
+ UNUSED_PARAM(rect);
+ return NO;
+#else
static const float highlightPaintThreshold = 0.3; // 30%
float highlightArea = 0;
for (auto highlightQuad : _tapHighlightInformation.quads) {
@@ -1265,6 +1269,7 @@
return false;
}
return highlightArea < rect.area() * highlightPaintThreshold;
+#endif
};
if (!shouldPaintTapHighlight(_page->unobscuredContentRect()) && !_showDebugTapHighlightsForFastClicking)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
