Title: [239482] trunk/LayoutTests
- Revision
- 239482
- Author
- wenson_hs...@apple.com
- Date
- 2018-12-20 17:32:14 -0800 (Thu, 20 Dec 2018)
Log Message
[iOS] Some layout tests are failing after r239441
https://bugs.webkit.org/show_bug.cgi?id=192957
<rdar://problem/46781759>
Reviewed by Simon Fraser.
Fix several failing layout tests after r239441.
* fast/events/ios/click-event-while-editing-node.html:
This test started failing after r239441 because it taps the bottom of the editable element, and then expects
WebKit to scroll the web view up to reveal the touched location. This was exactly the bug that r239441 fixed, so
we should just make this test no longer depend on the broken behavior.
* fast/forms/ios/focus-long-textarea-expected.txt:
* fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:
Rebaseline a couple of test expectations to account for the change in margin around the selection rect, in
-[WKWebView _zoomToFocusRect:…:].
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (239481 => 239482)
--- trunk/LayoutTests/ChangeLog 2018-12-21 01:29:54 UTC (rev 239481)
+++ trunk/LayoutTests/ChangeLog 2018-12-21 01:32:14 UTC (rev 239482)
@@ -1,3 +1,25 @@
+2018-12-20 Wenson Hsieh <wenson_hs...@apple.com>
+
+ [iOS] Some layout tests are failing after r239441
+ https://bugs.webkit.org/show_bug.cgi?id=192957
+ <rdar://problem/46781759>
+
+ Reviewed by Simon Fraser.
+
+ Fix several failing layout tests after r239441.
+
+ * fast/events/ios/click-event-while-editing-node.html:
+
+ This test started failing after r239441 because it taps the bottom of the editable element, and then expects
+ WebKit to scroll the web view up to reveal the touched location. This was exactly the bug that r239441 fixed, so
+ we should just make this test no longer depend on the broken behavior.
+
+ * fast/forms/ios/focus-long-textarea-expected.txt:
+ * fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:
+
+ Rebaseline a couple of test expectations to account for the change in margin around the selection rect, in
+ -[WKWebView _zoomToFocusRect:…:].
+
2018-12-20 Jiewen Tan <jiewen_...@apple.com>
[WebAuthN] Remove hash from Client Data
Modified: trunk/LayoutTests/fast/events/ios/click-event-while-editing-node.html (239481 => 239482)
--- trunk/LayoutTests/fast/events/ios/click-event-while-editing-node.html 2018-12-21 01:29:54 UTC (rev 239481)
+++ trunk/LayoutTests/fast/events/ios/click-event-while-editing-node.html 2018-12-21 01:32:14 UTC (rev 239482)
@@ -24,8 +24,8 @@
if (window.testRunner) {
testRunner.dumpAsText();
jsTestIsAsync = true;
- UIHelper.activateAndWaitForInputSessionAt(50, 300).then(() => {
- UIHelper.tapAt(50, 300).then(() => {
+ UIHelper.activateAndWaitForInputSessionAt(50, 200).then(() => {
+ UIHelper.tapAt(50, 200).then(() => {
shouldBeEqualToString("document.getElementById('clicks').textContent", `${clickCount}`);
finishJSTest();
});
Modified: trunk/LayoutTests/fast/forms/ios/focus-long-textarea-expected.txt (239481 => 239482)
--- trunk/LayoutTests/fast/forms/ios/focus-long-textarea-expected.txt 2018-12-21 01:29:54 UTC (rev 239481)
+++ trunk/LayoutTests/fast/forms/ios/focus-long-textarea-expected.txt 2018-12-21 01:32:14 UTC (rev 239482)
@@ -3,4 +3,4 @@
tap location { x: 38.000, y: 664.000 }
scale 1.455
-visibleRect { left: 0.000, top: 506.294, width: 219.979, height: 376.713 }
+visibleRect { left: 0.000, top: 498.045, width: 219.979, height: 376.713 }
Modified: trunk/LayoutTests/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt (239481 => 239482)
--- trunk/LayoutTests/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt 2018-12-21 01:29:54 UTC (rev 239481)
+++ trunk/LayoutTests/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt 2018-12-21 01:32:14 UTC (rev 239482)
@@ -3,4 +3,4 @@
tap location { x: 328.000, y: 862.000 }
scale 1.455
-visibleRect { left: 122.707, top: 776.803, width: 219.980, height: 376.715 }
+visibleRect { left: 114.458, top: 776.803, width: 219.980, height: 376.715 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
