Title: [240291] trunk/Tools
Revision
240291
Author
aakash_j...@apple.com
Date
2019-01-22 13:25:06 -0800 (Tue, 22 Jan 2019)

Log Message

[build.webkit.org] Unit-test failure after r237113
https://bugs.webkit.org/show_bug.cgi?id=193669

Reviewed by Michael Catanzaro.

* BuildSlaveSupport/build.webkit.org-config/factories.py:
(Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has
multiple or zero flags.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py (240290 => 240291)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	2019-01-22 21:23:31 UTC (rev 240290)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	2019-01-22 21:25:06 UTC (rev 240291)
@@ -39,7 +39,7 @@
         self.addStep(DeleteStaleBuildFiles())
         if platform == "win":
             self.addStep(InstallWin32Dependencies())
-        if platform == "gtk" and additionalArguments != ["--no-experimental-features"]:
+        if platform == "gtk" and "--no-experimental-features" not in (additionalArguments or []):
             self.addStep(InstallGtkDependencies())
         if platform == "wpe":
             self.addStep(InstallWpeDependencies())

Modified: trunk/Tools/ChangeLog (240290 => 240291)


--- trunk/Tools/ChangeLog	2019-01-22 21:23:31 UTC (rev 240290)
+++ trunk/Tools/ChangeLog	2019-01-22 21:25:06 UTC (rev 240291)
@@ -1,3 +1,14 @@
+2019-01-22  Aakash Jain  <aakash_j...@apple.com>
+
+        [build.webkit.org] Unit-test failure after r237113
+        https://bugs.webkit.org/show_bug.cgi?id=193669
+
+        Reviewed by Michael Catanzaro.
+
+        * BuildSlaveSupport/build.webkit.org-config/factories.py:
+        (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
+        multiple or zero flags.
+
 2019-01-22  Tadeu Zagallo  <tzaga...@apple.com>
 
         Cache bytecode to disk
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to