Title: [240352] trunk
- Revision
- 240352
- Author
- wenson_hs...@apple.com
- Date
- 2019-01-23 12:09:54 -0800 (Wed, 23 Jan 2019)
Log Message
[iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
https://bugs.webkit.org/show_bug.cgi?id=193182
<rdar://problem/47452154>
Reviewed by Tim Horton.
Source/WebKit:
Fix an existing bug where blurring an element doesn't always un-suppress text interactions.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _elementDidBlur]):
Tools:
This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
preventing later tests from recognizing gestures.
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
Cancel all touches in the UIApplication when resetting to a consistent state between tests.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240351 => 240352)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 19:29:18 UTC (rev 240351)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 20:09:54 UTC (rev 240352)
@@ -1,3 +1,16 @@
+2019-01-23 Wenson Hsieh <wenson_hs...@apple.com>
+
+ [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=193182
+ <rdar://problem/47452154>
+
+ Reviewed by Tim Horton.
+
+ Fix an existing bug where blurring an element doesn't always un-suppress text interactions.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _elementDidBlur]):
+
2019-01-23 Michael Catanzaro <mcatanz...@igalia.com>
Minor improvements to NetworkProcess
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (240351 => 240352)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-23 19:29:18 UTC (rev 240351)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-23 20:09:54 UTC (rev 240352)
@@ -4660,6 +4660,7 @@
if (!_isChangingFocus) {
[self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTransparentOrFullyClipped];
+ [self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTooSmall];
_didAccessoryTabInitiateFocus = NO;
}
}
Modified: trunk/Tools/ChangeLog (240351 => 240352)
--- trunk/Tools/ChangeLog 2019-01-23 19:29:18 UTC (rev 240351)
+++ trunk/Tools/ChangeLog 2019-01-23 20:09:54 UTC (rev 240352)
@@ -1,3 +1,23 @@
+2019-01-23 Wenson Hsieh <wenson_hs...@apple.com>
+
+ [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=193182
+ <rdar://problem/47452154>
+
+ Reviewed by Tim Horton.
+
+ This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
+ long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
+ recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
+
+ To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
+ preventing later tests from recognizing gestures.
+
+ * WebKitTestRunner/ios/TestControllerIOS.mm:
+ (WTR::TestController::platformResetStateToConsistentValues):
+
+ Cancel all touches in the UIApplication when resetting to a consistent state between tests.
+
2019-01-23 Jonathan Bedard <jbed...@apple.com>
webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
Modified: trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm (240351 => 240352)
--- trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2019-01-23 19:29:18 UTC (rev 240351)
+++ trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2019-01-23 20:09:54 UTC (rev 240352)
@@ -115,6 +115,7 @@
{
cocoaResetStateToConsistentValues(options);
+ [[UIApplication sharedApplication] _cancelAllTouches];
[[UIDevice currentDevice] setOrientation:UIDeviceOrientationPortrait animated:NO];
m_inputModeSwizzlers.clear();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
