Title: [245229] branches/safari-608.1.24-branch/Source/WebKit
Revision
245229
Author
bshaf...@apple.com
Date
2019-05-12 23:51:16 -0700 (Sun, 12 May 2019)

Log Message

Cherry-pick r245189. rdar://problem/50646747

    Let WebKit clients supply an application name for user agent in modern compatibility mode
    https://bugs.webkit.org/show_bug.cgi?id=197782
    <rdar://problem/50646747>

    Reviewed by Beth Dakin.

    Add plumbing for a new private property on WKWebpagePreferences.

    * UIProcess/API/APIWebsitePolicies.cpp:
    (API::WebsitePolicies::copy const):
    * UIProcess/API/APIWebsitePolicies.h:
    * UIProcess/API/Cocoa/WKWebpagePreferences.mm:
    (-[WKWebpagePreferences _applicationNameForUserAgentWithModernCompatibility]):
    (-[WKWebpagePreferences _setApplicationNameForUserAgentWithModernCompatibility:]):
    * UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-608.1.24-branch/Source/WebKit/ChangeLog (245228 => 245229)


--- branches/safari-608.1.24-branch/Source/WebKit/ChangeLog	2019-05-13 06:51:13 UTC (rev 245228)
+++ branches/safari-608.1.24-branch/Source/WebKit/ChangeLog	2019-05-13 06:51:16 UTC (rev 245229)
@@ -1,5 +1,46 @@
 2019-05-12  Babak Shafiei  <bshaf...@apple.com>
 
+        Cherry-pick r245189. rdar://problem/50646747
+
+    Let WebKit clients supply an application name for user agent in modern compatibility mode
+    https://bugs.webkit.org/show_bug.cgi?id=197782
+    <rdar://problem/50646747>
+    
+    Reviewed by Beth Dakin.
+    
+    Add plumbing for a new private property on WKWebpagePreferences.
+    
+    * UIProcess/API/APIWebsitePolicies.cpp:
+    (API::WebsitePolicies::copy const):
+    * UIProcess/API/APIWebsitePolicies.h:
+    * UIProcess/API/Cocoa/WKWebpagePreferences.mm:
+    (-[WKWebpagePreferences _applicationNameForUserAgentWithModernCompatibility]):
+    (-[WKWebpagePreferences _setApplicationNameForUserAgentWithModernCompatibility:]):
+    * UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-05-10  Wenson Hsieh  <wenson_hs...@apple.com>
+
+            Let WebKit clients supply an application name for user agent in modern compatibility mode
+            https://bugs.webkit.org/show_bug.cgi?id=197782
+            <rdar://problem/50646747>
+
+            Reviewed by Beth Dakin.
+
+            Add plumbing for a new private property on WKWebpagePreferences.
+
+            * UIProcess/API/APIWebsitePolicies.cpp:
+            (API::WebsitePolicies::copy const):
+            * UIProcess/API/APIWebsitePolicies.h:
+            * UIProcess/API/Cocoa/WKWebpagePreferences.mm:
+            (-[WKWebpagePreferences _applicationNameForUserAgentWithModernCompatibility]):
+            (-[WKWebpagePreferences _setApplicationNameForUserAgentWithModernCompatibility:]):
+            * UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
+
+2019-05-12  Babak Shafiei  <bshaf...@apple.com>
+
         Cherry-pick r245183. rdar://problem/50065100
 
     Add WKWebViewConfiguration._canShowWhileLocked SPI

Modified: branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp (245228 => 245229)


--- branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp	2019-05-13 06:51:13 UTC (rev 245228)
+++ branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp	2019-05-13 06:51:16 UTC (rev 245229)
@@ -66,6 +66,7 @@
         customHeaderFields.append(WebCore::HTTPHeaderField(field));
     policies->setCustomHeaderFields(WTFMove(customHeaderFields));
     policies->setAllowSiteSpecificQuirksToOverrideCompatibilityMode(m_allowSiteSpecificQuirksToOverrideCompatibilityMode);
+    policies->setApplicationNameForUserAgentWithModernCompatibility(m_applicationNameForUserAgentWithModernCompatibility);
     return policies;
 }
 

Modified: branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/APIWebsitePolicies.h (245228 => 245229)


--- branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/APIWebsitePolicies.h	2019-05-13 06:51:13 UTC (rev 245228)
+++ branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/APIWebsitePolicies.h	2019-05-13 06:51:16 UTC (rev 245229)
@@ -104,6 +104,9 @@
     bool allowSiteSpecificQuirksToOverrideCompatibilityMode() const { return m_allowSiteSpecificQuirksToOverrideCompatibilityMode; }
     void setAllowSiteSpecificQuirksToOverrideCompatibilityMode(bool value) { m_allowSiteSpecificQuirksToOverrideCompatibilityMode = value; }
 
+    WTF::String applicationNameForUserAgentWithModernCompatibility() const { return m_applicationNameForUserAgentWithModernCompatibility; }
+    void setApplicationNameForUserAgentWithModernCompatibility(const WTF::String& applicationName) { m_applicationNameForUserAgentWithModernCompatibility = applicationName; }
+
 private:
     WebsitePolicies(bool contentBlockersEnabled, OptionSet<WebKit::WebsiteAutoplayQuirk>, WebKit::WebsiteAutoplayPolicy, Vector<WebCore::HTTPHeaderField>&&, WebKit::WebsitePopUpPolicy, RefPtr<WebsiteDataStore>&&);
 
@@ -124,6 +127,7 @@
     WebKit::WebsiteMediaSourcePolicy m_mediaSourcePolicy { WebKit::WebsiteMediaSourcePolicy::Default };
     WebKit::WebsiteSimulatedMouseEventsDispatchPolicy m_simulatedMouseEventsDispatchPolicy { WebKit::WebsiteSimulatedMouseEventsDispatchPolicy::Default };
     bool m_allowSiteSpecificQuirksToOverrideCompatibilityMode { false };
+    WTF::String m_applicationNameForUserAgentWithModernCompatibility;
 };
 
 } // namespace API

Modified: branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm (245228 => 245229)


--- branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm	2019-05-13 06:51:13 UTC (rev 245228)
+++ branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm	2019-05-13 06:51:16 UTC (rev 245229)
@@ -286,6 +286,16 @@
     _websitePolicies->setAllowSiteSpecificQuirksToOverrideCompatibilityMode(value);
 }
 
+- (NSString *)_applicationNameForUserAgentWithModernCompatibility
+{
+    return _websitePolicies->applicationNameForUserAgentWithModernCompatibility();
+}
+
+- (void)_setApplicationNameForUserAgentWithModernCompatibility:(NSString *)applicationName
+{
+    _websitePolicies->setApplicationNameForUserAgentWithModernCompatibility(applicationName);
+}
+
 - (API::Object&)_apiObject
 {
     return *_websitePolicies;

Modified: branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h (245228 => 245229)


--- branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h	2019-05-13 06:51:13 UTC (rev 245228)
+++ branches/safari-608.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h	2019-05-13 06:51:16 UTC (rev 245229)
@@ -69,4 +69,6 @@
 @property (nonatomic, setter=_setDeviceOrientationAndMotionAccessPolicy:) _WKWebsiteDeviceOrientationAndMotionAccessPolicy _deviceOrientationAndMotionAccessPolicy;
 @property (nonatomic, setter=_setAllowSiteSpecificQuirksToOverrideCompatibilityMode:) BOOL _allowSiteSpecificQuirksToOverrideCompatibilityMode;
 
+@property (nonatomic, copy, setter=_setApplicationNameForUserAgentWithModernCompatibility:) NSString *_applicationNameForUserAgentWithModernCompatibility;
+
 @end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to