Title: [245852] trunk/Source/WebKit
- Revision
- 245852
- Author
- bfulg...@apple.com
- Date
- 2019-05-29 10:05:02 -0700 (Wed, 29 May 2019)
Log Message
Correct flaky WebAuthN test cases
https://bugs.webkit.org/show_bug.cgi?id=198308
<rdar://problem/48677219>
Reviewed by David Kilzer.
Correct offset math in the MockHidConnection implementation. The write position of
the payload buffer was computed using the value of 'size()', which is set to the full
capacity of the vector after a 'grow()' operation.
Tests: http/wpt/webauthn
* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::feedReports):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (245851 => 245852)
--- trunk/Source/WebKit/ChangeLog 2019-05-29 16:58:56 UTC (rev 245851)
+++ trunk/Source/WebKit/ChangeLog 2019-05-29 17:05:02 UTC (rev 245852)
@@ -1,3 +1,20 @@
+2019-05-29 Brent Fulgham <bfulg...@apple.com>
+
+ Correct flaky WebAuthN test cases
+ https://bugs.webkit.org/show_bug.cgi?id=198308
+ <rdar://problem/48677219>
+
+ Reviewed by David Kilzer.
+
+ Correct offset math in the MockHidConnection implementation. The write position of
+ the payload buffer was computed using the value of 'size()', which is set to the full
+ capacity of the vector after a 'grow()' operation.
+
+ Tests: http/wpt/webauthn
+
+ * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
+ (WebKit::MockHidConnection::feedReports):
+
2019-05-28 Fujii Hironori <hironori.fu...@sony.com>
[WinCairo] REGRESSION(r245186) Crash in NetworkCache::IOChannel::read in http/tests/IndexedDB some tests
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp (245851 => 245852)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp 2019-05-29 16:58:56 UTC (rev 245851)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp 2019-05-29 17:05:02 UTC (rev 245852)
@@ -195,10 +195,11 @@
Vector<uint8_t> payload;
payload.reserveInitialCapacity(kHidInitResponseSize);
payload.appendVector(m_nonce);
+ size_t writePosition = payload.size();
if (stagesMatch() && m_configuration.hid->error == Mock::Error::WrongNonce)
payload[0]--;
payload.grow(kHidInitResponseSize);
- cryptographicallyRandomValues(payload.data() + payload.size(), CtapChannelIdSize);
+ cryptographicallyRandomValues(payload.data() + writePosition, CtapChannelIdSize);
auto channel = kHidBroadcastChannel;
if (stagesMatch() && m_configuration.hid->error == Mock::Error::WrongChannelId)
channel--;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
