[webkit-changes] [245879] trunk/Tools

[justin_michaud]

Title: [245879] trunk/Tools

Revision

245879

Author

justin_mich...@apple.com

Date

2019-05-29 16:53:57 -0700 (Wed, 29 May 2019)

Log Message

Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
https://bugs.webkit.org/show_bug.cgi?id=198322

Rubber-stamped by Michael Saboff. Disable running the new collectContinuously tests on debug builds.
This matches what we do for other jsc tests.

* Scripts/run-jsc-stress-tests:

Modified Paths

• trunk/Tools/ChangeLog
• trunk/Tools/Scripts/run-jsc-stress-tests

Diff

Modified: trunk/Tools/ChangeLog (245878 => 245879)

--- trunk/Tools/ChangeLog	2019-05-29 23:30:31 UTC (rev 245878)
+++ trunk/Tools/ChangeLog	2019-05-29 23:53:57 UTC (rev 245879)
@@ -1,3 +1,13 @@
+2019-05-29  Justin Michaud  <justin_mich...@apple.com>
+
+        Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
+        https://bugs.webkit.org/show_bug.cgi?id=198322
+
+        Rubber-stamped by Michael Saboff. Disable running the new collectContinuously tests on debug builds. 
+        This matches what we do for other jsc tests. 
+
+        * Scripts/run-jsc-stress-tests:
+
 2019-05-29  Don Olmstead  <don.olmst...@sony.com>
 
         Remove ENABLE definitions from WebKit config files

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (245878 => 245879)

--- trunk/Tools/Scripts/run-jsc-stress-tests	2019-05-29 23:30:31 UTC (rev 245878)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2019-05-29 23:53:57 UTC (rev 245879)
@@ -1081,7 +1081,7 @@
         run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
     end
 end
 
@@ -1099,7 +1099,7 @@
         run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
     end
 end
 
@@ -1119,7 +1119,7 @@
         run("wasm-no-call-ic", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS)
         run("wasm-no-tls-context", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
         run("wasm-no-air", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
     end
 end
 
@@ -1145,7 +1145,7 @@
       runWithOutputHandler("wasm-no-call-ic", noisyOutputHandler, "../spec-harness.js", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS)
       runWithOutputHandler("wasm-no-tls-context", noisyOutputHandler, "../spec-harness.js", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
       runWithOutputHandler("wasm-no-air", noisyOutputHandler, "../spec-harness.js", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
+      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
     end
 end
 

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes