Title: [246418] trunk/Tools
Revision
246418
Author
hironori.fu...@sony.com
Date
2019-06-13 18:51:09 -0700 (Thu, 13 Jun 2019)

Log Message

[WinCairo][WebKitTestRunner] pixel image dump outputs blank images
https://bugs.webkit.org/show_bug.cgi?id=198820

Reviewed by Ross Kirsling.

WebView window paints nothing because it is moved out of the
screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
as DumpRenderTree does.

* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (246417 => 246418)


--- trunk/Tools/ChangeLog	2019-06-13 23:01:57 UTC (rev 246417)
+++ trunk/Tools/ChangeLog	2019-06-14 01:51:09 UTC (rev 246418)
@@ -1,3 +1,17 @@
+2019-06-13  Fujii Hironori  <hironori.fu...@sony.com>
+
+        [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
+        https://bugs.webkit.org/show_bug.cgi?id=198820
+
+        Reviewed by Ross Kirsling.
+
+        WebView window paints nothing because it is moved out of the
+        screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
+        as DumpRenderTree does.
+
+        * WebKitTestRunner/win/PlatformWebViewWin.cpp:
+        (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
+
 2019-06-13  Tim Horton  <timothy_hor...@apple.com>
 
         Make it possible for validate-committer-lists to dump a mailmap file

Modified: trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp (246417 => 246418)


--- trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp	2019-06-13 23:01:57 UTC (rev 246417)
+++ trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp	2019-06-14 01:51:09 UTC (rev 246418)
@@ -225,17 +225,8 @@
     if (!bitmap)
         return nullptr;
 
-    ::InvalidateRect(m_window, nullptr, true);
     ::SelectObject(memoryDC.get(), bitmap.get());
-    ::BitBlt(memoryDC.get(),
-        0,
-        0,
-        width,
-        height,
-        windowDC,
-        0,
-        0,
-        SRCCOPY);
+    ::SendMessage(m_window, WM_PRINT, reinterpret_cast<WPARAM>(memoryDC.get()), PRF_CLIENT | PRF_CHILDREN | PRF_OWNED);
 
     BITMAP bitmapTag { };
     GetObject(bitmap.get(), sizeof(bitmapTag), &bitmapTag);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to