Title: [246922] trunk/Source/WebCore
Revision
246922
Author
hironori.fu...@sony.com
Date
2019-06-28 00:38:09 -0700 (Fri, 28 Jun 2019)

Log Message

[Win] unresolved external symbol "JSC::JSObject::didBecomePrototype(void)" referenced in function "JSC::Structure::create(...)"
https://bugs.webkit.org/show_bug.cgi?id=199312

Reviewed by Keith Miller.

WinCairo port, clang-cl Release builds reported a following linkage error:

> WebCore.lib(UnifiedSource-4babe430-10.cpp.obj) : error LNK2019: unresolved external symbol "public: void __cdecl JSC::JSObject::didBecomePrototype(void)" (?didBecomePrototype@JSObject@JSC@@QEAAXXZ) referenced in function "public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &,struct JSC::ClassInfo const *,unsigned char,unsigned int)" (?create@Structure@JSC@@SAPEAV12@AEAVVM@2@PEAVJSGlobalObject@2@VJSValue@2@AEBVTypeInfo@2@PEBUClassInfo@2@EI@Z)

No new tests because there is no behavior change.

* Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: Include <_javascript_Core/JSCInlines.h>,
and do not include headers which is included by it.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (246921 => 246922)


--- trunk/Source/WebCore/ChangeLog	2019-06-28 05:57:35 UTC (rev 246921)
+++ trunk/Source/WebCore/ChangeLog	2019-06-28 07:38:09 UTC (rev 246922)
@@ -1,3 +1,19 @@
+2019-06-28  Fujii Hironori  <hironori.fu...@sony.com>
+
+        [Win] unresolved external symbol "JSC::JSObject::didBecomePrototype(void)" referenced in function "JSC::Structure::create(...)"
+        https://bugs.webkit.org/show_bug.cgi?id=199312
+
+        Reviewed by Keith Miller.
+
+        WinCairo port, clang-cl Release builds reported a following linkage error:
+
+        > WebCore.lib(UnifiedSource-4babe430-10.cpp.obj) : error LNK2019: unresolved external symbol "public: void __cdecl JSC::JSObject::didBecomePrototype(void)" (?didBecomePrototype@JSObject@JSC@@QEAAXXZ) referenced in function "public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &,struct JSC::ClassInfo const *,unsigned char,unsigned int)" (?create@Structure@JSC@@SAPEAV12@AEAVVM@2@PEAVJSGlobalObject@2@VJSValue@2@AEBVTypeInfo@2@PEBUClassInfo@2@EI@Z)
+
+        No new tests because there is no behavior change.
+
+        * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: Include <_javascript_Core/JSCInlines.h>,
+        and do not include headers which is included by it.
+
 2019-06-27  Zalan Bujtas  <za...@apple.com>
 
         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.

Modified: trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp (246921 => 246922)


--- trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp	2019-06-28 05:57:35 UTC (rev 246921)
+++ trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp	2019-06-28 07:38:09 UTC (rev 246922)
@@ -49,11 +49,8 @@
 #include "SQLiteTransaction.h"
 #include "ThreadSafeDataBuffer.h"
 #include <_javascript_Core/AuxiliaryBarrierInlines.h>
-#include <_javascript_Core/HeapInlines.h>
-#include <_javascript_Core/JSCJSValueInlines.h>
-#include <_javascript_Core/JSGlobalObject.h>
+#include <_javascript_Core/JSCInlines.h>
 #include <_javascript_Core/StrongInlines.h>
-#include <_javascript_Core/StructureInlines.h>
 #include <wtf/FileSystem.h>
 #include <wtf/NeverDestroyed.h>
 #include <wtf/text/StringConcatenateNumbers.h>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to