Diff
Modified: trunk/JSTests/ChangeLog (247035 => 247036)
--- trunk/JSTests/ChangeLog 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/ChangeLog 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,23 @@
+2019-07-01 Justin Michaud <justin_mich...@apple.com>
+
+ [Wasm-References] Disable references by default
+ https://bugs.webkit.org/show_bug.cgi?id=199390
+
+ Reviewed by Saam Barati.
+
+ * wasm/references-spec-tests/ref_is_null.js:
+ * wasm/references-spec-tests/ref_null.js:
+ * wasm/references/anyref_globals.js:
+ * wasm/references/anyref_modules.js:
+ * wasm/references/anyref_table.js:
+ * wasm/references/anyref_table_import.js:
+ * wasm/references/element_parsing.js:
+ * wasm/references/func_ref.js:
+ * wasm/references/is_null.js:
+ * wasm/references/multitable.js:
+ * wasm/references/table_misc.js:
+ * wasm/references/validation.js:
+
2019-07-01 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r246946.
Modified: trunk/JSTests/wasm/references/anyref_globals.js (247035 => 247036)
--- trunk/JSTests/wasm/references/anyref_globals.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/anyref_globals.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references/anyref_modules.js (247035 => 247036)
--- trunk/JSTests/wasm/references/anyref_modules.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/anyref_modules.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references/anyref_table.js (247035 => 247036)
--- trunk/JSTests/wasm/references/anyref_table.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/anyref_table.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references/anyref_table_import.js (247035 => 247036)
--- trunk/JSTests/wasm/references/anyref_table_import.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/anyref_table_import.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references/element_parsing.js (247035 => 247036)
--- trunk/JSTests/wasm/references/element_parsing.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/element_parsing.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
function module(bytes, valid = true) {
Modified: trunk/JSTests/wasm/references/func_ref.js (247035 => 247036)
--- trunk/JSTests/wasm/references/func_ref.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/func_ref.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references/is_null.js (247035 => 247036)
--- trunk/JSTests/wasm/references/is_null.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/is_null.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references/multitable.js (247035 => 247036)
--- trunk/JSTests/wasm/references/multitable.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/multitable.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references/table_misc.js (247035 => 247036)
--- trunk/JSTests/wasm/references/table_misc.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/table_misc.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references/validation.js (247035 => 247036)
--- trunk/JSTests/wasm/references/validation.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references/validation.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
import * as assert from '../assert.js';
import Builder from '../Builder.js';
Modified: trunk/JSTests/wasm/references-spec-tests/ref_is_null.js (247035 => 247036)
--- trunk/JSTests/wasm/references-spec-tests/ref_is_null.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references-spec-tests/ref_is_null.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,4 +1,4 @@
-
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
'use strict';
let console = { log: print }
let hostrefs = {};
Modified: trunk/JSTests/wasm/references-spec-tests/ref_null.js (247035 => 247036)
--- trunk/JSTests/wasm/references-spec-tests/ref_null.js 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/JSTests/wasm/references-spec-tests/ref_null.js 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+//@ runWebAssemblySuite("--useWebAssemblyReferences=true")
'use strict';
let console = { log: print }
Modified: trunk/LayoutTests/ChangeLog (247035 => 247036)
--- trunk/LayoutTests/ChangeLog 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/LayoutTests/ChangeLog 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,12 @@
+2019-07-01 Justin Michaud <justin_mich...@apple.com>
+
+ [Wasm-References] Disable references by default
+ https://bugs.webkit.org/show_bug.cgi?id=199390
+
+ Reviewed by Saam Barati.
+
+ * workers/wasm-references.html:
+
2019-07-01 Devin Rousso <drou...@apple.com>
Web Inspector: REGRESSION(r245498): Timelines: CPU: discontinuities are filled in by the next record
Modified: trunk/LayoutTests/workers/wasm-references.html (247035 => 247036)
--- trunk/LayoutTests/workers/wasm-references.html 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/LayoutTests/workers/wasm-references.html 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ jscOptions=--useWebAssemblyReferences=true ] -->
<html>
<head>
<script src=""
Modified: trunk/Source/_javascript_Core/ChangeLog (247035 => 247036)
--- trunk/Source/_javascript_Core/ChangeLog 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,12 @@
+2019-07-01 Justin Michaud <justin_mich...@apple.com>
+
+ [Wasm-References] Disable references by default
+ https://bugs.webkit.org/show_bug.cgi?id=199390
+
+ Reviewed by Saam Barati.
+
+ * runtime/Options.h:
+
2019-07-01 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r246946.
Modified: trunk/Source/_javascript_Core/runtime/Options.h (247035 => 247036)
--- trunk/Source/_javascript_Core/runtime/Options.h 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/Source/_javascript_Core/runtime/Options.h 2019-07-02 05:14:17 UTC (rev 247036)
@@ -502,7 +502,7 @@
v(bool, useWebAssemblyStreamingApi, enableWebAssemblyStreamingApi, Normal, "Allow to run WebAssembly's Streaming API") \
v(bool, useCallICsForWebAssemblyToJSCalls, true, Normal, "If true, we will use CallLinkInfo to inline cache Wasm to JS calls.") \
v(bool, useEagerWebAssemblyModuleHashing, false, Normal, "Unnamed WebAssembly modules are identified in backtraces through their hash, if available.") \
- v(bool, useWebAssemblyReferences, true, Normal, "Allow types from the wasm references spec.") \
+ v(bool, useWebAssemblyReferences, false, Normal, "Allow types from the wasm references spec.") \
v(bool, useBigInt, false, Normal, "If true, we will enable BigInt support.") \
v(bool, useIntlNumberFormatToParts, enableIntlNumberFormatToParts, Normal, "If true, we will enable Intl.NumberFormat.prototype.formatToParts") \
v(bool, useIntlPluralRules, enableIntlPluralRules, Normal, "If true, we will enable Intl.PluralRules.") \
Modified: trunk/Tools/ChangeLog (247035 => 247036)
--- trunk/Tools/ChangeLog 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/Tools/ChangeLog 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1,3 +1,12 @@
+2019-07-01 Justin Michaud <justin_mich...@apple.com>
+
+ [Wasm-References] Disable references by default
+ https://bugs.webkit.org/show_bug.cgi?id=199390
+
+ Reviewed by Saam Barati.
+
+ * Scripts/run-jsc-stress-tests:
+
2019-07-01 Joonghun Park <pjh0...@gmail.com>
Unreviewed. Revert r246965 to fix build break
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (247035 => 247036)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2019-07-02 05:10:54 UTC (rev 247035)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2019-07-02 05:14:17 UTC (rev 247036)
@@ -1090,21 +1090,21 @@
end
end
-def runWebAssemblySuite
+def runWebAssemblySuite(*optionalTestSpecificOptions)
return if !$jitTests
return if !$isFTLPlatform
modules = Dir[WASMTESTS_PATH + "*.js"].map { |f| File.basename(f) }
prepareExtraAbsoluteFiles(WASMTESTS_PATH, ["wasm.json"])
prepareExtraRelativeFiles(modules.map { |f| "../" + f }, $collection)
- run("default-wasm", "-m", *FTL_OPTIONS)
+ run("default-wasm", "-m", *(FTL_OPTIONS + optionalTestSpecificOptions))
if $mode != "quick"
- run("wasm-no-cjit-yes-tls-context", "-m", "--useFastTLSForWasmContext=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS))
- run("wasm-eager-jettison", "-m", "--forceCodeBlockToJettisonDueToOldAge=true", *FTL_OPTIONS)
- run("wasm-no-call-ic", "-m", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS)
- run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
- run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
- run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
- run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
+ run("wasm-no-cjit-yes-tls-context", "-m", "--useFastTLSForWasmContext=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS + optionalTestSpecificOptions))
+ run("wasm-eager-jettison", "-m", "--forceCodeBlockToJettisonDueToOldAge=true", *(FTL_OPTIONS + optionalTestSpecificOptions))
+ run("wasm-no-call-ic", "-m", "--useCallICsForWebAssemblyToJSCalls=false", *(FTL_OPTIONS + optionalTestSpecificOptions))
+ run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *(FTL_OPTIONS + optionalTestSpecificOptions))
+ run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *(FTL_OPTIONS + optionalTestSpecificOptions))
+ run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *(FTL_OPTIONS + optionalTestSpecificOptions))
+ run("wasm-collect-continuously", "-m", "--collectContinuously=true", *(FTL_OPTIONS + optionalTestSpecificOptions)) if shouldCollectContinuously?
end
end
