Title: [247365] trunk/Source/WebCore
- Revision
- 247365
- Author
- timothy_hor...@apple.com
- Date
- 2019-07-11 14:15:24 -0700 (Thu, 11 Jul 2019)
Log Message
Null deref of RenderView under FrameView::setNeedsCompositingConfigurationUpdate
https://bugs.webkit.org/show_bug.cgi?id=199723
<rdar://problem/51554747>
Reviewed by Simon Fraser.
* page/FrameView.cpp:
(WebCore::FrameView::setNeedsCompositingConfigurationUpdate):
Add a null-check; it looks like it is possible to get here by dismissing
the find overlay (or other page overlay) at an inopportune time.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (247364 => 247365)
--- trunk/Source/WebCore/ChangeLog 2019-07-11 21:12:39 UTC (rev 247364)
+++ trunk/Source/WebCore/ChangeLog 2019-07-11 21:15:24 UTC (rev 247365)
@@ -1,3 +1,16 @@
+2019-07-11 Tim Horton <timothy_hor...@apple.com>
+
+ Null deref of RenderView under FrameView::setNeedsCompositingConfigurationUpdate
+ https://bugs.webkit.org/show_bug.cgi?id=199723
+ <rdar://problem/51554747>
+
+ Reviewed by Simon Fraser.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::setNeedsCompositingConfigurationUpdate):
+ Add a null-check; it looks like it is possible to get here by dismissing
+ the find overlay (or other page overlay) at an inopportune time.
+
2019-07-11 Chris Dumez <cdu...@apple.com>
Pages using Google Tag Manager Google's anti-flicker optimization may take ~5 seconds to do initial paint
Modified: trunk/Source/WebCore/page/FrameView.cpp (247364 => 247365)
--- trunk/Source/WebCore/page/FrameView.cpp 2019-07-11 21:12:39 UTC (rev 247364)
+++ trunk/Source/WebCore/page/FrameView.cpp 2019-07-11 21:15:24 UTC (rev 247365)
@@ -2921,7 +2921,7 @@
void FrameView::setNeedsCompositingConfigurationUpdate()
{
RenderView* renderView = this->renderView();
- if (renderView->usesCompositing()) {
+ if (renderView && renderView->usesCompositing()) {
if (auto* rootLayer = renderView->layer())
rootLayer->setNeedsCompositingConfigurationUpdate();
renderView->compositor().scheduleCompositingLayerUpdate();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
