Title: [247571] trunk/LayoutTests
- Revision
- 247571
- Author
- commit-qu...@webkit.org
- Date
- 2019-07-18 12:06:35 -0700 (Thu, 18 Jul 2019)
Log Message
Rebase fast/forms/ios/delete-in-input-in-iframe.html after r244141
https://bugs.webkit.org/show_bug.cgi?id=199875
<rdar://problem/50060561>
Patch by Alex Christensen <achristen...@webkit.org> on 2019-07-18
Reviewed by Megan Gardner.
In r202295, we added an ios-specific quirk to prevent scrolling on iOS because of UIKit/WebKit scrolling discrepancies.
In r244141, we changed the scrolling behavior to be more like macOS, and the test was broken. Since this was an intentional
change and the bugs reported in rdar://problem/26805722 (initially fixed by r202295) and rdar://problem/49225507 (fixed by r244141)
are both behaving as desired, the intentional change in r244141 should be reflected by new test expectations.
We do want typing in an input field in an iframe to scroll as we type.
* fast/forms/ios/delete-in-input-in-iframe-expected.txt:
* fast/forms/ios/delete-in-input-in-iframe.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (247570 => 247571)
--- trunk/LayoutTests/ChangeLog 2019-07-18 19:05:29 UTC (rev 247570)
+++ trunk/LayoutTests/ChangeLog 2019-07-18 19:06:35 UTC (rev 247571)
@@ -1,3 +1,20 @@
+2019-07-18 Alex Christensen <achristen...@webkit.org>
+
+ Rebase fast/forms/ios/delete-in-input-in-iframe.html after r244141
+ https://bugs.webkit.org/show_bug.cgi?id=199875
+ <rdar://problem/50060561>
+
+ Reviewed by Megan Gardner.
+
+ In r202295, we added an ios-specific quirk to prevent scrolling on iOS because of UIKit/WebKit scrolling discrepancies.
+ In r244141, we changed the scrolling behavior to be more like macOS, and the test was broken. Since this was an intentional
+ change and the bugs reported in rdar://problem/26805722 (initially fixed by r202295) and rdar://problem/49225507 (fixed by r244141)
+ are both behaving as desired, the intentional change in r244141 should be reflected by new test expectations.
+ We do want typing in an input field in an iframe to scroll as we type.
+
+ * fast/forms/ios/delete-in-input-in-iframe-expected.txt:
+ * fast/forms/ios/delete-in-input-in-iframe.html:
+
2019-07-18 Youenn Fablet <you...@apple.com>
Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
Modified: trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt (247570 => 247571)
--- trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt 2019-07-18 19:05:29 UTC (rev 247570)
+++ trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt 2019-07-18 19:06:35 UTC (rev 247571)
@@ -1,5 +1,5 @@
Tests that typing into a text input in an iframe should not scroll.
-PASS: page did not scroll.
+PASS: page scrolled to 1143
Click to focus input
Modified: trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe.html (247570 => 247571)
--- trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe.html 2019-07-18 19:05:29 UTC (rev 247570)
+++ trunk/LayoutTests/fast/forms/ios/delete-in-input-in-iframe.html 2019-07-18 19:06:35 UTC (rev 247571)
@@ -39,7 +39,7 @@
function pageDidScroll()
{
- document.getElementById('result').textContent = 'FAIL: page scrolled to ' + document.scrollingElement.scrollTop;
+ document.getElementById('result').textContent = 'PASS: page scrolled to ' + document.scrollingElement.scrollTop;
}
function testTyping()
@@ -76,7 +76,7 @@
<p>Tests that typing into a text input in an iframe should not scroll.</p>
<div id="result">
- PASS: page did not scroll.
+ FAIL: page did not scroll.
</div>
<button id="target" _onclick_="buttonClicked()">Click to focus input</button>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
